Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-132517 Don't check that the target is editable, we are already checking that the fragment is active so this won't run when editable is active. #4813

Closed
wants to merge 1 commit into from
Closed

LPS-132517 Don't check that the target is editable, we are already checking that the fragment is active so this won't run when editable is active. #4813

wants to merge 1 commit into from

Conversation

victorg1991
Copy link
Collaborator

No description provided.

@victorg1991
LPS-132517 Don't check that the target is editable, we are already ch…
b6c95bf 
…ecking that the fragment is active so this won't run when editable is active.

Some fragment have focusable editable fields like the button fragment that result in the editable element focused when clicking on the fragment. This makes de fragment unremovable by keyboard
@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@victorg1991
Copy link
Collaborator Author

ci:test:sf

@victorg1991 victorg1991 added the 🔍 Frontend Review Needed Frontend code needs to be reviewed by a member of the team. label Jun 8, 2021
@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: d0f6b0ff617f356c63894822b27b21f09a39fdb3

Sender Branch:

Branch Name: remove_LPS-132517
Branch GIT ID: b6c95bf22ead3dc67929f968cb2220e272903e32

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

@p2kmgcl p2kmgcl added ✅ Ready to Merge Pull request is ready and can be forwarded. and removed 🔍 Frontend Review Needed Frontend code needs to be reviewed by a member of the team. labels Jun 8, 2021
@p2kmgcl
Copy link

p2kmgcl commented Jun 8, 2021

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

Skipping previously passed test suites:
ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 10 out of 10 jobs passed

✔️ ci:test:relevant - 24 out of 25 jobs passed in 2 hours 46 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: d0f6b0ff617f356c63894822b27b21f09a39fdb3

Upstream Comparison:

Branch GIT ID: d0f6b0ff617f356c63894822b27b21f09a39fdb3
Jenkins Build URL: Acceptance Upstream DXP (master) #1961

ci:test:stable - 10 out of 10 jobs PASSED
10 Successful Jobs:
ci:test:relevant - 23 out of 25 jobs PASSED
23 Successful Jobs:
For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at d0f6b0f:
  1. test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0
    Job Results:

    1207 Tests Passed.
    2 Tests Failed.

    1. AXIS_VARIABLE=3,label_exp=!master #436829
      1. com.liferay.layout.set.prototype.exportimport.test.LayoutSetPrototypeExportImportTest.classMethod
        org.springframework.orm.hibernate3.HibernateOptimisticLockingFailureException: Object of class [com.liferay.portal.model.impl.LayoutSetPrototypeImpl] with identifier [41880]: optimistic locking failed; nested exception is org.hibernate.StaleObjectStateException: Row was updated or deleted by another transaction (or unsaved-value mapping was incorrect): [com.liferay.portal.model.impl.LayoutSetPrototypeImpl#41880]
	at org.springframework.orm.hibernate3.SessionFactoryUtils.convertHibernateAccessException(SessionFactoryUtils.java:699)
	at org.springframework.orm.hibernate3.SpringSessionSynchronization.translateException(SpringSessionSynchronization.java:165)
	at org.springframework.orm.hibernate3.SpringSessionSynchronization.beforeCommit(SpringSessionSynchronization.java:153)
	at org.springframework.transaction.support.TransactionSynchronizationUtils.triggerBeforeCommit(TransactionSynchronizationUtils.java:96)
	at org.springframework.transaction.support.AbstractPlatformTransactionManager.triggerBeforeCommit(AbstractPlatformTransactionManager.java:919)
	at org.springframework.transaction.support.AbstractPlatformTransactionManager.processCommit(AbstractPlatformTransactionManager.java:727)
	at org.springframework.transaction.support.AbstractPlatformTransactionManager.commit(AbstractPlatformTransactionManager.java:711)
	at com.liferay.portal.spring.transaction.DefaultTransactionExecutor.commit(DefaultTransactionExecutor.java:41)
	at com.liferay.portal.spring.transaction.BaseTransa...
      2. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError: 
Unable to connect to a valid mail server. Please make sure one is properly configured: Couldn't connect to host, port: localhost, 25; timeout -1
	at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)
	at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)
	at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)
	at java.nio.file.Files.walkFileTree(Files.java:2670)
	at java.nio.file.Files.walkFileTree(Files.java:2742)
	at com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog(PortalLogAssertorTest.java:86)

@liferay-continuous-integration
Copy link
Collaborator

All required test suite(s) passed.
Forwarding pull request to brianchandotcom.
Console

@liferay-continuous-integration liferay-continuous-integration mentioned this pull request Jun 8, 2021
Closed
@liferay-continuous-integration
Copy link
Collaborator

Pull request has been successfully forwarded to brianchandotcom#102912
Console

@liferay-continuous-integration
Copy link
Collaborator

@victorg1991 victorg1991 deleted the remove_LPS-132517 branch June 24, 2021 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:test:relevant - success ci:test:sf - success ci:test:stable - success ✅ Ready to Merge Pull request is ready and can be forwarded.
Projects
None yet
Milestone
No milestone
3 participants
@victorg1991 @liferay-continuous-integration @p2kmgcl