Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-135930 Use context locale for ResourceBundle #5270

Closed
wants to merge 2 commits into from
Closed

LPS-135930 Use context locale for ResourceBundle #5270

wants to merge 2 commits into from

Conversation

p2kmgcl
Copy link

@p2kmgcl p2kmgcl commented Jul 21, 2021

No description provided.

@p2kmgcl
Copy link
Author

p2kmgcl commented Jul 21, 2021

ci:forward

@p2kmgcl
Copy link
Author

p2kmgcl commented Jul 21, 2021

/cc @jkappler

@liferay-continuous-integration
Copy link
Collaborator

Please only forward critical changes to Brian Chan during stabilization. Nonurgent changes should wait until the ongoing 7.4 DXP EP3 & CE GA3 release has been completed. For more details on the release timeline and status, see product-delivery.

@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@p2kmgcl p2kmgcl added the ✅ Ready to Merge Pull request is ready and can be forwarded. label Jul 21, 2021
@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: f55464ed1e0df5fc96a7faa97e72ef5b0b662460

Sender Branch:

Branch Name: pr/p2kmgcl/739
Branch GIT ID: 0a5ceb47bc015e7a11dd89f0583d1954633195c2

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 21 out of 23 jobs passed in 1 hour 31 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: f55464ed1e0df5fc96a7faa97e72ef5b0b662460

Upstream Comparison:

Branch GIT ID: f55464ed1e0df5fc96a7faa97e72ef5b0b662460
Jenkins Build URL: Acceptance Upstream DXP (master) #2127

ci:test:stable - 9 out of 9 jobs PASSED
9 Successful Jobs:
ci:test:relevant - 20 out of 23 jobs PASSED
20 Successful Jobs:
For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at f55464e:
  1. test-portal-acceptance-pullrequest-batch(master)/semantic-versioning-jdk8/0
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #232167
      clean-up-java-processes:
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/clean_up_java_processes.sh
[stopwatch] [run.batch.test.setup: 39:36.382 sec]
     [echo] run.batch.test.action.start.timestamp: 07-21-2021 07:14:56:652 PDT
     [echo] Checking for baseline log files.
     [echo] 
     [echo] ##
     [echo] ## /opt/dev/projects/github/liferay-portal/baseline-reports/portal-impl-7.log
     [echo] ##
     [echo] 
[beanshell] [Baseline Warning] Bundle Version Change Recommended: 7.8.5
[beanshell] 
     [echo] 
     [echo] ##
     [echo] ## /opt/dev/projects/github/liferay-portal/baseline-reports/portal-kernel-12.log
     [echo] ##
     [echo] 
[beanshell] [Baseline Warning] Bundle Version Change Recommended: 12.1.1
[beanshell] 
     [echo] 
     [echo] ##
     [echo] ## /opt/dev/projects/github/liferay-portal/baseline-reports/portal-test-9.log
     [echo] ##
     [echo] 
[beanshell] [Baseline Warning] Bundle Version Change Recommended: 9.3.6
[beanshell] 
     [echo] 
     [echo] ##
     [echo] ## /opt/dev/projects/github/liferay-portal/baseline-reports/util-java-6.log
     [echo] ##
     [echo] 
[beanshell] [Baseline Warning] Bundle Version Change Recommended: 6.0.5
[beanshell] 
     [echo] 
     [echo] ##
     [echo] ## /opt/dev/projects/github/liferay-portal/baseline-reports/util-slf4j-6.log
     [echo] ##
     [echo] 
[beanshell] [Baseline Warning] Bundle Version Change Recommended: 6.0.5
[beanshell] 
     [echo] 
     [echo] ##
     [echo] ## /opt/dev/projects/github/liferay-portal/baseline-reports/util-taglib-8.log
     [echo] ##
     [echo] 
[beanshell] [Baseline Warning] Bundle Version Change Recommended: 8.0.2
[beanshell] 
[stopwatch] [run.batch.test.action: 18.992 sec]
     [echo] Semantic versioning is incorrect.
      [get] Getting: http://test-1-18/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master/232167//consoleText
      [get] To: /opt/dev/projects/github/liferay-portal/20210721071515646.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/20210721071515646.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/null734237074.properties
  2. test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0
    Job Results:

    851 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #3897
      1. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError: 
Error executing FreeMarker template
FreeMarker template error:
The following has evaluated to null or missing:
==> fragmentElementIds  [in template "template_id" at line 2, column 15]

        

        Tip: If the failing expression is known to legally refer to something that's sometimes null or missing, either specify a default value like myOptionalVar!myDefault, or use [#if myOptionalVar??]when-present[#else]when-missing[/#if]. (These only cover the last step of the expression; to cover the whole expression, use parenthesis: (myOptionalVar.foo)!myDefault, (myOptionalVar.foo)??
        

        

        FTL stack trace ("~" means nesting-related):
        
- Failed at: ${fragmentElementIds}  [in template "template_id" at line 2, column 13]
        

        Java stack trace (for programmers):
        

        freemarker.core.InvalidReferenceException: [... Exception message was already printed; see it above ...]
        
at freemarker.core.InvalidReferenceException.getInstance(InvalidReferenceException.java:134)
        
at freemarker.core.EvalUtil.coerceModelToTextualCommon(EvalUtil.java:479)
        
at freemarker.core.EvalUtil.coerceModelToStringOrMarkup(EvalUtil.java:401)
        
at freemarker.core.EvalUtil.coerceModelToStringOrMarkup(EvalUtil.java:370)
        
at freemarker.core.DollarVariable.calculateInterpolatedStringOrMarkup(DollarVariable.java:100)
        
at freemarker.core.DollarVariable.accept(DollarVariable.java:63)
        
at freemarker.core.Environment.visit(Environment.java:331)
        
at freemarker.core.Environment.visit(Environme...

@liferay-continuous-integration
Copy link
Collaborator

All required test suite(s) passed.
Forwarding pull request to brianchandotcom.
Console

Closed
@liferay-continuous-integration
Copy link
Collaborator

Pull request has been successfully forwarded to brianchandotcom#104616
Console

@liferay-continuous-integration
Copy link
Collaborator

@p2kmgcl p2kmgcl deleted the pr/p2kmgcl/739 branch August 24, 2021 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:test:relevant - success ci:test:sf - success ci:test:stable - success ✅ Ready to Merge Pull request is ready and can be forwarded.
Projects
None yet
Milestone
No milestone
3 participants
@p2kmgcl @liferay-continuous-integration @jkappler