LPS-110351 Wrap tests render in act #537
Conversation
The goal of this change to mark the `Liferay.Util.toggleDisabled` function as deprecated: we still need it as a global to avoid breaking changes, but now we also provide a way to `import` the function to avoid using globals.
In this function we set the disabled attribute on a collection of `Node`s, which should be a boolean value according to https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/disabled but up to now this function would accept any value
As disussed here julien#273 (comment), in [d87f904](julien@d87f904) a type check was added for the `state` argument but since it might break exiting code we should remove it.
As discussed here julien@d87f904#r417834122, we should avoid using magic constants.
As suggested here julien#273 (comment), add blank lines before and after `for` blocks and add a blank line after `const` declarations
In [9e8c412](julien@9e8c412), we used a named import for the `toggleDisabled` function which is exported as default, and this caused the following error https://issues.liferay.com/browse/LPS-112842
|
To conserve resources, the PR Tester does not automatically run for every pull. If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed. If your pull was never tested, comment "ci:test" to run the PR Tester for this pull. |
|
ci:forward |
|
CI is automatically triggering the following test suites:
The pull request will automatically be forwarded to the user
|
|
Invoking pull request test at sender hash |
|
Invoking pull request test at sender hash |
✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPS-110351 1 Successful Jobs:For more details click here. |
|
All required test suite(s) passed. |
|
Pull request has been successfully forwarded to brianchandotcom#88345 |
No description provided.