LPS-140433 Wrong redirect for Web Content when Workflow is enabled #6086

IstvanD · 2021-10-07T16:22:54Z

Dear Team,

Could you please review this pull request?

The changes I made are preserving the Journal Article's friendlyURL as the redirect URL when Workflow is configured.

Thank you and best regards,
István

… the entity.

…dTypeConstants class

…tation

…e implementation

…rvice implementation

…nce add button enabled is taking into account enableTemplateCreation configuration

…thout this the description is rendered as a simple input

liferay-continuous-integration · 2021-10-13T07:28:16Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 05e1f5030d43bb6c1bf943c483fd50aae7a75a23

Sender Branch:

Branch Name: LPS-140433
Branch GIT ID: 500603de3192c9a7d7b60183506f87de9597ea7d

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2021-10-13T07:32:13Z

Jenkins Build:test-portal-source-format#537

Jenkins Report:jenkins-report.html

Jenkins Suite:sf

Pull Request:liferay-echo#6086

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:sf - IstvanD > liferay-echo - PR#6086 - 2021-10-13[00:25:07]

Testray Importer:publish-testray-report#1642

liferay-continuous-integration · 2021-10-13T09:09:17Z

✔️ ci:test:stable - 10 out of 10 jobs passed

❌ ci:test:relevant - 23 out of 26 jobs passed in 1 hour 43 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 05e1f5030d43bb6c1bf943c483fd50aae7a75a23

Upstream Comparison:

Branch GIT ID: 05e1f5030d43bb6c1bf943c483fd50aae7a75a23
Jenkins Build URL: Acceptance Upstream DXP (master) #2433

ci:test:stable - 10 out of 10 jobs PASSED

10 Successful Jobs:

ci:test:relevant - 23 out of 26 jobs PASSED

3 Failed Jobs:

23 Successful Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0
Job Results:
149 Tests Passed.
1 Test Failed.
1. AXIS_VARIABLE=17 #8506
  1. LocalFile.ContentPagesWithContentsPanel#EditDisplayedWebContentInWebContentDisplay - Poshi Report - Poshi Summary - Console Output

Failures in common with acceptance upstream results at 05e1f50:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0
Job Results:
149 Tests Passed.
2 Tests Failed.
1. AXIS_VARIABLE=15 #8506
  1. LocalFile.ContentPageTemplates#ChangeEditableImage - Poshi Report - Poshi Summary - Console Output
2. AXIS_VARIABLE=2 #8506
  1. LocalFile.AssetPublisherUseCase#FilterAndOrderAssetsByField - Poshi Report - Poshi Summary - Console Output

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0

Job Results:

2672 Tests Passed.
10 Tests Failed.

AXIS_VARIABLE=4 #10845

com.liferay.document.library.convert.test.DocumentLibraryConvertProcessTest.testMigrateDLAndDeleteFilesInSourceStore

com.liferay.portal.convert.ConvertException: com.liferay.portal.kernel.exception.SystemException: java.lang.AssertionError: {level=ERROR, loggerName=com.liferay.document.library.internal.convert.document.library.DLFileVersionDLStoreConvertProcess, message=Unable to migrate 1
	at com.liferay.portal.convert.BaseConvertProcess.convert(BaseConvertProcess.java:70)
	at com.liferay.document.library.convert.test.DocumentLibraryConvertProcessTest.tearDown(DocumentLibraryConvertProcessTest.java:120)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
	at org.junit.internal.runners.statements.RunAfters.invokeMethod(RunAfters.java:46)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:33)
	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
	at...

com.liferay.document.library.convert.test.DocumentLibraryConvertProcessTest.testMigrateDLAndKeepFilesInSourceStore

com.liferay.portal.convert.ConvertException: com.liferay.portal.kernel.exception.SystemException: java.lang.AssertionError: {level=ERROR, loggerName=com.liferay.document.library.internal.convert.document.library.DLFileVersionDLStoreConvertProcess, message=Unable to migrate 1
	at com.liferay.portal.convert.BaseConvertProcess.convert(BaseConvertProcess.java:70)
	at com.liferay.document.library.convert.test.DocumentLibraryConvertProcessTest.testMigrateAndCheckOldRepositoryFiles(DocumentLibraryConvertProcessTest.java:316)
	at com.liferay.document.library.convert.test.DocumentLibraryConvertProcessTest.testMigrateDLAndKeepFilesInSourceStore(DocumentLibraryConvertProcessTest.java:136)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at com.liferay.arquillian.extension.junit.bridge.server.TestExecutorRunnable$3.evaluate(TestExecutorRunnable.java:353)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
	at com.liferay.portal.kernel.test.rule.AbstractTes...

com.liferay.document.library.convert.test.DocumentLibraryConvertProcessTest.testMigrateDLWhenFileEntryEmpty

com.liferay.portal.convert.ConvertException: com.liferay.portal.kernel.exception.SystemException: java.lang.AssertionError: {level=ERROR, loggerName=com.liferay.document.library.internal.convert.document.library.DLFileVersionDLStoreConvertProcess, message=Unable to migrate 1
	at com.liferay.portal.convert.BaseConvertProcess.convert(BaseConvertProcess.java:70)
	at com.liferay.document.library.convert.test.DocumentLibraryConvertProcessTest.testMigrateDLWhenFileEntryEmpty(DocumentLibraryConvertProcessTest.java:151)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at com.liferay.arquillian.extension.junit.bridge.server.TestExecutorRunnable$3.evaluate(TestExecutorRunnable.java:353)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
	at com.liferay.portal.kernel.te...

...

AXIS_VARIABLE=6 #10845

com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog

junit.framework.AssertionFailedError: 
JSON storage adapter is deprecated, using default storage adapter
	at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)
	at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)
	at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)
	at java.nio.file.Files.walkFileTree(Files.java:2670)
	at java.nio.file.Files.walkFileTree(Files.java:2742)
	at com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog(PortalLogAssertorTest.java:86)

liferay-continuous-integration · 2021-10-13T09:19:15Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#538

Jenkins Report:jenkins-report.html

Jenkins Suite:relevant

Pull Request:liferay-echo#6086

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:relevant - IstvanD > liferay-echo - PR#6086 - 2021-10-13[00:24:26]

Testray Importer:publish-testray-report#1648

jkappler · 2021-10-13T09:53:52Z

ci:test:relevant

jkappler · 2021-10-13T09:54:17Z

Failing test doesn't seem related to the PR

liferay-continuous-integration · 2021-10-13T11:51:20Z

✔️ ci:test:stable - 10 out of 10 jobs passed

✔️ ci:test:relevant - 24 out of 26 jobs passed in 1 hour 56 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 05e1f5030d43bb6c1bf943c483fd50aae7a75a23

Upstream Comparison:

Branch GIT ID: 05e1f5030d43bb6c1bf943c483fd50aae7a75a23
Jenkins Build URL: Acceptance Upstream DXP (master) #2433

ci:test:stable - 10 out of 10 jobs PASSED

10 Successful Jobs:

ci:test:relevant - 23 out of 26 jobs PASSED

3 Failed Jobs:

23 Successful Jobs:

For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at 05e1f50:

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0

Job Results:

7 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=4 #4713

     [exec] * What went wrong:
     [exec] Execution failed for task ':apps:bookmarks:bookmarks-web:jar'.
     [exec] > Bundle com.liferay.bookmarks.web-5.0.13.jar has errors
     [exec] 
     [exec] * Try:
     [exec] Run with --info or --debug option to get more log output. Run with --scan to get full insights.
     [exec] 
     [exec] * Exception is:
     [exec] 306 actionable tasks: 212 executed, 94 up-to-date
     [exec] org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':apps:bookmarks:bookmarks-web:jar'.
     [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.lambda$executeIfValid$1(ExecuteActionsTaskExecuter.java:208)
     [exec] 	at org.gradle.internal.Try$Failure.ifSuccessfulOrElse(Try.java:263)
     [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeIfValid(ExecuteActionsTaskExecuter.java:206)
     [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:187)
     [exec] 	at org.gradle.api.internal.tasks.execution.CleanupStaleOutputsExecuter.execute(CleanupStaleOutputsExecuter.java:114)
     [exec] 	at org.gradle.api.internal.tasks.execution.FinalizePropertiesTaskExecuter.execute(FinalizePropertiesTaskExecuter.java:46)
     [exec] 
     [exec] 	at org.gradle.api.internal.tasks.execution.ResolveTaskExecutionModeExecuter.execute(ResolveTaskExecutionModeExecuter.java:62)
     [exec] 	at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:57)
     [exec] See the profiling report at: file:///opt/dev/projects/github/liferay-portal/build/reports/profile/profile-2021-10-13-03-55-41.html	at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:56)
     [exec] A fine-grained performance profile is available: use the --scan option.
     [exec] 
     [exec] 	at org.gradle.api.internal.tasks.execution.CatchExceptionTaskExecuter.execute(CatchExceptionTaskExecuter.java:36)
     [exec] 	at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.executeTask(EventFiringTaskExecuter.java:77)
     [exec] 	at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:55)
     [exec] 	at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:52)

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0
Job Results:
150 Tests Passed.
2 Tests Failed.
1. AXIS_VARIABLE=15 #8842
  1. LocalFile.ContentPageTemplates#ChangeEditableImage - Poshi Report - Poshi Summary - Console Output
2. AXIS_VARIABLE=2 #8842
  1. LocalFile.AssetPublisherUseCase#FilterAndOrderAssetsByField - Poshi Report - Poshi Summary - Console Output

ealonso · 2021-10-13T11:53:30Z

ci:forward

liferay-continuous-integration · 2021-10-13T11:53:34Z

CI is automatically triggering the following test suites:

ci:test:relevant
ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

ci:test:relevant
ci:test:sf
ci:test:stable

liferay-continuous-integration · 2021-10-13T11:53:35Z

Skipping previously passed test suites:
ci:test:relevant
ci:test:sf

liferay-continuous-integration · 2021-10-13T11:54:25Z

All required test suite(s) passed.
Forwarding pull request to brianchandotcom.
Console

liferay-continuous-integration · 2021-10-13T11:54:38Z

Pull request has been successfully forwarded to brianchandotcom#108512
Console

liferay-continuous-integration · 2021-10-13T11:56:14Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#542

Jenkins Report:jenkins-report.html

Jenkins Suite:relevant

Pull Request:liferay-echo#6086

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:relevant - IstvanD > liferay-echo - PR#6086 - 2021-10-13[02:54:16]

Testray Importer:publish-testray-report#1656

IstvanD · 2021-10-13T12:32:34Z

Thanks for forwarding, @ealonso! 👍

veroglez and others added 30 commits October 7, 2021 05:44

LPS-140077 Add package.json

be55e12

LPS-140077 Remove AUI code from jsp

913dc2f

LPS-140077 Migrate code in a new js file

51cabf4

LPS-140077 Put the info message on the top

fa13c6e

LRQA-70727 Use the general locator

63c2099

LRQA-70727 Remove deprecated locators

2d2512e

LPS-139326 Added the indexable select fields to the list of fields of…

789cc33

… the entity.

LPS-139326 Replace deprecated DDMFormFieldType class with DDMFormFiel…

0767b64

…dTypeConstants class

COMMERCE-7414 Added build markers

016cdc2

COMMERCE-7414 Added new constant

4a5f1d6

COMMERCE-7414 Added commerce order rule entry permission checker

2a10f9a

COMMERCE-7414 Added commerce order rule entry model resource implemen…

6afd4ab

…tation

COMMERCE-7414 Export packages

6276800

COMMERCE-7414 Added resource action mapping

8d07c7d

COMMERCE-7414 Added required dependencies

9ff6b08

COMMERCE-7414 Added commerce order rule entry implementation

f4c4702

COMMERCE-7414 Added commerce order rule entry rel implementation

3e6d7e0

COMMERCE-7414 Added commerce order rule entry local and remote servic…

5c034a5

…e implementation

COMMERCE-7414 Added commerce order rule entry rel local and remote se…

b9923c4

…rvice implementation

COMMERCE-7414 Auto SF

7b944e5

COMMERCE-7414 Regen services

8e104da

COMMERCE-7414 SF

881403d

COMMERCE-7414 This is strange, please resend. settings != typeSettings

6187ce1

COMMERCE-7414 regen

347a100

COMMERCE-7414 please resend

82d92eb

LPS-140417 Extract into a new method

31b89b3

LPS-140417 Uses is staging group method instead add button enabled si…

cf07d7a

…nce add button enabled is taking into account enableTemplateCreation configuration

LPS-140418 Uses correct check

317e370

LPS-77699 Update Translations

0ca6f6e

LPS-140421 Set the display-height to keep the field as a textarea, wi…

8c4c2d7

…thout this the description is rendered as a simple input

liferay-continuous-integration added ci:test:relevant - failure ci:test:stable - success and removed ci:test:relevant - pending ci:test:stable - pending labels Oct 13, 2021

jkappler added ✅ Ready to Merge Pull request is ready and can be forwarded. and removed 🔍 Backend Review Needed Backend code needs to be reviewed by a member of the team. labels Oct 13, 2021

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending ci:test:relevant - success ci:test:stable - success and removed ci:test:relevant - failure ci:test:stable - success ci:test:relevant - pending ci:test:stable - pending labels Oct 13, 2021

liferay-continuous-integration mentioned this pull request Oct 13, 2021

LPS-140433 Wrong redirect for Web Content when Workflow is enabled brianchandotcom/liferay-portal#108512

Closed

liferay-continuous-integration closed this Oct 13, 2021

LPS-140433 Wrong redirect for Web Content when Workflow is enabled #6086

LPS-140433 Wrong redirect for Web Content when Workflow is enabled #6086

Conversation

IstvanD commented Oct 7, 2021 • edited

liferay-continuous-integration commented Oct 13, 2021

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Oct 13, 2021

liferay-continuous-integration commented Oct 13, 2021

✔️ ci:test:stable - 10 out of 10 jobs passed

❌ ci:test:relevant - 23 out of 26 jobs passed in 1 hour 43 minutes

Base Branch:

Upstream Comparison:

3 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0

Job Results:

liferay-continuous-integration commented Oct 13, 2021

jkappler commented Oct 13, 2021

jkappler commented Oct 13, 2021

liferay-continuous-integration commented Oct 13, 2021

✔️ ci:test:stable - 10 out of 10 jobs passed

✔️ ci:test:relevant - 24 out of 26 jobs passed in 1 hour 56 minutes

Base Branch:

Upstream Comparison:

3 Failed Jobs:

For more details click here.

This pull contains no unique failures.

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0

Job Results:

ealonso commented Oct 13, 2021

liferay-continuous-integration commented Oct 13, 2021

liferay-continuous-integration commented Oct 13, 2021

liferay-continuous-integration commented Oct 13, 2021

liferay-continuous-integration commented Oct 13, 2021

liferay-continuous-integration commented Oct 13, 2021

IstvanD commented Oct 13, 2021

IstvanD commented Oct 7, 2021 •

edited