LPS-143919 Simulation iframe allows the user to interact with the control menu #6887

beltranrengifo · 2022-01-10T06:57:28Z

Motivation

Get rid of a weird app-in-app situation on the simulator device panel, due to the presence of the control menu after the first navigation.
The param p_l_mode=preview used for hiding this menu only works for the first load of the iframe.

Solution proposed

Now, the JS verifies if the param is present after a navigation, adding it if needed.
In case portal navigation occurs, a listener will handle the DOM to create a smooth transition between pages vía CSS.

Steps

Create a page
Navigate to home
Open the simulator
Click on the new page menu item, in order to navigate

Actual: The new loaded page shows the control menu
Expected: The new loaded page does not display the control menu

Note: after navigation, a visible delay before hiding the control menu is expected

liferay-continuous-integration · 2022-01-10T06:57:33Z

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

beltranrengifo · 2022-01-10T06:59:01Z

ci:test:sf

liferay-continuous-integration · 2022-01-10T07:13:24Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 26445341f1a9d1d4fa9dd05ee88932b57f8844f6

Sender Branch:

Branch Name: LPS-143919
Branch GIT ID: d5f76cf3fba06599054300db64771724788785b9

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

beltranrengifo · 2022-01-10T07:14:33Z

ci:test:relevant

liferay-continuous-integration · 2022-01-10T07:16:21Z

Jenkins Build:test-portal-source-format#4487

Jenkins Report:jenkins-report.html

Jenkins Suite:sf

Pull Request:liferay-echo#6887

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:sf - beltranrengifo > liferay-echo - PR#6887 - 2022-01-09[23:09:41]

Testray Importer:publish-testray-report#1682

liferay-continuous-integration · 2022-01-10T08:56:16Z

✔️ ci:test:stable - 11 out of 11 jobs passed

✔️ ci:test:relevant - 26 out of 27 jobs passed in 1 hour 27 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 26445341f1a9d1d4fa9dd05ee88932b57f8844f6

Upstream Comparison:

Branch GIT ID: 410d9593cb9ec56cba8dca1d2035405257627714
Jenkins Build URL: Acceptance Upstream DXP (master) #2783

ci:test:stable - 11 out of 11 jobs PASSED

11 Successful Jobs:

ci:test:relevant - 25 out of 27 jobs PASSED

2 Failed Jobs:

25 Successful Jobs:

For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at 410d959:

test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8/0

Job Results:

3 Tests Passed.
2 Tests Failed.

AXIS_VARIABLE=0 #25831

com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanOSGiLog

junit.framework.AssertionFailedError: Portal log assert failure, OSGi log found: /opt/dev/projects/github/liferay-portal/bundles/osgi/state/1641804352421.log: !SESSION 2022-01-10 08:46:15.555 ----------------------------------------------- eclipse.buildId=unknown java.version=1.8.0_121 java.vendor=Oracle Corporation BootLoader constants: OS=linux, ARCH=x86_64, WS=gtk, NL=en_US !ENTRY com.liferay.site.initializer.extender 4 0 2022-01-10 08:46:15.555 !MESSAGE FrameworkEvent ERROR !STACK 0 org.osgi.framework.BundleException: Could not resolve module: com.liferay.site.initializer.extender [662] Unresolved requirement: Import-Package: com.liferay.commerce.account.util; version="1.3.0" at org.eclipse.osgi.container.Module.start(Module.java:444) at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1682) at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1662) at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1624) at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1555) at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1) at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230) at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:340)

at com.lifer...

com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog

junit.framework.AssertionFailedError: FrameworkEvent ERROR org.osgi.framework.BundleException: Could not resolve module: com.liferay.site.initializer.extender [662] Unresolved requirement: Import-Package: com.liferay.commerce.account.util; version="1.3.0" at org.eclipse.osgi.container.Module.start(Module.java:444) at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1682) at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1662) at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1624) at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1555) at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1) at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230) at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:340)

at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171) at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98) at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88) at java.nio.file.Files.walkFileTree(Files.java:2670) at java.nio.file.Files.walkFileTree(Files.java:2742) at com.liferay.portal.log.asser...

liferay-continuous-integration · 2022-01-10T09:00:10Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#1930

Jenkins Report:jenkins-report.html

Jenkins Suite:relevant

Pull Request:liferay-echo#6887

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:relevant - beltranrengifo > liferay-echo - PR#6887 - 2022-01-09[23:28:25]

Testray Importer:publish-testray-report#6005

beltranrengifo · 2022-01-10T11:27:16Z

ci:test:echo

liferay-continuous-integration · 2022-01-10T14:11:36Z

❌ ci:test:echo - 15 out of 22 jobs passed in 2 hours 44 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: b348076325e5c8ae22676237c2cbbd0299156056

Upstream Comparison:

Branch GIT ID: b348076325e5c8ae22676237c2cbbd0299156056
Jenkins Build URL: Acceptance Upstream DXP (master) #2786

ci:test:echo - 15 out of 22 jobs PASSED

7 Failed Jobs:

15 Successful Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/6

Job Results:

24 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=6 #5578

     [echo] ##
     [echo] 
[beanshell] 2022-01-10 04:58:32
[beanshell] Full thread dump Java HotSpot(TM) 64-Bit Server VM (25.121-b13 mixed mode):
[beanshell] 
[beanshell] "Attach Listener" #37 daemon prio=9 os_prio=0 tid=0x00007fcf80001000 nid=0x17c2f8 waiting on condition [0x0000000000000000]
[beanshell]    java.lang.Thread.State: RUNNABLE
[beanshell] 
[beanshell]    Locked ownable synchronizers:
[beanshell]   - None
[beanshell] 
[beanshell] "http-nio-8080-exec-10" #36 daemon prio=5 os_prio=0 tid=0x00007fcf40011000 nid=0x17bdfe waiting on condition [0x00007fcf4b2d4000]
[beanshell] 
   [delete] Deleting: /tmp/Bootstrap__1555811.log
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/jps_output
[stopwatch] [run.batch.test.action: 33:27.919 sec]
     [echo] The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:365: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:1662: /opt/dev/projects/github/liferay-portal/build-test-batch.xml:1666: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-tomcat.xml:50: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-tomcat.xml:62: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:13450: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:13815: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:4696: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:4777: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:5768: No server is available at http://localhost:8080/web/guest
      [get] Getting: http://test-1-36/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=6/5578//consoleText
      [get] To: /opt/dev/projects/github/liferay-portal/20220110045833758.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/20220110045833758.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/null427211691.properties

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/13
Job Results:
61 Tests Passed.
5 Tests Failed.
Click here for more failures.
test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/5
Job Results:
169 Tests Passed.
1 Test Failed.
1. AXIS_VARIABLE=5 #24964
  1. LocalFile.DisplayPageTemplates#ViewPreviewDraftViaURLFromNonAuthor - Poshi Report - Poshi Summary - Console Output
test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/9
Job Results:
157 Tests Passed.
1 Test Failed.
1. AXIS_VARIABLE=9 #25896
  1. LocalFile.ProductMenu#ViewProductMenuWorkOnMobileDevice - Poshi Report - Poshi Summary - Console Output

Failures in common with acceptance upstream results at b348076:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/7
Job Results:
90 Tests Passed.
1 Test Failed.
1. AXIS_VARIABLE=22 #22007
  1. LocalFile.MastersPageTemplates#PropagateChangesFromCustomMastersToAllBasedOnCustomMasters - Poshi Report - Poshi Summary - Console Output
...

liferay-continuous-integration · 2022-01-10T14:20:20Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#1485

Jenkins Report:jenkins-report.html

Jenkins Suite:echo

Pull Request:liferay-echo#6887

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:echo - beltranrengifo > liferay-echo - PR#6887 - 2022-01-10[03:27:28]

Testray Importer:publish-testray-report#4406

beltranrengifo · 2022-01-10T15:56:24Z

ci:test:sf

liferay-continuous-integration · 2022-01-10T16:00:49Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 3d2a74598c120e8d3b5055ea8a220c70bb1e38ac

Sender Branch:

Branch Name: LPS-143919
Branch GIT ID: 28afdbc51137e563930d05be6c6296142b5019da

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

sandrodw3 · 2022-01-10T16:01:34Z

ci:forward

liferay-continuous-integration · 2022-01-10T16:01:37Z

CI is automatically triggering the following test suites:

ci:test:relevant
ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

ci:test:relevant
ci:test:sf
ci:test:stable

liferay-continuous-integration · 2022-01-10T16:01:41Z

Skipping previously passed test suites:
ci:test:sf

liferay-continuous-integration · 2022-01-10T16:03:15Z

Jenkins Build:test-portal-source-format#5603

Jenkins Report:jenkins-report.html

Jenkins Suite:sf

Pull Request:liferay-echo#6887

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:sf - beltranrengifo > liferay-echo - PR#6887 - 2022-01-10[07:57:21]

Testray Importer:publish-testray-report#1905

liferay-continuous-integration · 2022-01-10T17:39:35Z

✔️ ci:test:stable - 11 out of 11 jobs passed

✔️ ci:test:relevant - 26 out of 27 jobs passed in 1 hour 37 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 3d2a74598c120e8d3b5055ea8a220c70bb1e38ac

Upstream Comparison:

Branch GIT ID: 3d2a74598c120e8d3b5055ea8a220c70bb1e38ac
Jenkins Build URL: Acceptance Upstream DXP (master) #2787

ci:test:stable - 11 out of 11 jobs PASSED

11 Successful Jobs:

ci:test:relevant - 25 out of 27 jobs PASSED

2 Failed Jobs:

25 Successful Jobs:

For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at 3d2a745:

test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8/0
Job Results:
3 Tests Passed.
2 Tests Failed.
1. AXIS_VARIABLE=0 #26209
  1. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanOSGiLog
  2. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog

liferay-continuous-integration · 2022-01-10T17:40:15Z

All required test suite(s) passed.
Forwarding pull request to brianchandotcom.
Console

liferay-continuous-integration · 2022-01-10T17:40:42Z

Pull request has been successfully forwarded to brianchandotcom#111918
Console

liferay-continuous-integration · 2022-01-10T17:43:21Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#1490

Jenkins Report:jenkins-report.html

Jenkins Suite:relevant

Pull Request:liferay-echo#6887

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:relevant - beltranrengifo > liferay-echo - PR#6887 - 2022-01-10[08:01:48]

Testray Importer:publish-testray-report#4417

beltranrengifo changed the title ~~LPS 143919~~ LPS-143919 Simulation iframe allows the user to interact with the control menu Jan 10, 2022

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - success and removed ci:test:sf - pending labels Jan 10, 2022

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending ci:test:relevant - success ci:test:stable - success and removed ci:test:relevant - pending ci:test:stable - pending labels Jan 10, 2022

sandrodw3 self-assigned this Jan 10, 2022

sandrodw3 added the 🔍 Frontend Review Needed Frontend code needs to be reviewed by a member of the team. label Jan 10, 2022

liferay-continuous-integration added ci:test:echo - pending and removed ci:test:echo - pending labels Jan 10, 2022

Beltran Rengifo added 2 commits January 10, 2022 16:34

LPS-143919 Revert CSS fix in order to enable navigation again

ba6ad91

LPS-143919 Add preview param to iframe location in case is missing

131d02d

sandrodw3 removed their assignment Jan 10, 2022

sandrodw3 added the 🛠 Changes Required Code has been reviewed and needs changes. label Jan 10, 2022

sandrodw3 assigned beltranrengifo Jan 10, 2022

Beltran Rengifo added 2 commits January 10, 2022 16:55

LPS-143919 Use URL constructor for handling preview parameter

b29d4f5

LPS-143919 JS refactor

28afdbc

beltranrengifo force-pushed the LPS-143919 branch from d5f76cf to 28afdbc Compare January 10, 2022 15:55

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - success and removed ci:test:sf - success ci:test:sf - pending labels Jan 10, 2022

sandrodw3 added ✅ Ready to Merge Pull request is ready and can be forwarded. and removed 🛠 Changes Required Code has been reviewed and needs changes. labels Jan 10, 2022

sandrodw3 unassigned beltranrengifo Jan 10, 2022

liferay-continuous-integration added ci:test:relevant - pending and removed ci:test:relevant - success labels Jan 10, 2022

liferay-continuous-integration added ci:test:stable - pending ci:test:relevant - success ci:test:stable - success and removed ci:test:stable - success ci:test:relevant - pending ci:test:stable - pending labels Jan 10, 2022

liferay-continuous-integration mentioned this pull request Jan 10, 2022

LPS-143919 Simulation iframe allows the user to interact with the control menu brianchandotcom/liferay-portal#111918

Closed

liferay-continuous-integration closed this Jan 10, 2022

LPS-143919 Simulation iframe allows the user to interact with the control menu #6887

LPS-143919 Simulation iframe allows the user to interact with the control menu #6887

Conversation

beltranrengifo commented Jan 10, 2022 • edited

Motivation

Solution proposed

Steps

liferay-continuous-integration commented Jan 10, 2022

beltranrengifo commented Jan 10, 2022

liferay-continuous-integration commented Jan 10, 2022

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Base Branch:

Sender Branch:

For more details click here.

beltranrengifo commented Jan 10, 2022

liferay-continuous-integration commented Jan 10, 2022

liferay-continuous-integration commented Jan 10, 2022

✔️ ci:test:stable - 11 out of 11 jobs passed

✔️ ci:test:relevant - 26 out of 27 jobs passed in 1 hour 27 minutes

Base Branch:

Upstream Comparison:

2 Failed Jobs:

For more details click here.

This pull contains no unique failures.

test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8/0

Job Results:

liferay-continuous-integration commented Jan 10, 2022

beltranrengifo commented Jan 10, 2022

liferay-continuous-integration commented Jan 10, 2022

❌ ci:test:echo - 15 out of 22 jobs passed in 2 hours 44 minutes

Base Branch:

Upstream Comparison:

7 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/6

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/13

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/5

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/9

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/7

Job Results:

liferay-continuous-integration commented Jan 10, 2022

beltranrengifo commented Jan 10, 2022

liferay-continuous-integration commented Jan 10, 2022

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Base Branch:

Sender Branch:

For more details click here.

sandrodw3 commented Jan 10, 2022

liferay-continuous-integration commented Jan 10, 2022

liferay-continuous-integration commented Jan 10, 2022

liferay-continuous-integration commented Jan 10, 2022

liferay-continuous-integration commented Jan 10, 2022

✔️ ci:test:stable - 11 out of 11 jobs passed

✔️ ci:test:relevant - 26 out of 27 jobs passed in 1 hour 37 minutes

Base Branch:

Upstream Comparison:

2 Failed Jobs:

For more details click here.

This pull contains no unique failures.

test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8/0

Job Results:

liferay-continuous-integration commented Jan 10, 2022

liferay-continuous-integration commented Jan 10, 2022

liferay-continuous-integration commented Jan 10, 2022

beltranrengifo commented Jan 10, 2022 •

edited