Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-135492 Make input mask localizable #757

Closed
wants to merge 1 commit into from
Closed

LPS-135492 Make input mask localizable #757

wants to merge 1 commit into from

Conversation

brunofariasdeo
Copy link

No description provided.

@liferay-continuous-integration
Copy link
Collaborator

Please only forward critical changes to Brian Chan during stabilization. Nonurgent changes should wait until the ongoing 7.4 DXP EP3 & CE GA3 release has been completed. For more details on the release timeline and status, see product-delivery.

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:sf - 0 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: b2499f052d423911afc1071015f044472315a70a

Sender Branch:

Branch Name: LPS-135492-2
Branch GIT ID: 4ba4a25f4b9ba897fd18d96c39b4d214fd0c35c5

0 out of 1jobs PASSED
For more details click here.
     [exec] 
     [exec] Out-of-date TypeScript build artifacts at:
     [exec] 
     [exec]     apps/dynamic-data-mapping/dynamic-data-mapping-form-field-type/types
     [exec] 
     [exec] Please commit them.
     [exec] 
     [exec] M modules/apps/dynamic-data-mapping/dynamic-data-mapping-form-field-type/types/src/main/resources/META-INF/resources/NumericInputMask/NumericInputMask.d.ts
     [exec] 
     [exec] Generating types (2 of 7): @liferay/frontend-js-state-web
     [exec] Generating types (3 of 7): @liferay/frontend-js-react-web
     [exec] Generating types (4 of 7): @liferay/frontend-js-a11y-web
     [exec] Generating types (5 of 7): frontend-js-tooltip-support-web
     [exec] Generating types (6 of 7): item-selector-taglib
     [exec] Generating types (7 of 7): remote-app-client-js
     [exec] Preflight check failed:
     [exec] checkTypeScriptTypeArtifacts() failed: Error: Type generation was successful but 1 project was out of date. Please commit updated versions of the artifacts in the projects listed above.
     [exec] 
     [exec] Prettier checked 4 files
     [exec] 
     [exec] 1 of 3 jobs failed
     [exec] info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
     [exec] error Command failed with exit code 1.
     [exec] 
     [exec] > Task :packageRunCheckFormat FAILED
     [exec] Gradle build finished at 2021-07-22 15:42:38.774.
     [exec] 
     [exec] 
     [exec] FAILURE: Build failed with an exception.
     [exec] 
     [exec] * What went wrong:
     [exec] Execution failed for task ':packageRunCheckFormat'.
     [exec] > Process 'command '/opt/dev/projects/github/liferay-portal/build/node/bin/node'' finished with non-zero exit value 1
     [exec] 
     [exec] * Try:
     [exec] Run with --info or --debug option to get more log output. Run with --scan to get full insights.
     [exec] 
     [exec] * Exception is:
     [exec] org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':packageRunCheckFormat'.
     [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.lambda\$executeIfValid\$1(ExecuteActionsTaskExecuter.java:208)
     [exec] 	at org.gradle.internal.Try\$Failure.ifSuccessfulOrElse(Try.java:263)
     [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeIfValid(ExecuteActionsTaskExecuter.java:206)
     [exec] 	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:187)

@brunofariasdeo
Copy link
Author

ci:reopen

@liferay-continuous-integration
Copy link
Collaborator

@brunofariasdeo
Copy link
Author

ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 5 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: b2499f052d423911afc1071015f044472315a70a

Sender Branch:

Branch Name: LPS-135492-2
Branch GIT ID: 6eeb268e391f0e0947f630047b11b9160d50af96

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@brunofariasdeo
Copy link
Author

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 10 out of 10 jobs passed

❌ ci:test:relevant - 23 out of 26 jobs passed in 2 hours 6 minutes

Click here for more details.

This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result:

ci:reevaluate:1277401_486

Base Branch:

Branch Name: master
Branch GIT ID: b2499f052d423911afc1071015f044472315a70a

Upstream Comparison:

Branch GIT ID: b5bd25d65e74ce19974cd5a7ff3443cb0f022b79
Jenkins Build URL: Acceptance Upstream DXP (master) #2134

ci:test:stable - 10 out of 10 jobs PASSED
10 Successful Jobs:
ci:test:relevant - 23 out of 26 jobs PASSED
23 Successful Jobs:
For more details click here.

Failures unique to this pull:


Failures in common with acceptance upstream results at b5bd25d:

@liferay-continuous-integration
Copy link
Collaborator

@brunofariasdeo
Copy link
Author

ci:test:relevant

Comment on lines +44 to +45
defaultLanguageId: Locale;
editingLanguageId: Locale;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I didn't figure out it before, but those properties are not being used so you can delete them

Suggested change
defaultLanguageId: Locale;
editingLanguageId: Locale;

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:stable - 8 out of 10 jobs passed

❌ ci:test:relevant - 22 out of 26 jobs passed in 1 hour 54 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 5d67ea8c2b3b9a21f20ba2b77a1b5ea72ed5c809

Upstream Comparison:

Branch GIT ID: 5d67ea8c2b3b9a21f20ba2b77a1b5ea72ed5c809
Jenkins Build URL: Acceptance Upstream DXP (master) #2154

ci:test:stable - 8 out of 10 jobs PASSED
8 Successful Jobs:
ci:test:relevant - 22 out of 26 jobs PASSED
22 Successful Jobs:
For more details click here.

Failures unique to this pull:

  1. test-portal-acceptance-pullrequest-batch(master)/functional-upgrade-tomcat90-mysql57-jdk8_stable/0
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #474312
           [exec] * What went wrong:
           [exec] Execution failed for task ':runPoshi'.
           [exec] > There were failing tests. See the report at: file:///opt/dev/projects/github/liferay-portal/portal-web/tests/index.html
           [exec] 
           [exec] * Try:
           [exec] Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
           [exec] 
           [exec] * Get more help at https://help.gradle.org
           [exec] 
           [exec] BUILD FAILED in 4m 32s
           [exec] 3 actionable tasks: 2 executed, 1 up-to-date
           [exec] 
           [exec] See the profiling report at: file:///opt/dev/projects/github/liferay-portal/portal-web/build/reports/profile/profile-2021-07-27-07-22-41.html
           [exec] A fine-grained performance profile is available: use the --scan option.
           [exec] Result: 1
           [copy] Copying 1 file to /opt/dev/projects/github/liferay-portal/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0_label_exp=!master/builds/474312
           [copy] Copying 3 files to /opt/dev/projects/github/liferay-portal/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0_label_exp=!master/builds/474312/screenshots
         [delete] Deleting: /opt/dev/projects/github/liferay-portal/null503166299.properties
      

      clean-up-selenium-driver:
      [exec] chromedriver: no process found
      [exec] Result: 1
      [delete] Deleting: /opt/dev/projects/github/liferay-portal/null503166299.properties

      print-elasticsearch-indices:
      [echo]
      [echo] ##
      [echo] ## All Elasticsearch Indices on Port 9201
      [echo] ##
      [echo]
      [echo] green open liferay-20116-workflow-metrics-instances ZQMOwmNkTD-itpRveTTq-Q 1 0 1 0 5.4kb 5.4kb
      [echo] green open liferay-20116 zj9v0xJMQSexNLglqLSHfA 1 0 193 175 5.1mb 5.1mb
      [echo] green open liferay-20116-workflow-metrics-processes r2bMoZ22SHCqejo3NDVNOg 1 0 1 0 73kb 73kb
      [echo] green open liferay-20116-frequent-pattern-commerce-ml-recommendation AgDeIwDZQzuSRgXOmV0u7A 1 0 0 0 208b 208b
      [echo] green open liferay-20116-search-tuning-rankings b8-bAHYFSv-p6q35I16J9g 1 0 0 0 208b 208b
      [echo] green open liferay-20116-user-commerce-ml-recommendation uWQNjiQUQH2bj2rGCxnSGw 1 0 0 0 208b 208b

  2. test-portal-acceptance-pullrequest-batch(master)/js-unit-jdk8/0
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #15376
           [exec] * What went wrong:
      [exec] Execution failed for task ':apps:layout:layout-admin-web:packageRunTest'.
      [exec] > Process 'command '/opt/dev/projects/github/liferay-portal/build/node/bin/node'' finished with non-zero exit value 1
      [exec]
      [exec] * Try:
      [exec] Run with --info or --debug option to get more log output. Run with --scan to get full insights.
      [exec]
      [exec] * Exception is:
      [exec] org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':apps:layout:layout-admin-web:packageRunTest'.
      [exec] at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.lambda$executeIfValid$1(ExecuteActionsTaskExecuter.java:208)
      [exec] at org.gradle.internal.Try$Failure.ifSuccessfulOrElse(Try.java:263)
      [exec] at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeIfValid(ExecuteActionsTaskExecuter.java:206)
      [exec] at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:187)
      [exec] at org.gradle.api.internal.tasks.execution.CleanupStaleOutputsExecuter.execute(CleanupStaleOutputsExecuter.java:114)
      [exec] at org.gradle.api.internal.tasks.execution.FinalizePropertiesTaskExecuter.execute(FinalizePropertiesTaskExecuter.java:46)
      [exec] at org.gradle.api.internal.tasks.execution.ResolveTaskExecutionModeExecuter.execute(ResolveTaskExecutionModeExecuter.java:62)
      [exec] at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:57)
      [exec] at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:56)
      [exec] at org.gradle.api.internal.tasks.execution.CatchExceptionTaskExecuter.execute(CatchExceptionTaskExecuter.java:36)
      [exec] at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.executeTask(EventFiringTaskExecuter.java:77)
      [exec] at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:55)
      [exec] at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:52)
      [exec] at org.gradle.internal.operations.DefaultBuildOperationExecutor$CallableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:409)

Failures in common with acceptance upstream results at 5d67ea8:
  1. test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8/0
    Job Results:

    3 Tests Passed.
    2 Tests Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #15378
      1. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanOSGiLog
        junit.framework.AssertionFailedError:
        Portal log assert failure, OSGi log found: /opt/dev/projects/github/liferay-portal/bundles/osgi/state/1627397633483.log:
        !SESSION 2021-07-27 14:54:13.450 -----------------------------------------------
        eclipse.buildId=unknown
        java.version=1.8.0_121
        java.vendor=Oracle Corporation
        BootLoader constants: OS=linux, ARCH=x86_64, WS=gtk, NL=en_US

        !ENTRY com.liferay.image.service 4 0 2021-07-27 14:54:13.450
        !MESSAGE FrameworkEvent ERROR
        !STACK 0
        org.osgi.framework.BundleException: Could not resolve module: com.liferay.image.service [356]
        Unresolved requirement: Import-Package: com.liferay.commerce.model; version="[8.0.0,9.0.0)"

        at org.eclipse.osgi.container.Module.start(Module.java:444)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1682)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1662)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1624)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1555)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1)
        at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
        at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:340)
        
        
        at com.liferay.portal.log.assertor....</code></pre></div></li><li><div><a href="https://test-1-2.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master/15378//testReport/com.liferay.portal.log.assertor/PortalLogAssertorTest/testScanXMLLog">com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog</a><pre><code>junit.framework.AssertionFailedError: 
        

        FrameworkEvent ERROR
        org.osgi.framework.BundleException: Could not resolve module: com.liferay.image.service [356]
        Unresolved requirement: Import-Package: com.liferay.commerce.model; version="[8.0.0,9.0.0)"

        at org.eclipse.osgi.container.Module.start(Module.java:444)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1682)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1662)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1624)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1555)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1)
        at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
        at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:340)
        
        at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)
        at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)
        at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)
        at java.nio.file.Files.walkFileTree(Files.java:2670)
        at java.nio.file.Files.walkFileTree(Files.java:2742)
        at com.liferay.portal.log.assertor.PortalL...</code></pre></div></li></ol></div></li></ol></div></li></ol></details></details></html>
        

@liferay-continuous-integration
Copy link
Collaborator

@brunofariasdeo
Copy link
Author

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 10 out of 10 jobs passed

✔️ ci:test:relevant - 25 out of 26 jobs passed in 1 hour 43 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 5d67ea8c2b3b9a21f20ba2b77a1b5ea72ed5c809

Upstream Comparison:

Branch GIT ID: 5d67ea8c2b3b9a21f20ba2b77a1b5ea72ed5c809
Jenkins Build URL: Acceptance Upstream DXP (master) #2154

ci:test:stable - 10 out of 10 jobs PASSED
10 Successful Jobs:
ci:test:relevant - 24 out of 26 jobs PASSED
24 Successful Jobs:
For more details click here.

This pull contains no unique failures.


Failures in common with acceptance upstream results at 5d67ea8:
  1. test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8/0
    Job Results:

    3 Tests Passed.
    2 Tests Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #419513
      1. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanOSGiLog
        junit.framework.AssertionFailedError: 
        Portal log assert failure, OSGi log found: /opt/dev/projects/github/liferay-portal/bundles/osgi/state/1627403277940.log:
        !SESSION 2021-07-27 16:28:27.195 -----------------------------------------------
        eclipse.buildId=unknown
        java.version=1.8.0_121
        java.vendor=Oracle Corporation
        BootLoader constants: OS=linux, ARCH=x86_64, WS=gtk, NL=en_US
        

        !ENTRY com.liferay.image.service 4 0 2021-07-27 16:28:27.196
        !MESSAGE FrameworkEvent ERROR
        !STACK 0
        org.osgi.framework.BundleException: Could not resolve module: com.liferay.image.service [1190]
        Unresolved requirement: Import-Package: com.liferay.commerce.model; version="[8.0.0,9.0.0)"

        at org.eclipse.osgi.container.Module.start(Module.java:444)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1682)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1662)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1624)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1555)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1)
        at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
        at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:340)
        
        
        at com.liferay.portal.log.assertor...</code></pre></div></li><li><div><a href="https://test-1-21.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master/419513//testReport/com.liferay.portal.log.assertor/PortalLogAssertorTest/testScanXMLLog">com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog</a><pre><code>junit.framework.AssertionFailedError: 
        

        FrameworkEvent ERROR
        org.osgi.framework.BundleException: Could not resolve module: com.liferay.image.service [1190]
        Unresolved requirement: Import-Package: com.liferay.commerce.model; version="[8.0.0,9.0.0)"

        at org.eclipse.osgi.container.Module.start(Module.java:444)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1682)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1662)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1624)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1555)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1)
        at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
        at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:340)
        
        at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)
        at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)
        at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)
        at java.nio.file.Files.walkFileTree(Files.java:2670)
        at java.nio.file.Files.walkFileTree(Files.java:2742)
        at com.liferay.portal.log.assertor.Portal...</code></pre></div></li></ol></div></li></ol></div></li></ol></details></details></html>
        

@liferay-continuous-integration
Copy link
Collaborator

@brunofariasdeo
Copy link
Author

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

Skipping previously passed test suites:
ci:test:relevant
ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

All required test suite(s) passed.
Forwarding pull request to brianchandotcom.
Console

@liferay-continuous-integration
Copy link
Collaborator

Pull request has been successfully forwarded to brianchandotcom#104833
Console

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants