Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-136519 Split Numeric into input and append #800

Closed
wants to merge 287 commits into from

Conversation

miltonmc
Copy link

@miltonmc miltonmc commented Aug 11, 2021

Related Tickets

  • LPS-136519 Letters on keyboard are inputting wrong values when using an input mask with a suffix in a decimal number field
  • LPS-136523 When using an number as prefix of the input mask on decimal the prefix is being saved with the input value
  • LPS-136524 The input mask on decimal is not updating on the form builder when the user is editing
  • LPS-136534 The input mask on decimal is not working correctly when the admin is setting a dot or comma as a prefix or suffix

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 3757f7605fc5cbd8d6f8125454a32f0aeee5d61a

Sender Branch:

Branch Name: LPS-136519
Branch GIT ID: 7f30c3f34ac56ca0eb07e521e88e915b0854c39a

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:stable - 9 out of 10 jobs passed

❌ ci:test:relevant - 25 out of 31 jobs passed in 2 hours 39 minutes

Click here for more details.

This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result:

ci:reevaluate:1277401_838

Base Branch:

Branch Name: master
Branch GIT ID: 3757f7605fc5cbd8d6f8125454a32f0aeee5d61a

Upstream Comparison:

Branch GIT ID: dedd00197744b6f5a805793b296d9c8da5c105e0
Jenkins Build URL: Acceptance Upstream DXP (master) #2204

ci:test:stable - 9 out of 10 jobs PASSED
9 Successful Jobs:
ci:test:relevant - 25 out of 31 jobs PASSED
25 Successful Jobs:
For more details click here.

Failures unique to this pull:

  1. test-portal-acceptance-pullrequest-batch(master)/rest-builder-jdk8/0
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #8631
           [echo]  	 */
           [echo]  	@GraphQLField
           [echo]  	public ObjectField objectField(
           [echo] diff --git a/modules/apps/object/object-admin-rest-impl/src/main/java/com/liferay/object/admin/rest/internal/resource/v1_0/BaseObjectFieldResourceImpl.java b/modules/apps/object/object-admin-rest-impl/src/main/java/com/liferay/object/admin/rest/internal/resource/v1_0/BaseObjectFieldResourceImpl.java
           [echo] index db7197974a28..44d11440f348 100644
           [echo] --- a/modules/apps/object/object-admin-rest-impl/src/main/java/com/liferay/object/admin/rest/internal/resource/v1_0/BaseObjectFieldResourceImpl.java
           [echo] +++ b/modules/apps/object/object-admin-rest-impl/src/main/java/com/liferay/object/admin/rest/internal/resource/v1_0/BaseObjectFieldResourceImpl.java
           [echo] @@ -194,7 +194,7 @@ public abstract class BaseObjectFieldResourceImpl
           [echo]  	/**
           [echo]  	 * Invoke this method with the command line:
           [echo]  	 *
           [echo] -	 * curl -X 'PUT' 'http://localhost:8080/o/object-admin/v1.0/object-fields/{objectFieldId}' -d $'{"indexed": ___, "indexedAsKeyword": ___, "indexedLanguageId": ___, "name": ___, "required": ___, "type": ___}' --header 'Content-Type: application/json' -u 'test@liferay.com:test'
           [echo] +	 * curl -X 'PUT' 'http://localhost:8080/o/object-admin/v1.0/object-fields/{objectFieldId}' -d $'{"indexed": ___, "indexedAsKeyword": ___, "indexedLanguageId": ___, "label": ___, "name": ___, "required": ___, "type": ___}' --header 'Content-Type: application/json' -u 'test@liferay.com:test'
           [echo]  	 */
           [echo]  	@Consumes({"application/json", "application/xml"})
           [echo]  	@Override
      [stopwatch] [run.batch.test.action: 9:46.029 sec]
           [echo] .
           [echo] 
           [echo] Detected build REST changes. See above build REST log for more
           [echo] information. Make sure to commit in all build REST results.
            [get] Getting: http://test-1-27/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master/8631//consoleText
            [get] To: /opt/dev/projects/github/liferay-portal/20210811071059492.txt
         [delete] Deleting: /opt/dev/projects/github/liferay-portal/20210811071059492.txt
         [delete] Deleting: /opt/dev/projects/github/liferay-portal/null726811473.properties
  2. test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0
    Job Results:

    8704 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=8,label_exp=!master #474753
      1. com.liferay.document.library.web.exportimport.data.handler.test.DLPortletDataHandlerTest.testDeleteData
        com.liferay.exportimport.kernel.lar.PortletDataException: Structure 46580 cannot be deleted because it is referenced by one or more structure links
        	at com.liferay.exportimport.kernel.lar.BasePortletDataHandler._handleException(BasePortletDataHandler.java:809)
        	at com.liferay.exportimport.kernel.lar.BasePortletDataHandler.deleteData(BasePortletDataHandler.java:100)
        	at com.liferay.document.library.web.internal.lar.DLPortletDataHandler.deleteData(DLPortletDataHandler.java:62)
        	at com.liferay.exportimport.test.util.lar.BasePortletDataHandlerTestCase.testDeleteData(BasePortletDataHandlerTestCase.java:115)
        	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        	at java.lang.reflect.Method.invoke(Method.java:498)
        	at com.liferay.arquillian.extension.junit.bridge.server.TestExecutorRunnable$3.evaluate(TestExecutorRunnable.java:353)
        	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
        	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
        	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
        	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
        	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
        	at com.liferay.portal.kernel.test...

Failures in common with acceptance upstream results at dedd001:
  1. ...

@liferay-continuous-integration
Copy link
Collaborator

@miltonmc
Copy link
Author

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 10 out of 10 jobs passed

❌ ci:test:relevant - 26 out of 31 jobs passed in 1 hour 34 minutes

Click here for more details.

This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result:

ci:reevaluate:1267401_187

Base Branch:

Branch Name: master
Branch GIT ID: 3757f7605fc5cbd8d6f8125454a32f0aeee5d61a

Upstream Comparison:

Branch GIT ID: dedd00197744b6f5a805793b296d9c8da5c105e0
Jenkins Build URL: Acceptance Upstream DXP (master) #2204

ci:test:stable - 10 out of 10 jobs PASSED
10 Successful Jobs:
ci:test:relevant - 26 out of 31 jobs PASSED
26 Successful Jobs:
For more details click here.

Failures unique to this pull:

  1. test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0
    Job Results:

    9006 Tests Passed.
    17 Tests Failed.

    1. AXIS_VARIABLE=20,label_exp=!master #8794
      1. com.liferay.portal.upgrade.test.BaseUpgradePortletIdTest.classMethod
        com.liferay.portal.kernel.exception.SystemException: com.liferay.portal.kernel.dao.orm.ORMException: org.hibernate.exception.SQLGrammarException: could not execute query
        	at com.liferay.portal.kernel.service.persistence.impl.BasePersistenceImpl.processException(BasePersistenceImpl.java:634)
        	at com.liferay.change.tracking.service.persistence.impl.CTPreferencesPersistenceImpl.fetchByC_U(CTPreferencesPersistenceImpl.java:1242)
        	at com.liferay.change.tracking.service.persistence.impl.CTPreferencesPersistenceImpl.fetchByC_U(CTPreferencesPersistenceImpl.java:1164)
        	at com.liferay.change.tracking.service.impl.CTPreferencesLocalServiceImpl.fetchCTPreferences(CTPreferencesLocalServiceImpl.java:56)
        	at sun.reflect.GeneratedMethodAccessor212.invoke(Unknown Source)
        	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        	at java.lang.reflect.Method.invoke(Method.java:498)
        	at com.liferay.portal.spring.aop.AopMethodInvocationImpl.proceed(AopMethodInvocationImpl.java:50)
        	at com.liferay.portal.spring.transaction.TransactionInterceptor.invoke(TransactionInterceptor.java:69)
        	at com.liferay.portal.spring.aop.AopMethodInvocationImpl.proceed(AopMethodInvocationImpl.java:57)
        	at com.liferay.portal.spring.aop.AopInvocationHandler.invoke(AopInvocationHandler.java:49)
        	at com.sun.proxy.$Proxy655.fetchCTPreferences(Unknown Source)
        	at com.liferay.change.tracking.internal.CTCollectionIdSupplierImpl.getCTCollectionId(CTCollectionIdSupplierImpl.java:36)
        	at com.li...
      2. com.liferay.portal.upgrade.test.AutoUpgradeProcessTest.classMethod
        com.liferay.portal.kernel.exception.SystemException: com.liferay.portal.kernel.dao.orm.ORMException: org.hibernate.exception.SQLGrammarException: could not execute query
        	at com.liferay.portal.kernel.service.persistence.impl.BasePersistenceImpl.processException(BasePersistenceImpl.java:634)
        	at com.liferay.change.tracking.service.persistence.impl.CTPreferencesPersistenceImpl.fetchByC_U(CTPreferencesPersistenceImpl.java:1242)
        	at com.liferay.change.tracking.service.persistence.impl.CTPreferencesPersistenceImpl.fetchByC_U(CTPreferencesPersistenceImpl.java:1164)
        	at com.liferay.change.tracking.service.impl.CTPreferencesLocalServiceImpl.fetchCTPreferences(CTPreferencesLocalServiceImpl.java:56)
        	at sun.reflect.GeneratedMethodAccessor212.invoke(Unknown Source)
        	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        	at java.lang.reflect.Method.invoke(Method.java:498)
        	at com.liferay.portal.spring.aop.AopMethodInvocationImpl.proceed(AopMethodInvocationImpl.java:50)
        	at com.liferay.portal.spring.transaction.TransactionInterceptor.invoke(TransactionInterceptor.java:69)
        	at com.liferay.portal.spring.aop.AopMethodInvocationImpl.proceed(AopMethodInvocationImpl.java:57)
        	at com.liferay.portal.spring.aop.AopInvocationHandler.invoke(AopInvocationHandler.java:49)
        	at com.sun.proxy.$Proxy655.fetchCTPreferences(Unknown Source)
        	at com.liferay.change.tracking.internal.CTCollectionIdSupplierImpl.getCTCollectionId(CTCollectionIdSupplierImpl.java:36)
        	at com.li...
      3. com.liferay.portal.uad.exporter.test.RepositoryUADExporterTest.classMethod
        com.liferay.portal.kernel.exception.SystemException: com.liferay.portal.kernel.dao.orm.ORMException: org.hibernate.exception.SQLGrammarException: could not execute query
        	at com.liferay.portal.kernel.service.persistence.impl.BasePersistenceImpl.processException(BasePersistenceImpl.java:634)
        	at com.liferay.change.tracking.service.persistence.impl.CTPreferencesPersistenceImpl.fetchByC_U(CTPreferencesPersistenceImpl.java:1242)
        	at com.liferay.change.tracking.service.persistence.impl.CTPreferencesPersistenceImpl.fetchByC_U(CTPreferencesPersistenceImpl.java:1164)
        	at com.liferay.change.tracking.service.impl.CTPreferencesLocalServiceImpl.fetchCTPreferences(CTPreferencesLocalServiceImpl.java:56)
        	at sun.reflect.GeneratedMethodAccessor212.invoke(Unknown Source)
        	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        	at java.lang.reflect.Method.invoke(Method.java:498)
        	at com.liferay.portal.spring.aop.AopMethodInvocationImpl.proceed(AopMethodInvocationImpl.java:50)
        	at com.liferay.portal.spring.transaction.TransactionInterceptor.invoke(TransactionInterceptor.java:69)
        	at com.liferay.portal.spring.aop.AopMethodInvocationImpl.proceed(AopMethodInvocationImpl.java:57)
        	at com.liferay.portal.spring.aop.AopInvocationHandler.invoke(AopInvocationHandler.java:49)
        	at com.sun.proxy.$Proxy655.fetchCTPreferences(Unknown Source)
        	at com.liferay.change.tracking.internal.CTCollectionIdSupplierImpl.getCTCollectionId(CTCollectionIdSupplierImpl.java:36)
        	at com.li...
      4. ...
    2. AXIS_VARIABLE=9,label_exp=!master #8794
      1. com.liferay.document.library.web.exportimport.data.handler.test.DLPortletDataHandlerTest.testDeleteData
        com.liferay.exportimport.kernel.lar.PortletDataException: Structure 43754 cannot be deleted because it is referenced by one or more structure links
        	at com.liferay.exportimport.kernel.lar.BasePortletDataHandler._handleException(BasePortletDataHandler.java:809)
        	at com.liferay.exportimport.kernel.lar.BasePortletDataHandler.deleteData(BasePortletDataHandler.java:100)
        	at com.liferay.document.library.web.internal.lar.DLPortletDataHandler.deleteData(DLPortletDataHandler.java:62)
        	at com.liferay.exportimport.test.util.lar.BasePortletDataHandlerTestCase.testDeleteData(BasePortletDataHandlerTestCase.java:115)
        	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        	at java.lang.reflect.Method.invoke(Method.java:498)
        	at com.liferay.arquillian.extension.junit.bridge.server.TestExecutorRunnable$3.evaluate(TestExecutorRunnable.java:353)
        	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
        	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
        	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
        	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
        	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
        	at com.liferay.portal.kernel.test...

Failures in common with acceptance upstream results at dedd001:
  1. ...

@liferay-continuous-integration
Copy link
Collaborator

@miltonmc
Copy link
Author

ci:test:relevant

@miltonmc
Copy link
Author

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 11 out of 11 jobs passed

✔️ ci:test:relevant - 25 out of 28 jobs passed in 1 hour 55 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 29659ca5c93fa3a85e562f417451fc62cd9ab55e

Upstream Comparison:

Branch GIT ID: 2855edfaccfdb9ffeb43d665ff2b06df64e7b6df
Jenkins Build URL: Acceptance Upstream DXP (master) #2229

ci:test:stable - 11 out of 11 jobs PASSED
11 Successful Jobs:
ci:test:relevant - 24 out of 28 jobs PASSED
24 Successful Jobs:
For more details click here.

This pull contains no unique failures.


Failures in common with acceptance upstream results at 2855edf:
  1. test-portal-acceptance-pullrequest-batch(master)/central-requirements-jdk8/0
    Job Results:

    7 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #29631
      1. com.liferay.portal.modules.ModulesStructureTest.testScanBuildScripts
        junit.framework.AssertionFailedError: Missing modules/apps/headless/headless-portal-instances/headless-portal-instances-client/build.gradle
        	at com.liferay.portal.modules.ModulesStructureTest$2.preVisitDirectory(ModulesStructureTest.java:293)
        	at com.liferay.portal.modules.ModulesStructureTest$2.preVisitDirectory(ModulesStructureTest.java:171)
        	at java.nio.file.Files.walkFileTree(Files.java:2677)
        	at java.nio.file.Files.walkFileTree(Files.java:2742)
        	at com.liferay.portal.modules.ModulesStructureTest.testScanBuildScripts(ModulesStructureTest.java:169)
        

@liferay-continuous-integration
Copy link
Collaborator

@miltonmc miltonmc force-pushed the LPS-136519 branch 2 times, most recently from 5bfc48b to 69f3cf0 Compare August 20, 2021 13:15
@miltonmc
Copy link
Author

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

Skipping previously passed test suites:
ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: cf083908be3df7babd46a2bcdd9b99efb06586d0

Sender Branch:

Branch Name: LPS-136519
Branch GIT ID: 69f3cf044e0866d0a9e42ae2b9030786210bf4c2

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

All required test suite(s) passed.
Forwarding pull request to brianchandotcom.
Console

@liferay-continuous-integration
Copy link
Collaborator

Pull request has been successfully forwarded to brianchandotcom#105891
Console

@liferay-continuous-integration
Copy link
Collaborator

@miltonmc miltonmc deleted the LPS-136519 branch August 20, 2021 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment