Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-131410 Reduce TreeviewCard padding #1024

Closed
wants to merge 1 commit into from
Closed

LPS-131410 Reduce TreeviewCard padding #1024

wants to merge 1 commit into from

Conversation

p2kmgcl
Copy link
Collaborator

@p2kmgcl p2kmgcl commented May 6, 2021 •
edited

This PR updates the TreeviewCard padding (reducing it to 0.5rem = 8px).

Steps to check:

  1. Go to web content administration
  2. Create a web content
  3. Open sidebar panel
  4. Go to Categorization > Topic > Select
  5. Add any topic

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 76da930fa5d546b4b782e85737378267eb31c480

Sender Branch:

Branch Name: padding-is-bad-131410
Branch GIT ID: b7cd07cbf633b9b8f984bc10ea1bc7c7066d52ad

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

@julien
Copy link

julien commented May 6, 2021

Seems like a reasonable and safe change

kresimir-coko
kresimir-coko approved these changes May 6, 2021
View reviewed changes
Copy link
Collaborator

@kresimir-coko kresimir-coko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LNHTM!

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 22 out of 23 jobs passed in 2 hours 11 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 76da930fa5d546b4b782e85737378267eb31c480

Upstream Comparison:

Branch GIT ID: ddeada2e14c1bbf5631ea173b12455bca5d5561d
Jenkins Build URL: Acceptance Upstream DXP (master) #1836

ci:test:stable - 9 out of 9 jobs PASSED
9 Successful Jobs:
ci:test:relevant - 21 out of 23 jobs PASSED
21 Successful Jobs:
For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at ddeada2:
  1. test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8/0
    Job Results:

    2 Tests Passed.
    3 Tests Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #335752
      1. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanOSGiLog
        junit.framework.AssertionFailedError: 
Portal log assert failure, OSGi log found: /opt/dev/projects/github/liferay-portal/bundles/osgi/state/1620289919274.log:
!SESSION 2021-05-06 08:32:21.973 -----------------------------------------------
eclipse.buildId=unknown
java.version=1.8.0_121
java.vendor=Oracle Corporation
BootLoader constants: OS=linux, ARCH=x86_64, WS=gtk, NL=en_US

        !ENTRY com.liferay.portal.vulcan.impl 4 0 2021-05-06 08:32:21.973
        
!MESSAGE FrameworkEvent ERROR
        
!STACK 0
        
org.osgi.framework.BundleException: Could not resolve module: com.liferay.portal.vulcan.impl [1170]
        
Unresolved requirement: Import-Package: com.liferay.object.model; version="[1.0.0,2.0.0)"
        

        at org.eclipse.osgi.container.Module.start(Module.java:444)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1682)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1662)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1624)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1555)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1)
at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:340)

        

        !ENTRY com.liferay.click.to....
      2. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError:
        
FrameworkEvent ERROR
        
org.osgi.framework.BundleException: Could not resolve module: com.liferay.portal.vulcan.impl [1170]
        
Unresolved requirement: Import-Package: com.liferay.object.model; version="[1.0.0,2.0.0)"
        

        at org.eclipse.osgi.container.Module.start(Module.java:444)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1682)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1662)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1624)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1555)
at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1)
at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:340)

at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)
at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)
at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)
at java.nio.file.Files.walkFileTree(Files.java:2670)
at java.nio.file.Files.walkFileTree(Files.java:2742)
at com.liferay.portal.log.assertor.Por...</code></pre></div></li><li><div><a href="https://test-1-15.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master/335752//testReport/com.liferay.poshi.runner/PoshiRunner/test_LocalFile_PortalSmoke_Smoke_">LocalFile.PortalSmoke#Smoke</a> - <a href="https://testray.liferay.com/reports/production/logs/2021-05/test-1-17/test-portal-acceptance-pullrequest(master)/7664/lpkg-base-jdk8/0/0/LocalFile.PortalSmoke_Smoke/index.html.gz">Poshi Report</a> - <a href="https://testray.liferay.com/reports/production/logs/2021-05/test-1-17/test-portal-acceptance-pullrequest(master)/7664/lpkg-base-jdk8/0/0/LocalFile.PortalSmoke_Smoke/summary.html.gz">Poshi Summary</a> - <a href="https://testray.liferay.com/reports/production/logs/2021-05/test-1-17/test-portal-acceptance-pullrequest(master)/7664/lpkg-base-jdk8/0/0/jenkins-console.txt.gz">Console Output</a></div></li></ol></div></li></ol></div></li></ol></details></details></html><h5>Test bundle downloads:</h5><ul><li><a href="https://files.liferay.com/private/bundles/test-1-17/jobs/test-portal-acceptance-pullrequest(master)/builds/7664/liferay-portal-bundle-tomcat.tar.gz">liferay-portal-bundle-tomcat.tar.gz</a> (mirrors: <a href="http://mirrors.dlc.liferay.com/files.liferay.com/private/bundles/test-1-17/jobs/test-portal-acceptance-pullrequest(master)/builds/7664/liferay-portal-bundle-tomcat.tar.gz">dlc</a>, <a href="http://mirrors.lax.liferay.com/files.liferay.com/private/bundles/test-1-17/jobs/test-portal-acceptance-pullrequest(master)/builds/7664/liferay-portal-bundle-tomcat.tar.gz">lax</a>)</li></ul>

@liferay-continuous-integration
Copy link
Collaborator

@wincent
Copy link

wincent commented May 6, 2021

Well, let's just ship this and see if anybody complains about us breaking some treeview in another place. 😬

@wincent
Copy link

wincent commented May 6, 2021

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

Skipping previously passed test suites:
ci:test:relevant
ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

All required test suite(s) passed.
Forwarding pull request to brianchandotcom.
Console

@liferay-continuous-integration liferay-continuous-integration mentioned this pull request May 6, 2021
Closed
@liferay-continuous-integration
Copy link
Collaborator

Pull request has been successfully forwarded to brianchandotcom#101456
Console

@p2kmgcl p2kmgcl deleted the padding-is-bad-131410 branch August 24, 2021 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kresimir-coko kresimir-coko kresimir-coko approved these changes

Assignees
No one assigned
Labels
ci:test:relevant - success ci:test:sf - success ci:test:stable - success
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@p2kmgcl @liferay-continuous-integration @julien @wincent @kresimir-coko