LPS-133018 frontend-js-tabs-support-web Tab content and trigger no lo… #1247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is automatically triggering the following test suites:
|
liferay-continuous-integration
added
ci:test:sf - pending
ci:test:sf - success
and removed
ci:test:sf - pending
labels
✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPS-133018 1 Successful Jobs:For more details click here. |
|
Jenkins Build:test-portal-source-format#5073 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-frontend#1247 Testray Routine:EE Pull Request Testray Importer:publish-testray-report#1925 |
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#9462 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:liferay-frontend#1247 Testray Routine:EE Pull Request Testray Build:[master] ci:test:relevant - pat270 > liferay-frontend - PR#1247 - 2021-07-13[13:09:02] Testray Importer:publish-testray-report#354 |
markocikos
added
the
s-dxp
markocikos
reviewed
Jul 14, 2021
Comment on lines
106
to
114
| const onHidden = (event) => { | ||
| if (event.panel === activePanel) { | ||
| this.show({panel, trigger}); | ||
| } | ||
| }); | ||
|
|
||
| Liferay.detach(this.EVENT_HIDDEN, onHidden); | ||
| }; | ||
|
|
||
| Liferay.on(this.EVENT_HIDDEN, onHidden); |
There was a problem hiding this comment.
We can simplify this by using Liferay.once
…nger function due to hide listener being instantiated multiple times on click
|
ci:test:sf |
|
ci:test:relevant |
✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPS-133018 1 Successful Jobs:For more details click here. |
|
ci:forward |
liferay-continuous-integration
added
ci:test:relevant - failure
ci:test:stable - success
and removed
ci:test:stable - pending
labels
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#2894 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:liferay-frontend#1247 Testray Routine:EE Pull Request Testray Build:[master] ci:test:relevant - pat270 > liferay-frontend - PR#1247 - 2021-07-14[07:02:38] Testray Importer:publish-testray-report#8052 |
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#237 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:liferay-frontend#1247 Testray Routine:EE Pull Request Testray Build:[master] ci:test:relevant - pat270 > liferay-frontend - PR#1247 - 2021-07-14[06:54:36] Testray Importer:publish-testray-report#5 |
|
This CI failure looks like the same as |
|
ci:forward |
|
CI is automatically triggering the following test suites:
The pull request will automatically be forwarded to the user
|
|
Skipping previously passed test suites: |
|
All required test suite(s) passed. |
|
Pull request has been successfully forwarded to brianchandotcom#104368 |
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#6240 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:liferay-frontend#1247 Testray Routine:EE Pull Request Testray Build:[master] ci:test:relevant - pat270 > liferay-frontend - PR#1247 - 2021-07-14[11:48:28] Testray Importer:publish-testray-report#1705 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nger function due to hide listener being instantiated multiple times on click
@liferay-frontend can we get this in for next release?
https://issues.liferay.com/browse/LPS-133018