Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-117288 If I have more than one HTML field on a web content I'm not able to edit on click #145

Closed
wants to merge 1 commit into from

Conversation

markocikos
Copy link
Collaborator

This is a bugfix, see details and how to reproduce in https://issues.liferay.com/browse/LPS-117288

The root cause are these styles from base CKEditor:

.cke_editable:after {
    border: 1px solid #e7e7ed;
    bottom: 0;
    content: '';
    left: 0;
    position: fixed;
    right: 0;
    top: 0
}

I could not find these in CKEditor repo, I found them in runtime in a generated merged CSS file. Recently we updated base CKEditor, I'm guessing these were added or changed then.

The styles are defining a full page overlay in :after. In this PR, we are overriding styles to hide the overlay. I don't know what problem the overlay is solving, but in our context it seems to be a needless appendage.

This PR also fixes the issue of not being able to mouse-drag select parts of text, that I mentioned in #107 (comment)

I am not completely sure I added these styles in the right places:

  • I added ckeditor styles in the theme. This is because ckeditor is rendered in an iframe
  • I added alloyeditor styles in frontend-css-web, which I hope is a preferred place of adding styles.

@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@markocikos
Copy link
Collaborator Author

Pinging our css-meister @marcoscv-work for review. I don't think review request sends a notification.

@carloslancha
Copy link

Hey @markocikos this should be fixed in moono-lexicon skin in liferay-ckeditor repo if possible. We moved all the styling there.

@markocikos
Copy link
Collaborator Author

@carloslancha Oh no, I was afraid of that. Time to relearn all the fun ways repos build and interact.. 😄

@carloslancha
Copy link

hahahaha, it should be easy following all steps and advices on the README, but if you need help just let me know!

@markocikos
Copy link
Collaborator Author

Followup in liferay/liferay-ckeditor#98

@markocikos markocikos closed this Jul 22, 2020
@markocikos markocikos deleted the LPS-117288 branch November 16, 2020 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants