LPS-117288 If I have more than one HTML field on a web content I'm not able to edit on click #145
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bugfix, see details and how to reproduce in https://issues.liferay.com/browse/LPS-117288
The root cause are these styles from base CKEditor:
I could not find these in CKEditor repo, I found them in runtime in a generated merged CSS file. Recently we updated base CKEditor, I'm guessing these were added or changed then.
The styles are defining a full page overlay in
:after
. In this PR, we are overriding styles to hide the overlay. I don't know what problem the overlay is solving, but in our context it seems to be a needless appendage.This PR also fixes the issue of not being able to mouse-drag select parts of text, that I mentioned in #107 (comment)
I am not completely sure I added these styles in the right places:
ckeditor
styles in the theme. This is becauseckeditor
is rendered in aniframe
alloyeditor
styles infrontend-css-web
, which I hope is a preferred place of adding styles.