LPS-117468 Fix unexpected background and border in Page Editor editables #148

mateomustapic · 2020-07-22T09:05:27Z

This is a bug fix for https://issues.liferay.com/browse/LPS-117468
Reseting border and background styles for cke_editable css class in page editor.

Steps to reproduce

Edit Hello World page (or create a content page with a heading fragment)
Double click on a text editable to start editing.

liferay-continuous-integration · 2020-07-22T09:05:30Z

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

mateomustapic · 2020-07-22T09:06:10Z

ci:test:sf

mateomustapic · 2020-07-22T09:06:24Z

ci:test:relevant

liferay-continuous-integration · 2020-07-22T09:12:58Z

❌ ci:test:sf - 0 out of 1 jobs passed in 4 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 21b2adc009b50747fa2512a77308e78001e6b13f

Sender Branch:

Branch Name: LPS-117468
Branch GIT ID: ec517fe623ca440b7b0922fc1b42e863c39ca920

0 out of 1jobs PASSED

1 Failed Jobs:

~~test-portal-source-format~~

For more details click here.

     [java] java.lang.Exception: Found 1 formatting issues:
     [java] 1: ./modules/apps/layout/layout-content-page-editor-web/src/main/resources/META-INF/resources/page_editor/app/components/fragment-content/FragmentContent.scss expected:<...
     [java] 	.cke_editable \{
     [java] 		[background-color: unset;
     [java] 		padding: 0];
     [java] 	\}
     [java] 
     [java] 	.cke_editable...> but was:<...
     [java] 	.cke_editable \{
     [java] 		[padding: 0;
     [java] 		background-color: unset];
     [java] 	\}
     [java] 
     [java] 	.cke_editable...>
     [java] 
     [java] 	at com.liferay.source.formatter.SourceFormatter.format(SourceFormatter.java:448)
     [java] 	at com.liferay.source.formatter.SourceFormatter.main(SourceFormatter.java:269)
[stopwatch] [run.batch.test.action: 1:48.667 sec]
     [echo] The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/portal-impl/build.xml:611: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/portal-impl/build.xml:724: Java returned: 1
      [get] Getting: http://test-1-17/job/test-portal-source-format/3759//consoleText
      [get] To: /opt/dev/projects/github/liferay-portal/20200722021244486.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/20200722021244486.txt
  [typedef] Could not load definitions from resource org/apache/maven/artifact/ant/antlib.xml. It could not be found.
  [taskdef] Could not load definitions from resource org/jacoco/ant/antlib.xml. It could not be found.
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/null112687952.properties
merge-test-results:

[mkdir] Created dir: /opt/dev/projects/github/liferay-portal/test-results

[junitreport] Processing /opt/dev/projects/github/liferay-portal/test-results/TESTS-TestSuites.xml to /tmp/null228698846

[junitreport] Loading stylesheet jar:file:/opt/java/ant/lib/ant-junit.jar!/org/apache/tools/ant/taskdefs/optional/junit/xsl/junit-frames.xsl

[junitreport] Transform time: 287ms

[junitreport] Deleting: /tmp/null228698846

[echo] A report with all the test results can be found at test-results/html/index.html.

[mkdir] Created dir: /opt/dev/projects/github/liferay-jenkins-ee/test-results

[copy] Copying 1 file to /opt/dev/projects/github/liferay-jenkins-ee/test-results

[echo] run.batch.test.tear.down.start.timestamp: 07-22-2020 02:12:49:811 PDT

liferay-continuous-integration · 2020-07-22T09:15:17Z

Jenkins Build:test-portal-source-format#3759
Jenkins Report:jenkins-report.html
Jenkins Suite: sf
Pull Request:liferay-frontend#148
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:sf
Spira Release Build:master - mateomustapic > liferay-frontend - PR#148 - 2020-07-22[02:08:41]
Spira Jenkins Build:publish-spira-report#1173

mateomustapic · 2020-07-22T09:19:00Z

ci:test:sf

liferay-continuous-integration · 2020-07-22T09:23:22Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 21b2adc009b50747fa2512a77308e78001e6b13f

Sender Branch:

Branch Name: LPS-117468
Branch GIT ID: c76247235ceac02abf70f7c32fc988a36a655dc3

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2020-07-22T09:26:13Z

Jenkins Build:test-portal-source-format#4390
Jenkins Report:jenkins-report.html
Jenkins Suite: sf
Pull Request:liferay-frontend#148
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:sf
Spira Release Build:master - mateomustapic > liferay-frontend - PR#148 - 2020-07-22[02:20:42]
Spira Jenkins Build:publish-spira-report#1152

carloslancha · 2020-07-22T09:30:40Z

Isn't this the same as #145 ?

Please, coordinate with @markocikos to see if both issues are related so you can fix'em properly in liferay-ckeditor

mateomustapic · 2020-07-22T09:34:07Z

Isn't this the same as #145 ?

Please, coordinate with @markocikos to see if both issues are related so you can fix'em properly in liferay-ckeditor

This issue shouldn't be related to Marko's. This one is Page Editor specific, that's why these changes are done in layout-content-page-editor-web stlyes.

liferay-continuous-integration · 2020-07-22T10:05:43Z

❌ ci:test:relevant - 0 out of 1 jobs passed in 59 seconds

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: c7f9b29e5cfb86cb714157f3143eb324e4d1d1d0

ci:test:relevant - 0 out of 1 jobs PASSED

1 Failed Jobs:

~~test-portal-acceptance-pullrequest(master)~~

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest(master)
Job Results:
0 Jobs Passed.
1 Job Failed.
The sender branch SHA could not be found on mateomustapic/LPS-117468. The sender branch may have been force pushed or deleted after the pull request test was initiated.
```
fatal: Not a valid branch point: 'ec517fe623ca440b7b0922fc1b42e863c39ca920'.
```

For upstream results, click here.

mateomustapic · 2020-07-22T10:08:21Z

ci:test:relevant

carloslancha · 2020-07-22T10:16:22Z

Victor Galán on the ticket:

Just to add here, apart from the different padding and colors from the original one, it is styling the after element making it cover the whole screen. This makes impossible to close the editor clicking on another fragment of the page that is above the fragment with the alloy editor opened

That's exactly what @markocikos describes in #145 isn't it?

carloslancha · 2020-07-22T10:19:52Z

@mateomustapic I don't know if this can be fixed in liferay-ckeditor but because this is happening since we introduced the moono-lexicon skin I think it's worth to check it and try to find a way to solve it there.

mateomustapic · 2020-07-22T10:24:32Z

@mateomustapic I don't know if this can be fixed in liferay-ckeditor but because this is happening since we introduced the moono-lexicon skin I think it's worth to check it and try to find a way to solve it there.

I will take a look if I can solve it from liferay-ckeditor

markocikos · 2020-07-22T12:19:11Z

@mateomustapic I am already working on this, there is no need for you to continue. I'll open PR shortly, please review it when I do.

mateomustapic · 2020-07-22T12:21:51Z

@mateomustapic I am already working on this, there is no need for you to continue. I'll open PR shortly, please review it when I do.

sure, no problem :)

mateomustapic · 2020-07-22T14:43:19Z

Closing this, sent fix in liferay-ckeditor=> liferay/liferay-ckeditor#99

liferay-continuous-integration · 2020-07-22T16:11:11Z

✔️ ci:test:stable - 21 out of 21 jobs passed

✔️ ci:test:relevant - 77 out of 78 jobs passed in 5 hours 52 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: c7f9b29e5cfb86cb714157f3143eb324e4d1d1d0

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 9df5a717f14278f29e7460d7055a941d93e0b735

ci:test:stable - 21 out of 21 jobs PASSED

21 Successful Jobs:

ci:test:relevant - 76 out of 78 jobs PASSED

2 Failed Jobs:

76 Successful Jobs:

For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at 21b2adc:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/3
Job Results:
27 Tests Passed.
1 Test Failed.
1. AXIS_VARIABLE=1,label_exp=!master #382588
  1. LocalFile.ContentPagesWithEditMode#OnlyCanEditContentWhenSelectContentEdition - Poshi Report - Poshi Summary - Console Output

liferay-continuous-integration · 2020-07-22T16:16:57Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#7037
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:liferay-frontend#148
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:relevant
Spira Release Build:master - mateomustapic > liferay-frontend - PR#148 - 2020-07-22[03:18:16]
Spira Jenkins Build:publish-spira-report#1227

carloslancha · 2020-07-22T16:18:13Z

Hey @mateomustapic please remember to call to ci:stop if you close a pr while it's in queue or running tests :)

**Release notes:** [Full changelog](liferay/liferay-ckeditor@v4.14.1-liferay.15...v4.14.1-liferay.16) - fix: LPS-125441 CKEditor font size selector flickers on mouse over ([\#148](liferay/liferay-ckeditor#148)) Additionally this fixes [LPS-125441](https://issues.liferay.com/browse/LPS-125441)

mateomustapic requested a review from carloslancha July 22, 2020 09:05

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - failure and removed ci:test:sf - pending labels Jul 22, 2020

LPS-117468 Fix unexpected background and border in Page Editor editables

c762472

mateomustapic force-pushed the LPS-117468 branch from ec517fe to c762472 Compare July 22, 2020 09:18

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - success and removed ci:test:sf - failure ci:test:sf - pending labels Jul 22, 2020

carloslancha added the on hold label Jul 22, 2020

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending ci:test:relevant - failure and removed ci:test:relevant - pending labels Jul 22, 2020

liferay-continuous-integration added ci:test:relevant - pending and removed ci:test:relevant - failure labels Jul 22, 2020

liferay-continuous-integration added ci:test:stable - pending and removed ci:test:stable - pending labels Jul 22, 2020

carloslancha mentioned this pull request Jul 22, 2020

fix: remove overlay that is preventing unrelated UI interactions on the page liferay/liferay-ckeditor#98

Merged

mateomustapic closed this Jul 22, 2020

liferay-continuous-integration added ci:test:relevant - success ci:test:stable - success and removed ci:test:relevant - pending ci:test:stable - pending labels Jul 22, 2020

LPS-117468 Fix unexpected background and border in Page Editor editables #148

LPS-117468 Fix unexpected background and border in Page Editor editables #148

Conversation

mateomustapic commented Jul 22, 2020

liferay-continuous-integration commented Jul 22, 2020

mateomustapic commented Jul 22, 2020

mateomustapic commented Jul 22, 2020

liferay-continuous-integration commented Jul 22, 2020

❌ ci:test:sf - 0 out of 1 jobs passed in 4 minutes

Base Branch:

Sender Branch:

1 Failed Jobs:

For more details click here.

liferay-continuous-integration commented Jul 22, 2020

mateomustapic commented Jul 22, 2020

liferay-continuous-integration commented Jul 22, 2020

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Jul 22, 2020

carloslancha commented Jul 22, 2020 • edited

mateomustapic commented Jul 22, 2020 • edited

liferay-continuous-integration commented Jul 22, 2020

❌ ci:test:relevant - 0 out of 1 jobs passed in 59 seconds

Base Branch:

1 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest(master)

Job Results:

For upstream results, click here.

mateomustapic commented Jul 22, 2020

carloslancha commented Jul 22, 2020

carloslancha commented Jul 22, 2020

mateomustapic commented Jul 22, 2020

markocikos commented Jul 22, 2020

mateomustapic commented Jul 22, 2020

mateomustapic commented Jul 22, 2020

liferay-continuous-integration commented Jul 22, 2020

✔️ ci:test:stable - 21 out of 21 jobs passed

✔️ ci:test:relevant - 77 out of 78 jobs passed in 5 hours 52 minutes

Base Branch:

Copied in Private Modules Branch:

2 Failed Jobs:

For more details click here.

This pull contains no unique failures.

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/3

Job Results:

liferay-continuous-integration commented Jul 22, 2020

carloslancha commented Jul 22, 2020

carloslancha commented Jul 22, 2020 •

edited

mateomustapic commented Jul 22, 2020 •

edited