Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-148020 Increase CI coverage for themes module #1960

Closed
wants to merge 2 commits into from

Conversation

Esther-OC
Copy link

@Esther-OC Esther-OC commented Feb 28, 2022

The goal of this PR is edit the test.properties file of the frontend-theme module to include the testray.main.component.name ~ "Navigation" in order that the regression tests will also include Navigation tests when running the ci:test:relevant and then avoid regression bugs.

JIRA issue: LPS-148020

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:sf - 0 out of 1 jobs passed in 4 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: fbbb1c10749c2eb534a4df3f7f9ec2aa6132c152

Sender Branch:

Branch Name: LPS-148020
Branch GIT ID: 0278f8b41b8e11bb24abe0bf7d28c18aff3e0047

0 out of 1jobs PASSED
For more details click here.
     [java] java.lang.Exception: Found 1 formatting issues:
     [java] 1: ./modules/apps/frontend-theme/test.properties expected:<...component.names == "[Navigation") OR \
     [java]             (testray.component.names == "Theme") OR \
     [java]             (testray.component.names == "User Interface]")\
     [java]         )
     [java] 
     [java] ##
     [java] ##...> but was:<...component.names == "[Theme") OR \
     [java]             (testray.component.names == "User Interface") OR \
     [java]             (testray.component.names == "Navigation]")\
     [java]         )
     [java] 
     [java] ##
     [java] ##...>
     [java] 
     [java]   at com.liferay.source.formatter.SourceFormatter.format(SourceFormatter.java:435)
     [java]   at com.liferay.source.formatter.SourceFormatter.main(SourceFormatter.java:281)
[stopwatch] [run.batch.test.action: 1:30.376 sec]
     [echo] The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/portal-impl/build.xml:450: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/portal-impl/build.xml:593: Java returned: 1
      [get] Getting: http://test-1-3/job/test-portal-source-format/6336//consoleText
      [get] To: /opt/dev/projects/github/liferay-portal/20220228073437259.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/20220228073437259.txt
  [typedef] Could not load definitions from resource org/apache/maven/artifact/ant/antlib.xml. It could not be found.
  [taskdef] Could not load definitions from resource org/jacoco/ant/antlib.xml. It could not be found.
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/null224131222.properties

merge-test-results:
[mkdir] Created dir: /opt/dev/projects/github/liferay-portal/test-results
[beanshell] Truncating errors in /opt/dev/projects/github/liferay-portal/portal-impl/test-results/TEST-JenkinsLogAssertTest.xml
[junitreport] Processing /opt/dev/projects/github/liferay-portal/test-results/TESTS-TestSuites.xml to /tmp/null356617054
[junitreport] Loading stylesheet jar:file:/opt/java/ant/lib/ant-junit.jar!/org/apache/tools/ant/taskdefs/optional/junit/xsl/junit-frames.xsl
[junitreport] Transform time: 200ms
[junitreport] Deleting: /tmp/null356617054
[echo] A report with all the test results can be found at test-results/html/index.html.
[mkdir] Created dir: /opt/dev/projects/github/liferay-jenkins-ee/test-results

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 23 out of 26 jobs passed

✔️ ci:test:relevant - 24 out of 27 jobs passed in 1 hour 30 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: fbbb1c10749c2eb534a4df3f7f9ec2aa6132c152

Upstream Comparison:

Branch GIT ID: 04647af13615180551f40fb84cd1bb65736be8f7
Jenkins Build URL: Acceptance Upstream DXP (master) #2969

ci:test:stable - 23 out of 26 jobs PASSED
23 Successful Jobs:
ci:test:relevant - 23 out of 27 jobs PASSED
23 Successful Jobs:
For more details click here.

This pull contains no unique failures.


Failures in common with acceptance upstream results at 04647af:
  1. test-portal-acceptance-pullrequest-batch(master)/semantic-versioning-jdk8/0
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0 #510080

      Please fix semantic versioning on Esther-OC/LPS-148020

           [exec]       -   return     boolean
           [exec]     -   method     finalize()
           [exec]       -   access     protected
           [exec]       -   return     void
           [exec]     -   method     getAttribute(java.lang.String)
           [exec]       -   return     java.lang.Object
           [exec]     -   method     getAttributeNames()
           [exec]       -   return     java.util.Enumeration
           [exec]     -   method     getLocales()
           [exec]       -   return     java.util.Enumeration
           [exec]     -   method     getRequest()
           [exec]       -   return     javax.servlet.ServletRequest
           [exec]     -   method     getRequestDispatcher(java.lang.String)
           [exec]       -   return     javax.servlet.RequestDispatcher
           [exec]     -   method     hashCode()
           [exec]       -   return     int
           [exec]     -   method     removeAttribute(java.lang.String)
           [exec]       -   return     void
           [exec]     -   method     setAttribute(java.lang.String,java.lang.Object)
           [exec]       -   return     void
           [exec]     -   method     setRequest(javax.servlet.ServletRequest)
           [exec]       -   return     void
           [exec]     -   method     toString()
           [exec]       -   return     java.lang.String
           [exec]   -   class      com.liferay.portal.servlet.ThreadLocalFacadeServletRequestWrapperUtil
           [exec]     -   method     <init>()
           [exec]       -   return     void
           [exec]     -   method     clone()
           [exec]       -   access     protected
           [exec]       -   return     java.lang.Object
           [exec]     -   method     equals(java.lang.Object)
           [exec]       -   return     boolean
           [exec]     -   method     finalize()
           [exec]       -   access     protected
           [exec]       -   return     void
           [exec]     -   method     hashCode()
           [exec]       -   return     int
           [exec]     -   method     inject(javax.servlet.ServletRequest)
           [exec]       -   access     static
           [exec]       -   return     com.liferay.portal.kernel.util.ObjectValuePair
           [exec]     -   method     setStopperClassNames(java.util.Set)
           [exec]       -   return     void
           [exec]     -   method     toString()
           [exec]       -   return     java.lang.String
           [exec] [Baseline Report] Mode: diff (persisted)
           [exec] Semantic versioning is incorrect while checking /opt/dev/projects/github/liferay-portal/portal-impl/portal-impl.jar against /opt/dev/projects/github/liferay-portal/.gradle/caches/modules-2/files-2.1/com.liferay.portal/com.liferay.portal.impl/26.0.0/2e7facd759d1784727e964b573445e1793b5d8a5/com.liferay.portal.impl-26.0.0.jar

  2. test-portal-acceptance-pullrequest-batch(master)/central-requirements-jdk8/0
    Job Results:

    7 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0 #19092
      1. com.liferay.portal.modules.ModulesStructureTest.testScanGradleFiles
        junit.framework.AssertionFailedError: Artifact dependency {compile group: "com.liferay", name: "com.liferay.petra.http.invoker", version: "1.0.0"} in modules/apps/site-initializer/site-initializer-testray/extra/java-function/build.gradle not permitted on master branch. Use a project dependency instead.
          at com.liferay.portal.modules.ModulesStructureTest._testGradleFile(ModulesStructureTest.java:1454)
          at com.liferay.portal.modules.ModulesStructureTest.access$800(ModulesStructureTest.java:68)
          at com.liferay.portal.modules.ModulesStructureTest$4.visitFile(ModulesStructureTest.java:402)
          at com.liferay.portal.modules.ModulesStructureTest$4.visitFile(ModulesStructureTest.java:376)
          at java.nio.file.Files.walkFileTree(Files.java:2670)
          at java.nio.file.Files.walkFileTree(Files.java:2742)
          at com.liferay.portal.modules.ModulesStructureTest.testScanGradleFiles(ModulesStructureTest.java:374)
        
  3. test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8/0
    Job Results:

    2 Tests Passed.
    3 Tests Failed.

    1. AXIS_VARIABLE=0 #449354
      1. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanOSGiLog
        junit.framework.AssertionFailedError: 
        Portal log assert failure, OSGi log found: /opt/dev/projects/github/liferay-portal/bundles/osgi/state/1646066576988.log:
        !SESSION 2022-02-28 16:43:17.131 -----------------------------------------------
        eclipse.buildId=unknown
        java.version=1.8.0_121
        java.vendor=Oracle Corporation
        BootLoader constants: OS=linux, ARCH=x86_64, WS=gtk, NL=en_US
        

        !ENTRY com.liferay.exportimport.service 4 0 2022-02-28 16:43:17.131
        !MESSAGE FrameworkEvent ERROR
        !STACK 0
        org.osgi.framework.BundleException: Could not resolve module: com.liferay.exportimport.service [157]
        Unresolved requirement: Import-Package: com.thoughtworks.xstream; version="1.4.0"

        at org.eclipse.osgi.container.Module.start(Module.java:444)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1682)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1662)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1624)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1555)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1)
        at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
        at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:340)

        !ENTRY com.liferay.document.libra...

      2. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError:
        FrameworkEvent ERROR
        org.osgi.framework.BundleException: Could not resolve module: com.liferay.exportimport.service [157]
        Unresolved requirement: Import-Package: com.thoughtworks.xstream; version="1.4.0"

        at org.eclipse.osgi.container.Module.start(Module.java:444)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1682)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1662)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1624)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1555)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1)
        at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
        at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:340)

        at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)
        at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)
        at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)
        at java.nio.file.Files.walkFileTree(Files.java:2670)
        at java.nio.file.Files.walkFileTree(Files.java:2742)
        at com.liferay.portal.log.assertor.PortalLogA...

Test bundle downloads:

@liferay-continuous-integration
Copy link
Collaborator

@Esther-OC
Copy link
Author

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 2f02eaebf0905ebb867ccc8a79caec0ed022b3d6

Sender Branch:

Branch Name: LPS-148020
Branch GIT ID: 52820dea932344a96e2bc588ff90b2815dc10f95

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 24 out of 26 jobs passed

✔️ ci:test:relevant - 25 out of 27 jobs passed in 1 hour 40 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 2f02eaebf0905ebb867ccc8a79caec0ed022b3d6

Upstream Comparison:

Branch GIT ID: c7e56a926e9f30b2642c102e5d047ddba3449c31
Jenkins Build URL: Acceptance Upstream DXP (master) #2996

ci:test:stable - 24 out of 26 jobs PASSED
24 Successful Jobs:
ci:test:relevant - 24 out of 27 jobs PASSED
24 Successful Jobs:
For more details click here.

This pull contains no unique failures.


Failures in common with acceptance upstream results at c7e56a9:
  1. test-portal-acceptance-pullrequest-batch(master)/central-requirements-jdk8/0
    Job Results:

    7 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0 #20211
      1. com.liferay.portal.modules.ModulesStructureTest.testScanGradleFiles
        junit.framework.AssertionFailedError: Artifact dependency {compile group: "com.liferay", name: "com.liferay.petra.http.invoker", version: "1.0.0"} in modules/apps/site-initializer/site-initializer-testray/extra/java-function/build.gradle not permitted on master branch. Use a project dependency instead.
          at com.liferay.portal.modules.ModulesStructureTest._testGradleFile(ModulesStructureTest.java:1454)
          at com.liferay.portal.modules.ModulesStructureTest.access$800(ModulesStructureTest.java:68)
          at com.liferay.portal.modules.ModulesStructureTest$4.visitFile(ModulesStructureTest.java:402)
          at com.liferay.portal.modules.ModulesStructureTest$4.visitFile(ModulesStructureTest.java:376)
          at java.nio.file.Files.walkFileTree(Files.java:2670)
          at java.nio.file.Files.walkFileTree(Files.java:2742)
          at com.liferay.portal.modules.ModulesStructureTest.testScanGradleFiles(ModulesStructureTest.java:374)
        
  2. test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8/0
    Job Results:

    2 Tests Passed.
    3 Tests Failed.

    1. AXIS_VARIABLE=0 #510617
      1. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanOSGiLog
        junit.framework.AssertionFailedError: 
        Portal log assert failure, OSGi log found: /opt/dev/projects/github/liferay-portal/bundles/osgi/state/1646404119710.log:
        !SESSION 2022-03-04 14:28:52.807 -----------------------------------------------
        eclipse.buildId=unknown
        java.version=1.8.0_121
        java.vendor=Oracle Corporation
        BootLoader constants: OS=linux, ARCH=x86_64, WS=gtk, NL=en_US
        

        !ENTRY com.liferay.site.initializer.extender 4 0 2022-03-04 14:28:52.807
        !MESSAGE FrameworkEvent ERROR
        !STACK 0
        org.osgi.framework.BundleException: Could not resolve module: com.liferay.site.initializer.extender [154]
        Unresolved requirement: Import-Package: com.liferay.commerce.account.util; version="1.3.0"

        at org.eclipse.osgi.container.Module.start(Module.java:444)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1682)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1662)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1624)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1555)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1)
        at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
        at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:340)

        !ENTRY com.lif...

      2. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError:
        FrameworkEvent ERROR
        org.osgi.framework.BundleException: Could not resolve module: com.liferay.site.initializer.extender [154]
        Unresolved requirement: Import-Package: com.liferay.commerce.account.util; version="1.3.0"

        at org.eclipse.osgi.container.Module.start(Module.java:444)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1682)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1662)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1624)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1555)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1)
        at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
        at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:340)

        at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)
        at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)
        at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)
        at java.nio.file.Files.walkFileTree(Files.java:2670)
        at java.nio.file.Files.walkFileTree(Files.java:2742)
        at com.liferay.portal.log.asser...

Test bundle downloads:

@liferay-continuous-integration
Copy link
Collaborator

All required test suite(s) passed.
Forwarding pull request to brianchandotcom.
Console

@liferay-continuous-integration
Copy link
Collaborator

Pull request has been successfully forwarded to brianchandotcom#114198
Console

@liferay-continuous-integration
Copy link
Collaborator

testray.main.component.name=Theme
testray.main.component.name=Navigation
Copy link

@john-co john-co Mar 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Esther-OC, This line for Navigation needs to be removed. frontend-theme module is owned by FI team so should have main.component.name set to a FI owned component ie: Theme. Not Navigation which is owned by echo team. Please send another pull to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants