New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LPS-148020 Increase CI coverage for themes module #1960
Conversation
CI is automatically triggering the following test suites:
|
❌ ci:test:sf - 0 out of 1 jobs passed in 4 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPS-148020 1 Failed Jobs:For more details click here.
|
Jenkins Build:test-portal-source-format#6336 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-frontend#1960 Testray Routine:EE Pull Request Testray Importer:publish-testray-report#2132 |
✔️ ci:test:stable - 23 out of 26 jobs passed✔️ ci:test:relevant - 24 out of 27 jobs passed in 1 hour 30 minutesClick here for more details.Base Branch:Branch Name: master Upstream Comparison:Branch GIT ID: 04647af13615180551f40fb84cd1bb65736be8f7 ci:test:stable - 23 out of 26 jobs PASSED3 Failed Jobs:23 Successful Jobs:
ci:test:relevant - 23 out of 27 jobs PASSED4 Failed Jobs:23 Successful Jobs:
For more details click here.This pull contains no unique failures.Failures in common with acceptance upstream results at 04647af:
Test bundle downloads:
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#560 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:liferay-frontend#1960 Testray Routine:EE Pull Request Testray Build:[master] ci:test:relevant - Esther-OC > liferay-frontend - PR#1960 - 2022-02-28[07:36:54] Testray Importer:publish-testray-report#1422 |
ci:forward |
CI is automatically triggering the following test suites:
The pull request will automatically be forwarded to the user
|
✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPS-148020 1 Successful Jobs:For more details click here. |
Jenkins Build:test-portal-source-format#1456 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-frontend#1960 Testray Routine:EE Pull Request Testray Importer:publish-testray-report#5277 |
✔️ ci:test:stable - 24 out of 26 jobs passed✔️ ci:test:relevant - 25 out of 27 jobs passed in 1 hour 40 minutesClick here for more details.Base Branch:Branch Name: master Upstream Comparison:Branch GIT ID: c7e56a926e9f30b2642c102e5d047ddba3449c31 ci:test:stable - 24 out of 26 jobs PASSED2 Failed Jobs:24 Successful Jobs:
ci:test:relevant - 24 out of 27 jobs PASSED3 Failed Jobs:24 Successful Jobs:
For more details click here.This pull contains no unique failures.Failures in common with acceptance upstream results at c7e56a9:
Test bundle downloads:
|
All required test suite(s) passed. |
Pull request has been successfully forwarded to brianchandotcom#114198 |
Jenkins Build:test-portal-acceptance-pullrequest(master)#1848 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:liferay-frontend#1960 Testray Routine:EE Pull Request Testray Build:[master] ci:test:relevant - Esther-OC > liferay-frontend - PR#1960 - 2022-03-04[05:28:58] Testray Importer:publish-testray-report#5280 |
testray.main.component.name=Theme | ||
testray.main.component.name=Navigation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Esther-OC, This line for Navigation
needs to be removed. frontend-theme module is owned by FI team so should have main.component.name set to a FI owned component ie: Theme. Not Navigation which is owned by echo team. Please send another pull to fix this.
The goal of this PR is edit the test.properties file of the frontend-theme module to include the
testray.main.component.name ~ "Navigation"
in order that the regression tests will also include Navigation tests when running theci:test:relevant
and then avoid regression bugs.JIRA issue: LPS-148020