LPD-19992 Validate name and id fields for links in CKEditor #4059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is automatically triggering the following test suites:
|
|
ci:test:relevant |
❌ ci:test:sf - 0 out of 1 jobs passed in 5 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPD-19992-b 1 Failed Jobs:For more details click here.at org.apache.tools.ant.Project.executeTargets(Project.java:1264) at org.apache.tools.ant.Main.runBuild(Main.java:818) at org.apache.tools.ant.Main.startAnt(Main.java:223) at org.apache.tools.ant.launch.Launcher.run(Launcher.java:280) at org.apache.tools.ant.launch.Launcher.main(Launcher.java:109) Caused by: java.net.UnknownHostException: mirrors-no-cache.lax.liferay.com at java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:196) at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:394) at java.net.Socket.connect(Socket.java:606) at sun.net.NetworkClient.doConnect(NetworkClient.java:175) at sun.net.www.http.HttpClient.openServer(HttpClient.java:499) at sun.net.www.http.HttpClient.openServer(HttpClient.java:594) at sun.net.www.http.HttpClient.<init>(HttpClient.java:278) at sun.net.www.http.HttpClient.New(HttpClient.java:375) at sun.net.www.http.HttpClient.New(HttpClient.java:393) at sun.net.www.protocol.http.HttpURLConnection.getNewHttpClient(HttpURLConnection.java:1240) at sun.net.www.protocol.http.HttpURLConnection.plainConnect0(HttpURLConnection.java:1167) at sun.net.www.protocol.http.HttpURLConnection.plainConnect(HttpURLConnection.java:1061) at sun.net.www.protocol.http.HttpURLConnection.connect(HttpURLConnection.java:995) at com.liferay.jenkins.results.parser.JenkinsResultsParserUtil.toInputStream(JenkinsResultsParserUtil.java:4756) at com.liferay.jenkins.results.parser.JenkinsResultsParserUtil.toBufferedReader(JenkinsResultsParserUtil.java:4356) at com.liferay.jenkins.results.parser.JenkinsResultsParserUtil.toString(JenkinsResultsParserUtil.java:5197) at com.liferay.jenkins.results.parser.JenkinsResultsParserUtil.getJenkinsBuildProperties(JenkinsResultsParserUtil.java:2309) ... 99 more [beanshell] Created cache file in /tmp/jenkins-cached-files/550755880.txt |
|
Jenkins Build:test-portal-source-format#2701 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-frontend#4059 Testray Routine:EE Pull Request Testray Build:[master] ci:test:sf - antonio-ortega > liferay-frontend - PR#4059 - 2024-03-11[15:23:00] Testray Build ID:2548783626 Testray Importer:publish-testray-report#11672 |
✔️ ci:test:stable - 33 out of 33 jobs passed✔️ ci:test:relevant - 70 out of 72 jobs passed in 1 hour 43 minutesClick here for more details.Base Branch:Branch Name: master Upstream Comparison:Branch GIT ID: 918d2a92fea02807d92eec05a2d4ab8903e11aea ci:test:stable - 33 out of 33 jobs PASSED33 Successful Jobs:ci:test:relevant - 69 out of 72 jobs PASSED3 Failed Jobs:
69 Successful Jobs:For more details click here.This pull contains no unique failures.Failures in common with acceptance upstream results at 918d2a9:Test bundle downloads:
|
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#8940 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:liferay-frontend#4059 Testray Routine:EE Pull Request Testray Build:[master] ci:test:relevant - antonio-ortega > liferay-frontend - PR#4059 - 2024-03-11[15:24:58] Testray Build ID:2548842679 Testray Importer:publish-testray-report#21354 |
|
ci:test:sf |
❌ ci:test:sf - 0 out of 1 jobs passed in 5 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPD-19992-b 1 Failed Jobs:For more details click here. [exec] 491:7 error Expected object keys to be in natural ascending order. 'html' should be before 'style'. sort-keys
[exec] 492:7 error Expected line before comment. lines-around-comment
[exec] 492:7 error Expected line after comment. lines-around-comment
[exec] 493:7 error Expected object keys to be in natural ascending order. 'focus' should be before 'html'. sort-keys
[exec] 494:7 error Expected method shorthand. object-shorthand
[exec] 498:6 error Expected method shorthand. object-shorthand
[exec] 506:6 error Expected object keys to be in natural ascending order. 'id' should be before 'type'. sort-keys
[exec] 508:6 error Expected object keys to be in natural ascending order. 'children' should be before 'padding'. sort-keys
[exec] 510:7 error Expected object keys to be in natural ascending order. 'id' should be before 'type'. sort-keys
[exec] 513:7 error Expected method shorthand. object-shorthand
[exec] 514:8 error Unexpected var, use let or const instead. no-var
[exec] 516:104 error Expected '!==' and instead saw '!='. eqeqeq
[exec] 520:8 error Unexpected var, use let or const instead. no-var
[exec] 521:8 error Expected blank line before this statement. padding-line-between-statements
[exec]
[exec]
[exec] FAILURE: Build failed with an exception.
[exec]
[exec] * What went wrong:
[exec] Execution failed for task ':packageRunCheckFormat'.
[exec] > Process 'command '/opt/dev/projects/github/liferay-portal/build/node/bin/node'' finished with non-zero exit value 1
[exec]
[exec] * Try:
[exec] > Run with --info or --debug option to get more log output.
[exec] > Run with --scan to get full insights.
[exec]
[exec] * Exception is:
[exec] org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':packageRunCheckFormat'.
[exec] at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.lambda\$executeIfValid\$1(ExecuteActionsTaskExecuter.java:145)
[exec] at org.gradle.internal.Try\$Failure.ifSuccessfulOrElse(Try.java:282)
[exec] at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeIfValid(ExecuteActionsTaskExecuter.java:143)
[exec] at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:131) |
|
Jenkins Build:test-portal-source-format#7505 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-frontend#4059 Testray Routine:EE Pull Request Testray Build:[master] ci:test:sf - antonio-ortega > liferay-frontend - PR#4059 - 2024-03-13[01:51:09] Testray Build ID:2549401668 Testray Importer:publish-testray-report#4758 |
This was referenced Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
I'm just adding link plugin to our CKEditor so I can patch it in order to validate name and id fields.
Before this, those fields are not meeting the spec, allowing, for example, spaces.
Thanks.
Regards.