Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-127312 [Bug] Clear editingExperience state on modal close #755

Closed
wants to merge 1 commit into from
Closed

LPS-127312 [Bug] Clear editingExperience state on modal close #755

wants to merge 1 commit into from

Conversation

dgarciasarai
Copy link

Description

When we create an experience, we stored a state called editingExperience in case the data entered by the user is wrong, keep the state and display an error. But if the user clicks on X or Cancel button to dismiss the modal, the state remains there and if you want to create an experience, it will trigger an action action of the previous experience (there is an experienceId in the state).

Solution

When creating or updating an experience successfully, then() clause is going to call onModalClose and the modal state will be false (close) and the editingExperience state will be clear. Also, if the user clicks on Cancel, X or outside the modal, it will be trigger onModalClose too, so the state will be also clear.

Screenshot

LPS-127312.bug-fixed.mov

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

@dgarciasarai dgarciasarai mentioned this pull request Feb 4, 2021
Closed
@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 4f5dd4c5c07162fa9e76f543b6c908069733a123

Sender Branch:

Branch Name: LPS-127312
Branch GIT ID: bc6adf6451de2f83d04bf979075f41dd1ddcb884

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

Jenkins Build:test-portal-source-format#4242
Jenkins Report:jenkins-report.html
Jenkins Suite: sf
Pull Request:liferay-frontend#755
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:sf
Spira Release Build:master - dgarciasarai > liferay-frontend - PR#755 - 2021-02-04[02:22:45]
Spira Jenkins Build:publish-spira-report#13221

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 24 out of 25 jobs passed in 3 hours 19 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 4f5dd4c5c07162fa9e76f543b6c908069733a123

Upstream Comparison:

Branch GIT ID: 4f5dd4c5c07162fa9e76f543b6c908069733a123
Jenkins Build URL: Acceptance Upstream DXP (master) #1513

ci:test:stable - 9 out of 9 jobs PASSED
9 Successful Jobs:
ci:test:relevant - 23 out of 25 jobs PASSED
23 Successful Jobs:
For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at 4f5dd4c:
  1. test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0
    Job Results:

    1164 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=4,label_exp=!master #348177
      1. PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError: 
Unable to connect to a valid mail server. Please make sure one is properly configured: Couldn't connect to host, port: localhost, 25; timeout -1
	at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)
	at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)
	at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)
	at java.nio.file.Files.walkFileTree(Files.java:2670)
	at java.nio.file.Files.walkFileTree(Files.java:2742)
	at com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog(PortalLogAssertorTest.java:86)

@liferay-continuous-integration
Copy link
Collaborator

Jenkins Build:test-portal-acceptance-pullrequest(master)#4195
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:liferay-frontend#755
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:relevant
Spira Release Build:master - dgarciasarai > liferay-frontend - PR#755 - 2021-02-04[03:01:44]
Spira Jenkins Build:publish-spira-report#10965

bryceosterhaus
bryceosterhaus approved these changes Feb 4, 2021
View reviewed changes
Copy link
Collaborator

@bryceosterhaus bryceosterhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ci:forward

@dgarciasarai
Copy link
Author

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

Skipping previously passed test suites:
ci:test:relevant
ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

All required test suite(s) passed.
Forwarding pullrequest to brianchandotcom.

@liferay-continuous-integration liferay-continuous-integration mentioned this pull request Feb 5, 2021
Closed
@liferay-continuous-integration
Copy link
Collaborator

Pull request has been successfully forwarded to brianchandotcom#98458

@dgarciasarai dgarciasarai deleted the LPS-127312 branch February 5, 2021 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryceosterhaus bryceosterhaus bryceosterhaus approved these changes

Assignees
No one assigned
Labels
ci:test:relevant - success ci:test:sf - success ci:test:stable - success
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dgarciasarai @liferay-continuous-integration @bryceosterhaus