New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-116771 Fix style of navigation-bar removing the extra container #90

Closed

edalgrin wants to merge 1 commit into liferay-frontend:master from edalgrin:LPS-116771

Collaborator

edalgrin commented Jul 8, 2020 •

edited

This is a simple style fix. I removed the extra container from the navigation-bar


          LPS-116771 Fix style of navigation-bar removing the extra container

c35248c

Collaborator

liferay-continuous-integration commented Jul 8, 2020

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

edalgrin mentioned this pull request

LPS-116771 Fix style of navigation-bar removing the extra container #89

Closed

edalgrin requested a review from jbalsas

July 8, 2020 16:22

Collaborator Author

edalgrin commented Jul 9, 2020

ci:test:sf

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - success and removed ci:test:sf - pending labels

Collaborator

liferay-continuous-integration commented Jul 9, 2020

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 55d40527df40c3f39622cde48931cf9e406f125e

Sender Branch:

Branch Name: LPS-116771
Branch GIT ID: c35248c3353441b106c3eae4463172084fc8984d

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

Collaborator

liferay-continuous-integration commented Jul 9, 2020

Jenkins Build:test-portal-source-format#3664
Jenkins Report:jenkins-report.html
Jenkins Suite: sf
Pull Request:liferay-frontend#90
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:sf
Spira Release Build:master - eduardoallegrini > liferay-frontend - PR#90
Spira Jenkins Build:publish-spira-report#314

jbalsas commented Jul 9, 2020

ci:test:relevant

jbalsas commented Jul 9, 2020

LGTM! 👍

jbalsas added the approved label

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending ci:test:relevant - failure ci:test:stable - failure and removed ci:test:relevant - pending ci:test:stable - pending labels

Collaborator

liferay-continuous-integration commented Jul 9, 2020

❌ ci:test:stable - 19 out of 20 jobs passed

❌ ci:test:relevant - 41 out of 51 jobs passed in 3 hours 26 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: dfa080768228be927b37085a56e541c05ce0f072

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 26d9c30572aa163b37c2bdb9a90c3ef3cbf122b3

ci:test:stable - 19 out of 20 jobs PASSED

1 Failed Jobs:

~~test-portal-acceptance-pullrequest-batch(master)/functional-upgrade-tomcat90-mysql57-jdk8_stable/7~~

19 Successful Jobs:

ci:test:relevant - 41 out of 51 jobs PASSED

10 Failed Jobs:

41 Successful Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-upgrade-tomcat90-mysql57-jdk8/11

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #404491

[CucumberReport] Copied 0 properties files from workspace "/opt/dev/projects/github/liferay-jenkins-ee/test-results/cucumber/build/reports/json" to reports directory "/opt/java/jenkins/jobs/test-portal-acceptance-pullrequest-batch(master)/configurations/axis-AXIS_VARIABLE/0/axis-label_exp/!master/builds/404491/cucumber-html-reports/.cache"
[CucumberReport] Processing 0 json files:
[CucumberReport] Missing report result - report was not successfully completed
[CucumberReport] Build status is left unchanged
[PostBuildScript] - Executing post build scripts.
define: [LabelParameterValue: NODE_NAME=cloud-10-0-110-29]
Triggering projects: verification-node
[liferay-jenkins-ee] \$ /bin/bash -e -x /tmp/jenkins1314467985863413378.sh
+ echo 'Update the workspace repository for post-build steps.'
Update the workspace repository for post-build steps.
+ git clean -d -f -x
+ git reset --hard
+ set +e
+ git show-ref --verify --quiet refs/heads/master-temp-1594296679722
+ VERIFY_BRANCH_RESULT=1
+ set -e
+ [[ 1 == 0 ]]
+ git checkout master
error: pathspec 'master' did not match any file(s) known to git.
[liferay-jenkins-ee] \$ /bin/bash -e -x /tmp/jenkins2633755515552550812.sh
+ echo 'Execute: build-test-portal-acceptance-pullrequest-batch.sh stop-current-job'
Execute: build-test-portal-acceptance-pullrequest-batch.sh stop-current-job
+ commands/build-test-portal-acceptance-pullrequest-batch.sh stop-current-job
/tmp/jenkins2633755515552550812.sh: line 5: commands/build-test-portal-acceptance-pullrequest-batch.sh: No such file or directory
[EnvInject] - Injecting environment variables from a build step.
[EnvInject] - [ERROR] - The given properties file path '/opt/dev/projects/github/liferay-jenkins-ee/stop.properties' doesn't exist.
[EnvInject] - [ERROR] - Missing file path was resolved from pattern '\$\{WORKSPACE\}/stop.properties' .
[EnvInject] - [ERROR] - Problems occurs on injecting env vars as a build step: java.io.IOException: The given properties file path '/opt/dev/projects/github/liferay-jenkins-ee/stop.properties' doesn't exist.
[description-setter] Description set: \$\{BUILD_DESCRIPTION\}
Build step 'Execute Scripts' marked build as failure
Finished: FAILURE

test-portal-acceptance-pullrequest-batch(master)/functional-upgrade-tomcat90-mysql57-jdk8/2

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #404486

[CucumberReport] Copied 0 properties files from workspace "/opt/dev/projects/github/liferay-jenkins-ee/test-results/cucumber/build/reports/json" to reports directory "/opt/java/jenkins/jobs/test-portal-acceptance-pullrequest-batch(master)/configurations/axis-AXIS_VARIABLE/0/axis-label_exp/!master/builds/404486/cucumber-html-reports/.cache"
[CucumberReport] Processing 0 json files:
[CucumberReport] Missing report result - report was not successfully completed
[CucumberReport] Build status is left unchanged
[PostBuildScript] - Executing post build scripts.
define: [LabelParameterValue: NODE_NAME=cloud-10-0-110-29]
Triggering projects: verification-node
[liferay-jenkins-ee] \$ /bin/bash -e -x /tmp/jenkins5757281451621088661.sh
+ echo 'Update the workspace repository for post-build steps.'
Update the workspace repository for post-build steps.
+ git clean -d -f -x
+ git reset --hard
+ set +e
+ git show-ref --verify --quiet refs/heads/master-temp-1594296656098
+ VERIFY_BRANCH_RESULT=1
+ set -e
+ [[ 1 == 0 ]]
+ git checkout master
error: pathspec 'master' did not match any file(s) known to git.
[liferay-jenkins-ee] \$ /bin/bash -e -x /tmp/jenkins1524718674936668178.sh
+ echo 'Execute: build-test-portal-acceptance-pullrequest-batch.sh stop-current-job'
Execute: build-test-portal-acceptance-pullrequest-batch.sh stop-current-job
+ commands/build-test-portal-acceptance-pullrequest-batch.sh stop-current-job
/tmp/jenkins1524718674936668178.sh: line 5: commands/build-test-portal-acceptance-pullrequest-batch.sh: No such file or directory
[EnvInject] - Injecting environment variables from a build step.
[EnvInject] - [ERROR] - The given properties file path '/opt/dev/projects/github/liferay-jenkins-ee/stop.properties' doesn't exist.
[EnvInject] - [ERROR] - Missing file path was resolved from pattern '\$\{WORKSPACE\}/stop.properties' .
[EnvInject] - [ERROR] - Problems occurs on injecting env vars as a build step: java.io.IOException: The given properties file path '/opt/dev/projects/github/liferay-jenkins-ee/stop.properties' doesn't exist.
[description-setter] Description set: \$\{BUILD_DESCRIPTION\}
Build step 'Execute Scripts' marked build as failure
Finished: FAILURE

test-portal-acceptance-pullrequest-batch(master)/functional-upgrade-tomcat90-mysql57-jdk8/3

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #404489

[CucumberReport] Copied 0 properties files from workspace "/opt/dev/projects/github/liferay-jenkins-ee/test-results/cucumber/build/reports/json" to reports directory "/opt/java/jenkins/jobs/test-portal-acceptance-pullrequest-batch(master)/configurations/axis-AXIS_VARIABLE/0/axis-label_exp/!master/builds/404489/cucumber-html-reports/.cache"
[CucumberReport] Processing 0 json files:
[CucumberReport] Missing report result - report was not successfully completed
[CucumberReport] Build status is left unchanged
[PostBuildScript] - Executing post build scripts.
define: [LabelParameterValue: NODE_NAME=cloud-10-0-110-29]
Triggering projects: verification-node
[liferay-jenkins-ee] \$ /bin/bash -e -x /tmp/jenkins3469710083996589547.sh
+ echo 'Update the workspace repository for post-build steps.'
Update the workspace repository for post-build steps.
+ git clean -d -f -x
+ git reset --hard
+ set +e
+ git show-ref --verify --quiet refs/heads/master-temp-1594296524443
+ VERIFY_BRANCH_RESULT=1
+ set -e
+ [[ 1 == 0 ]]
+ git checkout master
error: pathspec 'master' did not match any file(s) known to git.
[liferay-jenkins-ee] \$ /bin/bash -e -x /tmp/jenkins3793816664416627710.sh
+ echo 'Execute: build-test-portal-acceptance-pullrequest-batch.sh stop-current-job'
Execute: build-test-portal-acceptance-pullrequest-batch.sh stop-current-job
+ commands/build-test-portal-acceptance-pullrequest-batch.sh stop-current-job
/tmp/jenkins3793816664416627710.sh: line 5: commands/build-test-portal-acceptance-pullrequest-batch.sh: No such file or directory
[EnvInject] - Injecting environment variables from a build step.
[EnvInject] - [ERROR] - The given properties file path '/opt/dev/projects/github/liferay-jenkins-ee/stop.properties' doesn't exist.
[EnvInject] - [ERROR] - Missing file path was resolved from pattern '\$\{WORKSPACE\}/stop.properties' .
[EnvInject] - [ERROR] - Problems occurs on injecting env vars as a build step: java.io.IOException: The given properties file path '/opt/dev/projects/github/liferay-jenkins-ee/stop.properties' doesn't exist.
[description-setter] Description set: \$\{BUILD_DESCRIPTION\}
Build step 'Execute Scripts' marked build as failure
Finished: FAILURE

test-portal-acceptance-pullrequest-batch(master)/functional-upgrade-tomcat90-mysql57-jdk8/6

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #404488

[CucumberReport] Copied 0 properties files from workspace "/opt/dev/projects/github/liferay-jenkins-ee/test-results/cucumber/build/reports/json" to reports directory "/opt/java/jenkins/jobs/test-portal-acceptance-pullrequest-batch(master)/configurations/axis-AXIS_VARIABLE/0/axis-label_exp/!master/builds/404488/cucumber-html-reports/.cache"
[CucumberReport] Processing 0 json files:
[CucumberReport] Missing report result - report was not successfully completed
[CucumberReport] Build status is left unchanged
[PostBuildScript] - Executing post build scripts.
define: [LabelParameterValue: NODE_NAME=cloud-10-0-110-29]
Triggering projects: verification-node
[liferay-jenkins-ee] \$ /bin/bash -e -x /tmp/jenkins9003604871667909960.sh
+ echo 'Update the workspace repository for post-build steps.'
Update the workspace repository for post-build steps.
+ git clean -d -f -x
+ git reset --hard
+ set +e
+ git show-ref --verify --quiet refs/heads/master-temp-1594296459305
+ VERIFY_BRANCH_RESULT=1
+ set -e
+ [[ 1 == 0 ]]
+ git checkout master
error: pathspec 'master' did not match any file(s) known to git.
[liferay-jenkins-ee] \$ /bin/bash -e -x /tmp/jenkins5367252574868664917.sh
+ echo 'Execute: build-test-portal-acceptance-pullrequest-batch.sh stop-current-job'
Execute: build-test-portal-acceptance-pullrequest-batch.sh stop-current-job
+ commands/build-test-portal-acceptance-pullrequest-batch.sh stop-current-job
/tmp/jenkins5367252574868664917.sh: line 5: commands/build-test-portal-acceptance-pullrequest-batch.sh: No such file or directory
[EnvInject] - Injecting environment variables from a build step.
[EnvInject] - [ERROR] - The given properties file path '/opt/dev/projects/github/liferay-jenkins-ee/stop.properties' doesn't exist.
[EnvInject] - [ERROR] - Missing file path was resolved from pattern '\$\{WORKSPACE\}/stop.properties' .
[EnvInject] - [ERROR] - Problems occurs on injecting env vars as a build step: java.io.IOException: The given properties file path '/opt/dev/projects/github/liferay-jenkins-ee/stop.properties' doesn't exist.
[description-setter] Description set: \$\{BUILD_DESCRIPTION\}
Build step 'Execute Scripts' marked build as failure
Finished: FAILURE

test-portal-acceptance-pullrequest-batch(master)/functional-upgrade-tomcat90-mysql57-jdk8/7

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #404485

[CucumberReport] Copied 0 properties files from workspace "/opt/dev/projects/github/liferay-jenkins-ee/test-results/cucumber/build/reports/json" to reports directory "/opt/java/jenkins/jobs/test-portal-acceptance-pullrequest-batch(master)/configurations/axis-AXIS_VARIABLE/0/axis-label_exp/!master/builds/404485/cucumber-html-reports/.cache"
[CucumberReport] Processing 0 json files:
[CucumberReport] Missing report result - report was not successfully completed
[CucumberReport] Build status is left unchanged
[PostBuildScript] - Executing post build scripts.
define: [LabelParameterValue: NODE_NAME=cloud-10-0-110-29]
Triggering projects: verification-node
[liferay-jenkins-ee] \$ /bin/bash -e -x /tmp/jenkins7566638279023591670.sh
+ echo 'Update the workspace repository for post-build steps.'
Update the workspace repository for post-build steps.
+ git clean -d -f -x
+ git reset --hard
+ set +e
+ git show-ref --verify --quiet refs/heads/master-temp-1594296417000
+ VERIFY_BRANCH_RESULT=1
+ set -e
+ [[ 1 == 0 ]]
+ git checkout master
error: pathspec 'master' did not match any file(s) known to git.
[liferay-jenkins-ee] \$ /bin/bash -e -x /tmp/jenkins3775783627773700937.sh
+ echo 'Execute: build-test-portal-acceptance-pullrequest-batch.sh stop-current-job'
Execute: build-test-portal-acceptance-pullrequest-batch.sh stop-current-job
+ commands/build-test-portal-acceptance-pullrequest-batch.sh stop-current-job
/tmp/jenkins3775783627773700937.sh: line 5: commands/build-test-portal-acceptance-pullrequest-batch.sh: No such file or directory
[EnvInject] - Injecting environment variables from a build step.
[EnvInject] - [ERROR] - The given properties file path '/opt/dev/projects/github/liferay-jenkins-ee/stop.properties' doesn't exist.
[EnvInject] - [ERROR] - Missing file path was resolved from pattern '\$\{WORKSPACE\}/stop.properties' .
[EnvInject] - [ERROR] - Problems occurs on injecting env vars as a build step: java.io.IOException: The given properties file path '/opt/dev/projects/github/liferay-jenkins-ee/stop.properties' doesn't exist.
[description-setter] Description set: \$\{BUILD_DESCRIPTION\}
Build step 'Execute Scripts' marked build as failure
Finished: FAILURE

...

Collaborator

liferay-continuous-integration commented Jul 9, 2020

Jenkins Build:test-portal-acceptance-pullrequest(master)#5955
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:liferay-frontend#90
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:relevant
Spira Release Build:master - eduardoallegrini > liferay-frontend - PR#90
Spira Jenkins Build:publish-spira-report#4001

jbalsas commented Jul 9, 2020

ci:test:relevant

jbalsas commented Jul 9, 2020

Hey @john-co, failures look unrelated... running again just in case, could you take a look to see if something's wrong with CI?

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending and removed ci:test:relevant - failure ci:test:stable - failure labels

john-co mentioned this pull request

LPS-116201 Update liferay-ckeditor version in portal and implement changes to make it fit with new skin #66

Closed

liferay-continuous-integration added ci:test:relevant - success and removed ci:test:relevant - pending labels

john-co commented Jul 9, 2020

ci:test:bundle

liferay-continuous-integration added ci:test:stable - success and removed ci:test:stable - pending labels

Collaborator

liferay-continuous-integration commented Jul 9, 2020

✔️ ci:test:stable - 20 out of 20 jobs passed

✔️ ci:test:relevant - 51 out of 51 jobs passed in 1 hour 24 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 678e0cdde7e1364a6cbd1db1ac673384542da199

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 26d9c30572aa163b37c2bdb9a90c3ef3cbf122b3

ci:test:stable - 20 out of 20 jobs PASSED

20 Successful Jobs:

ci:test:relevant - 51 out of 51 jobs PASSED

51 Successful Jobs:

For more details click here.

Collaborator

liferay-continuous-integration commented Jul 9, 2020

Jenkins Build:test-portal-acceptance-pullrequest(master)#6488
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:liferay-frontend#90
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:relevant
Spira Release Build:master - eduardoallegrini > liferay-frontend - PR#90
Spira Jenkins Build:publish-spira-report#4015

liferay-continuous-integration added ci:test:bundle - pending ci:test:bundle - success and removed ci:test:bundle - pending labels

Collaborator

liferay-continuous-integration commented Jul 9, 2020

✔️ ci:test:bundle - 1 out of 1 jobs passed in 44 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 678e0cdde7e1364a6cbd1db1ac673384542da199

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 26d9c30572aa163b37c2bdb9a90c3ef3cbf122b3

ci:test:bundle - 1 out of 1 jobs PASSED

For more details click here.

Test bundle downloads:

liferay-portal-bundle-tomcat.tar.gz (mirrors: dlc, lax)

jbalsas added forwarding and removed approved labels

jbalsas commented Jul 9, 2020

ci:forward

Collaborator

liferay-continuous-integration commented Jul 9, 2020

CI is automatically triggering the following test suites:

ci:test:relevant
ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

ci:test:relevant
ci:test:sf
ci:test:stable

Collaborator

liferay-continuous-integration commented Jul 9, 2020

Skipping previously passed test suites:
ci:test:relevant
ci:test:sf

Collaborator

liferay-continuous-integration commented Jul 9, 2020

All required test suite(s) passed.
Forwarding pullrequest to brianchandotcom.

liferay-continuous-integration mentioned this pull request

LPS-116771 Fix style of navigation-bar removing the extra container brianchandotcom/liferay-portal#91141

Closed

Collaborator

liferay-continuous-integration commented Jul 9, 2020

Pull request has been successfully forwarded to brianchandotcom#91141

liferay-continuous-integration closed this

edalgrin deleted the LPS-116771 branch

September 4, 2020 07:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment