LPS-116792 - Add new global menu mobile pattern #95
Conversation
marcoscv-work
commented
Jul 9, 2020
•
marcoscv-work
commented
- This PR adds the new behavior for global menu in mobile, here an example:
- To test the PR you only have to open the global menu in mobile or resize your screen as you can see in the previous gif
|
To conserve resources, the PR Tester does not automatically run for every pull. If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed. If your pull was never tested, comment "ci:test" to run the PR Tester for this pull. |
|
ci:test:sf |
|
ci:test:relevant |
✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPS-116792 1 Successful Jobs:For more details click here. |
|
Jenkins Build:test-portal-source-format#3680 |
|
LGTM superficially 👍 |
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#6157 |
| @@ -5,6 +5,27 @@ $tab-header-height: 38px; | |||
|
|
|||
| .global-apps-menu-modal { | |||
| .global-apps-menu-header { | |||
| .autofit-row { | |||
| @include media-breakpoint-down(xs) { | |||
There was a problem hiding this comment.
I don't love the media-breakpoint-down but I guess it was necessary and "cheaper" than media-breakpoint-up 😁
There was a problem hiding this comment.
yeah, I've tried to do it by default helpers but is not possible, it is a corner case so I think the best is a custom CSS
|
ci:forward |
|
CI is automatically triggering the following test suites:
The pull request will automatically be forwarded to the user
|
|
Skipping previously passed test suites: |
|
All required test suite(s) passed. |
|
Pull request has been successfully forwarded to brianchandotcom#91119 |
