Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-124815 ImageSelector as a new react component #1224

Conversation

ambrinchaudhary
Copy link
Collaborator

No description provided.

@ambrinchaudhary
Copy link
Collaborator Author

ci:test:sf

@ambrinchaudhary ambrinchaudhary changed the title LPS-124815 BuildLang LPS-124815 ImageSelector as a new react component Dec 11, 2020
@ambrinchaudhary
Copy link
Collaborator Author

/cc @boton

@ambrinchaudhary
Copy link
Collaborator Author

ci:test:relevant

@ambrinchaudhary
Copy link
Collaborator Author

ci:forward

1 similar comment
@ambrinchaudhary
Copy link
Collaborator Author

ci:forward

@ambrinchaudhary
Copy link
Collaborator Author

ci:test:sf

1 similar comment
@pyoo47
Copy link

pyoo47 commented Dec 12, 2020

ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:sf - 0 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 6265d795b50b5e686e73d7e967d8d3283be2e792

Sender Branch:

Branch Name: LPS-118830_ImageSelector_remove_AUI
Branch GIT ID: 1a8b4093e3ba61f0b0047cf1d2093cbc0da7200e

0 out of 1jobs PASSED
For more details click here.
     [java] java.lang.Exception: Found 2 formatting issues:
     [java] 1: Remove HTML markup for 'drag-and-drop-to-upload-or', see https://github.com/liferay/liferay-portal/blob/master/modules/util/source-formatter/src/main/resources/documentation/checks/properties_language_keys_check.markdown: ./modules/apps/item-selector/item-selector-taglib/src/main/resources/content/Language.properties 3 (SourceCheck:PropertiesLanguageKeysCheck)
     [java] 2: ./modules/apps/item-selector/item-selector-taglib/src/main/resources/META-INF/resources/init.jsp expected:<...p://liferay.com/tld/[]theme" prefix="lifer...> but was:<...p://liferay.com/tld/[react" prefix="react" %><%@
     [java] taglib uri="http://liferay.com/tld/]theme" prefix="lifer...>
     [java] 
     [java] 	at com.liferay.source.formatter.SourceFormatter.format(SourceFormatter.java:462)
     [java] 	at com.liferay.source.formatter.SourceFormatter.main(SourceFormatter.java:276)
[stopwatch] [run.batch.test.action: 1:44.206 sec]
     [echo] The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/portal-impl/build.xml:572: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/portal-impl/build.xml:715: Java returned: 1
      [get] Getting: http://test-1-5/job/test-portal-source-format/4468//consoleText
      [get] To: /opt/dev/projects/github/liferay-portal/20201211164716442.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/20201211164716442.txt
  [typedef] Could not load definitions from resource org/apache/maven/artifact/ant/antlib.xml. It could not be found.
  [taskdef] Could not load definitions from resource org/jacoco/ant/antlib.xml. It could not be found.
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/null979848579.properties

merge-test-results:
[mkdir] Created dir: /opt/dev/projects/github/liferay-portal/test-results
[junitreport] Processing /opt/dev/projects/github/liferay-portal/test-results/TESTS-TestSuites.xml to /tmp/null1283890107
[junitreport] Loading stylesheet jar:file:/opt/java/ant/lib/ant-junit.jar!/org/apache/tools/ant/taskdefs/optional/junit/xsl/junit-frames.xsl
[junitreport] Transform time: 222ms
[junitreport] Deleting: /tmp/null1283890107
[echo] A report with all the test results can be found at test-results/html/index.html.
[mkdir] Created dir: /opt/dev/projects/github/liferay-jenkins-ee/test-results

@liferay-continuous-integration
Copy link
Collaborator

@austinchiang
Copy link
Collaborator

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:sf - 0 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 6265d795b50b5e686e73d7e967d8d3283be2e792

Sender Branch:

Branch Name: LPS-118830_ImageSelector_remove_AUI
Branch GIT ID: 1a8b4093e3ba61f0b0047cf1d2093cbc0da7200e

0 out of 1jobs PASSED
For more details click here.
     [java] java.lang.Exception: Found 2 formatting issues:
     [java] 1: Remove HTML markup for 'drag-and-drop-to-upload-or', see https://github.com/liferay/liferay-portal/blob/master/modules/util/source-formatter/src/main/resources/documentation/checks/properties_language_keys_check.markdown: ./modules/apps/item-selector/item-selector-taglib/src/main/resources/content/Language.properties 3 (SourceCheck:PropertiesLanguageKeysCheck)
     [java] 2: ./modules/apps/item-selector/item-selector-taglib/src/main/resources/META-INF/resources/init.jsp expected:<...p://liferay.com/tld/[]theme" prefix="lifer...> but was:<...p://liferay.com/tld/[react" prefix="react" %><%@
     [java] taglib uri="http://liferay.com/tld/]theme" prefix="lifer...>
     [java] 
     [java] 	at com.liferay.source.formatter.SourceFormatter.format(SourceFormatter.java:462)
     [java] 	at com.liferay.source.formatter.SourceFormatter.main(SourceFormatter.java:276)
[stopwatch] [run.batch.test.action: 1:38.563 sec]
     [echo] The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/portal-impl/build.xml:572: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/portal-impl/build.xml:715: Java returned: 1
      [get] Getting: http://test-1-19/job/test-portal-source-format/4866//consoleText
      [get] To: /opt/dev/projects/github/liferay-portal/20201213150514945.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/20201213150514945.txt
  [typedef] Could not load definitions from resource org/apache/maven/artifact/ant/antlib.xml. It could not be found.
  [taskdef] Could not load definitions from resource org/jacoco/ant/antlib.xml. It could not be found.
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/null836270498.properties

merge-test-results:
[mkdir] Created dir: /opt/dev/projects/github/liferay-portal/test-results
[junitreport] Processing /opt/dev/projects/github/liferay-portal/test-results/TESTS-TestSuites.xml to /tmp/null948826386
[junitreport] Loading stylesheet jar:file:/opt/java/ant/lib/ant-junit.jar!/org/apache/tools/ant/taskdefs/optional/junit/xsl/junit-frames.xsl
[junitreport] Transform time: 190ms
[junitreport] Deleting: /tmp/null948826386
[echo] A report with all the test results can be found at test-results/html/index.html.
[mkdir] Created dir: /opt/dev/projects/github/liferay-jenkins-ee/test-results

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:stable - 8 out of 9 jobs passed

❌ ci:test:relevant - 20 out of 23 jobs passed in 1 hour 19 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 6265d795b50b5e686e73d7e967d8d3283be2e792

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 22478fba589bf9dfa1ff6225fb25ee8fcbb03693

ci:test:stable - 8 out of 9 jobs PASSED
8 Successful Jobs:
ci:test:relevant - 20 out of 23 jobs PASSED
20 Successful Jobs:
For more details click here.

Failures unique to this pull:

  1. test-portal-acceptance-pullrequest-batch(master)/functional-upgrade-tomcat90-mysql57-jdk8_stable/0
    Job Results:

    5 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=5,label_exp=!master #454157
      [CucumberReport] Copied 0 properties files from workspace "/opt/dev/projects/github/liferay-jenkins-ee/test-results/cucumber/build/reports/json" to reports directory "/opt/java/jenkins/jobs/test-portal-acceptance-pullrequest-batch(master)/configurations/axis-AXIS_VARIABLE/5/axis-label_exp/!master/builds/454157/cucumber-html-reports/.cache"
      [CucumberReport] Processing 0 json files:
      [CucumberReport] Missing report result - report was not successfully completed
      [CucumberReport] Build status is left unchanged
      [PostBuildScript] - Executing post build scripts.
      define: [LabelParameterValue: NODE_NAME=cloud-10-0-10-30]
      Triggering projects: verification-node
      [liferay-jenkins-ee] $ /bin/bash -e -x /tmp/jenkins2996175314606868470.sh
      + echo 'Update the workspace repository for post-build steps.'
      Update the workspace repository for post-build steps.
      + git clean -d -f -x
      + git reset --hard
      HEAD is now at dede47e56c LRIS-18048 Regen
      + set +e
      + git show-ref --verify --quiet refs/heads/master-temp-1607903179945
      + VERIFY_BRANCH_RESULT=1
      + set -e
      + [[ 1 == 0 ]]
      + git checkout master
      Already on 'master'
      Your branch is up to date with 'origin/master'.
      + git log -n 1
      commit dede47e56c77e347fa510dcdaf4629b23d765869
      Author: Vishal Reddy <vishal.reddy@liferay.com>
      Date:   Tue Jan 5 16:51:13 2016 -0800
      
      LRIS-18048 Regen
      
      • echo 'Exit shell.'
        Exit shell.
        [liferay-jenkins-ee] $ /bin/bash -e -x /tmp/jenkins3172259851142280814.sh
      • echo 'Execute: build-test-portal-acceptance-pullrequest-batch.sh stop-current-job'
        Execute: build-test-portal-acceptance-pullrequest-batch.sh stop-current-job
      • commands/build-test-portal-acceptance-pullrequest-batch.sh stop-current-job
        Execute: ant -f commands/build-test-portal-acceptance-pullrequest-batch.xml stop-current-job
        Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=512m; support was removed in 8.0
        Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=100m; support was removed in 8.0
        Buildfile: /opt/dev/projects/github/liferay-jenkins-ee/commands/build-test-portal-acceptance-pullrequest-batch.xml

      BUILD FAILED
      /opt/dev/projects/github/liferay-jenkins-ee/commands/build-test-portal-acceptance-pullrequest-batch.xml:7: Please set the property ${env.TOP_LEVEL_SHARED_DIR}.


Failures in common with acceptance upstream results at 6265d79:
  1. test-portal-acceptance-pullrequest-batch(master)/modules-semantic-versioning-jdk8/0
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #371306

      Please fix semantic versioning on ambrinchaudhary/LPS-118830_ImageSelector_remove_AUI

           [exec]
      [exec] > Task :apps:item-selector:item-selector-upload-web:compileJSP
      [exec]
      [exec] > Task :apps:item-selector:item-selector-web:generateJSPJava
      [exec] Compiling JSP files of project ':apps:item-selector:item-selector-web' with /opt/dev/projects/github/liferay-portal/bundles/tomcat-9.0.37/webapps/ROOT/WEB-INF/lib/util-taglib.jar as dependency in place of 'com.liferay.portal:com.liferay.util.taglib'
      [exec]
      [exec] > Task :apps:item-selector:item-selector-upload-web:jar
      [exec] > Task :apps:item-selector:item-selector-upload-web:autoUpdateXml SKIPPED
      [exec] > Task :apps:item-selector:item-selector-upload-web:baseline SKIPPED
      [exec] > Task :apps:item-selector:item-selector-upload-web:syncVersions
      [exec] Note: /opt/dev/projects/github/liferay-portal/modules/apps/item-selector/item-selector-web/build/jspc/org/apache/jsp/view_005fitem_005fselector_005fview_005fdescriptor_jsp.java uses unchecked or unsafe operations.
      [exec] Note: Recompile with -Xlint:unchecked for details.
      [exec]
      [exec] > Task :apps:item-selector:item-selector-web:compileJSP
      [exec]
      [exec] > Task :apps:item-selector:item-selector-web:jar
      [exec] > Task :apps:item-selector:item-selector-web:autoUpdateXml SKIPPED
      [exec] > Task :apps:item-selector:item-selector-web:baseline SKIPPED
      [exec] > Task :apps:item-selector:item-selector-web:syncVersions
      [exec] > Task :apps:item-selector:item-selector-taglib:baseline
      [exec] > Task :apps:item-selector:item-selector-taglib:syncVersions
      [exec]
      [exec]
      [exec] FAILURE: Build failed with an exception.
      [exec]
      [exec] * What went wrong:
      [exec] Execution failed for task ':apps:item-selector:item-selector-criteria-api:baseline'.
      [exec] > A failure occurred while executing com.liferay.gradle.plugins.baseline.internal.work.BaselineWorkAction
      [exec] > org.gradle.api.GradleException: Semantic versioning is incorrect while checking /opt/dev/projects/github/liferay-portal/tools/sdk/dist/com.liferay.item.selector.criteria.api-6.0.0.jar against /opt/dev/projects/github/liferay-portal/.gradle/caches/modules-2/files-2.1/com.liferay/com.liferay.item.selector.criteria.api/5.4.0/b61a64e9ff60baae8a16257a02beaad7fd5bb570/com.liferay.item.selector.criteria.api-5.4.0.jar

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:sf - 0 out of 1 jobs passed in 4 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 672d7625e792ef9d37a9fc796f37f98467cddac6

Sender Branch:

Branch Name: LPS-118830_ImageSelector_remove_AUI
Branch GIT ID: 870275f6960a1703a587e8d7831cb39d468567e1

0 out of 1jobs PASSED
For more details click here.
     [java] java.lang.Exception: Found 1 formatting issues:
     [java] 1: ./modules/apps/item-selector/item-selector-taglib/src/main/resources/META-INF/resources/init.jsp expected:<...p://liferay.com/tld/[]theme" prefix="lifer...> but was:<...p://liferay.com/tld/[react" prefix="react" %><%@
     [java] taglib uri="http://liferay.com/tld/]theme" prefix="lifer...>
     [java] 
     [java] 	at com.liferay.source.formatter.SourceFormatter.format(SourceFormatter.java:462)
     [java] 	at com.liferay.source.formatter.SourceFormatter.main(SourceFormatter.java:276)
[stopwatch] [run.batch.test.action: 2:00.809 sec]
     [echo] The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/portal-impl/build.xml:572: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/portal-impl/build.xml:715: Java returned: 1
      [get] Getting: http://test-1-2/job/test-portal-source-format/4251//consoleText
      [get] To: /opt/dev/projects/github/liferay-portal/20201214121542330.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/20201214121542330.txt
  [typedef] Could not load definitions from resource org/apache/maven/artifact/ant/antlib.xml. It could not be found.
  [taskdef] Could not load definitions from resource org/jacoco/ant/antlib.xml. It could not be found.
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/null1825852486.properties

merge-test-results:
[mkdir] Created dir: /opt/dev/projects/github/liferay-portal/test-results
[junitreport] Processing /opt/dev/projects/github/liferay-portal/test-results/TESTS-TestSuites.xml to /tmp/null518149732
[junitreport] Loading stylesheet jar:file:/opt/java/ant/lib/ant-junit.jar!/org/apache/tools/ant/taskdefs/optional/junit/xsl/junit-frames.xsl
[junitreport] Transform time: 301ms
[junitreport] Deleting: /tmp/null518149732
[echo] A report with all the test results can be found at test-results/html/index.html.
[mkdir] Created dir: /opt/dev/projects/github/liferay-jenkins-ee/test-results
[copy] Copying 1 file to /opt/dev/projects/github/liferay-jenkins-ee/test-results
[echo] run.batch.test.tear.down.start.timestamp: 12-14-2020 12:15:47:747 PST
[stopwatch] [run.batch.test.tear.down: 0.000 sec]
[echo]
[echo] Ant GC log:
[echo]

@ambrinchaudhary
Copy link
Collaborator Author

ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 672d7625e792ef9d37a9fc796f37f98467cddac6

Sender Branch:

Branch Name: LPS-118830_ImageSelector_remove_AUI
Branch GIT ID: 64caa83edab2d65eb09a5503b6bf8da2744c1d6c

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

@ambrinchaudhary
Copy link
Collaborator Author

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

Skipping previously passed test suites:
ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 22 out of 23 jobs passed in 1 hour 50 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: c0706dce0fab7a645cba8a3951c82b380d265d34

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 22478fba589bf9dfa1ff6225fb25ee8fcbb03693

ci:test:stable - 9 out of 9 jobs PASSED
9 Successful Jobs:
ci:test:relevant - 21 out of 23 jobs PASSED
21 Successful Jobs:
For more details click here.

This pull contains no unique failures.


Failures in common with acceptance upstream results at cda3343:
  1. test-portal-acceptance-pullrequest-batch(master)/modules-semantic-versioning-jdk8/0
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #410177

      Please fix semantic versioning on ambrinchaudhary/LPS-118830_ImageSelector_remove_AUI

           [exec] 
           [exec] > Task :apps:item-selector:item-selector-upload-web:compileJSP
           [exec] 
           [exec] > Task :apps:item-selector:item-selector-web:generateJSPJava
           [exec] Compiling JSP files of project ':apps:item-selector:item-selector-web' with /opt/dev/projects/github/liferay-portal/bundles/tomcat-9.0.37/webapps/ROOT/WEB-INF/lib/util-taglib.jar as dependency in place of 'com.liferay.portal:com.liferay.util.taglib'
           [exec] 
           [exec] > Task :apps:item-selector:item-selector-upload-web:jar
           [exec] > Task :apps:item-selector:item-selector-upload-web:autoUpdateXml SKIPPED
           [exec] > Task :apps:item-selector:item-selector-upload-web:baseline SKIPPED
           [exec] > Task :apps:item-selector:item-selector-upload-web:syncVersions
           [exec] Note: /opt/dev/projects/github/liferay-portal/modules/apps/item-selector/item-selector-web/build/jspc/org/apache/jsp/view_005fitem_005fselector_005fview_005fdescriptor_jsp.java uses unchecked or unsafe operations.
           [exec] Note: Recompile with -Xlint:unchecked for details.
           [exec] 
           [exec] > Task :apps:item-selector:item-selector-web:compileJSP
           [exec] 
           [exec] > Task :apps:item-selector:item-selector-taglib:baseline
           [exec] > Task :apps:item-selector:item-selector-taglib:syncVersions
           [exec] > Task :apps:item-selector:item-selector-web:jar
           [exec] > Task :apps:item-selector:item-selector-web:autoUpdateXml SKIPPED
           [exec] > Task :apps:item-selector:item-selector-web:baseline SKIPPED
           [exec] > Task :apps:item-selector:item-selector-web:syncVersions
           [exec] 
           [exec] 
           [exec] FAILURE: Build failed with an exception.
           [exec] 
           [exec] * What went wrong:
           [exec] Execution failed for task ':apps:item-selector:item-selector-criteria-api:baseline'.
           [exec] > A failure occurred while executing com.liferay.gradle.plugins.baseline.internal.work.BaselineWorkAction
           [exec]    > org.gradle.api.GradleException: Semantic versioning is incorrect while checking /opt/dev/projects/github/liferay-portal/tools/sdk/dist/com.liferay.item.selector.criteria.api-6.0.0.jar against /opt/dev/projects/github/liferay-portal/.gradle/caches/modules-2/files-2.1/com.liferay/com.liferay.item.selector.criteria.api/5.4.0/b61a64e9ff60baae8a16257a02beaad7fd5bb570/com.liferay.item.selector.criteria.api-5.4.0.jar

@liferay-continuous-integration
Copy link
Collaborator

All required test suite(s) passed.
Forwarding pullrequest to brianchandotcom.

@liferay-continuous-integration
Copy link
Collaborator

Pull request has been successfully forwarded to brianchandotcom#96902

@liferay-continuous-integration
Copy link
Collaborator

@ambrinchaudhary ambrinchaudhary deleted the LPS-118830_ImageSelector_remove_AUI branch March 4, 2021 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants