New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LPS-131382 no need to load the react component if do you not have permissions #1787
LPS-131382 no need to load the react component if do you not have permissions #1787
Conversation
To conserve resources, the PR Tester does not automatically run for every pull. If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed. If your pull was never tested, comment "ci:test" to run the PR Tester for this pull. |
ci:test:sf |
ci:test:relevant |
✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPS-131382 1 Successful Jobs:For more details click here. |
Jenkins Build:test-portal-source-format#4755 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-lima#1787 Testray Routine:EE Pull Request Testray Build:[master] ci:test:sf - AliciaGarciaGarcia > liferay-lima - PR#1787 - 2021-04-30[03:23:42] Testray Importer:publish-testray-report#926 |
Jenkins Build:test-portal-acceptance-pullrequest(master)#9564 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:liferay-lima#1787 Testray Routine:EE Pull Request Testray Build:[master] ci:test:relevant - AliciaGarciaGarcia > liferay-lima - PR#1787 - 2021-04-30[03:23:46] Testray Importer:publish-testray-report#781 |
Just started reviewing :) |
ci:test:relevant |
ci:forward |
CI is automatically triggering the following test suites:
The pull request will automatically be forwarded to the user
|
@AliciaGarciaGarcia and I move the react into a |
✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPS-131382 1 Successful Jobs:For more details click here. |
Jenkins Build:test-portal-source-format#5824 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-lima#1787 Testray Routine:EE Pull Request Testray Build:[master] ci:test:sf - AliciaGarciaGarcia > liferay-lima - PR#1787 - 2021-05-04[09:12:59] Testray Importer:publish-testray-report#852 |
✔️ ci:test:stable - 9 out of 9 jobs passed✔️ ci:test:relevant - 21 out of 23 jobs passed in 1 hour 46 minutesClick here for more details.Base Branch:Branch Name: master Upstream Comparison:Branch GIT ID: a31589a97b13d747dcc409156d4e67907ead0bfd ci:test:stable - 9 out of 9 jobs PASSED9 Successful Jobs:
ci:test:relevant - 20 out of 23 jobs PASSED3 Failed Jobs:20 Successful Jobs:
For more details click here.This pull contains no unique failures.Failures in common with acceptance upstream results at a31589a:
|
✔️ ci:test:stable - 9 out of 9 jobs passed✔️ ci:test:relevant - 21 out of 23 jobs passed in 1 hour 51 minutesClick here for more details.Base Branch:Branch Name: master Upstream Comparison:Branch GIT ID: a31589a97b13d747dcc409156d4e67907ead0bfd ci:test:stable - 9 out of 9 jobs PASSED9 Successful Jobs:
ci:test:relevant - 20 out of 23 jobs PASSED3 Failed Jobs:20 Successful Jobs:
For more details click here.This pull contains no unique failures.Failures in common with acceptance upstream results at a31589a:
|
All required test suite(s) passed. |
Pull request has been successfully forwarded to brianchandotcom#101389 |
Jenkins Build:test-portal-acceptance-pullrequest(master)#8456 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:liferay-lima#1787 Testray Routine:EE Pull Request Testray Build:[master] ci:test:relevant - AliciaGarciaGarcia > liferay-lima - PR#1787 - 2021-05-04[09:12:45] Testray Importer:publish-testray-report#726 |
Jenkins Build:test-portal-acceptance-pullrequest(master)#8164 Jenkins Report:jenkins-report.html Jenkins Suite:relevant Pull Request:liferay-lima#1787 Testray Routine:EE Pull Request Testray Build:[master] ci:test:relevant - AliciaGarciaGarcia > liferay-lima - PR#1787 - 2021-05-04[09:12:56] Testray Importer:publish-testray-report#986 |
https://issues.liferay.com/browse/LPS-131382
If there is not permission to the article or the article is unreachable, there is no need to load the react component that was throwing the error of the translation component cause the InfoFieldSetEntriesData was null.
So I decided that there is no need to load it if there is no permission and that shows the message that it expected to be shown.
As said on the ticket, the error on console is thrown on the previous page and if they do not want it to be shown is another issue