Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-131382 no need to load the react component if do you not have permissions #1787

Conversation

AliciaGarciaGarcia
Copy link
Collaborator

@AliciaGarciaGarcia AliciaGarciaGarcia commented Apr 30, 2021

https://issues.liferay.com/browse/LPS-131382

If there is not permission to the article or the article is unreachable, there is no need to load the react component that was throwing the error of the translation component cause the InfoFieldSetEntriesData was null.

So I decided that there is no need to load it if there is no permission and that shows the message that it expected to be shown.

image

As said on the ticket, the error on console is thrown on the previous page and if they do not want it to be shown is another issue

@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@adolfopa
Copy link
Collaborator

ci:test:sf

@adolfopa
Copy link
Collaborator

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 648105cf63932af9173a603bb43e553b7d7793df

Sender Branch:

Branch Name: LPS-131382
Branch GIT ID: 89e23f003b977d8b650eacfae1ae9e8bac23d7ad

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 9 out of 9 jobs passed

❌ ci:test:relevant - 19 out of 23 jobs passed in 2 hours 15 minutes

Click here for more details.

This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result:

ci:reevaluate:1037401_9564

Base Branch:

Branch Name: master
Branch GIT ID: 648105cf63932af9173a603bb43e553b7d7793df

Upstream Comparison:

Branch GIT ID: 318146d8babd408ff5f16b93b0e04428cbf3241f
Jenkins Build URL: Acceptance Upstream DXP (master) #1818

ci:test:stable - 9 out of 9 jobs PASSED
9 Successful Jobs:
ci:test:relevant - 19 out of 23 jobs PASSED
19 Successful Jobs:
For more details click here.

Failures unique to this pull:


Failures in common with acceptance upstream results at 318146d:
  1. test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0
    Job Results:

    447 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=1,label_exp=!master #328817
      1. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError: 
        failure in bulk execution:
        [0]: index [liferay-20103-workflow-metrics-instances], type [WorkflowMetricsInstanceType], id [WorkflowMetricsInstance7ed1c3bf7b4870d2ac257a388df1177e30b2ac71b9b8e622c363a149487ccef1], message [[liferay-20103-workflow-metrics-instances] ElasticsearchException[Elasticsearch exception [type=index_not_found_exception, reason=no such index [liferay-20103-workflow-metrics-instances]]]]
        	at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)
        	at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)
        	at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)
        	at java.nio.file.Files.walkFileTree(Files.java:2670)
        	at java.nio.file.Files.walkFileTree(Files.java:2742)
        	at com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog(PortalLogAssertorTest.java:86)
        

@liferay-continuous-integration
Copy link
Collaborator

@boton
Copy link
Collaborator

boton commented May 4, 2021

We can't move the react component inside the form because the react component renders the complete form, including the buttons' navbar.

This works fine when the user hasn't permissions or the article is unreachable but breaks the UI in another case.

The failing test shows it.

image

@boton
Copy link
Collaborator

boton commented May 4, 2021

Just started reviewing :)

:octocat: Sent from GH.

@boton
Copy link
Collaborator

boton commented May 4, 2021

ci:test:relevant

@boton
Copy link
Collaborator

boton commented May 4, 2021

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@boton
Copy link
Collaborator

boton commented May 4, 2021

@AliciaGarciaGarcia and I move the react into a c:if instead of reuse the actual c:when

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: af58ea9ec030eaa16e3928456c5a3c46d86cc8c8

Sender Branch:

Branch Name: LPS-131382
Branch GIT ID: 9c9263d7832e5447d3ca748c2432bb7455a3ff0c

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 21 out of 23 jobs passed in 1 hour 46 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: af58ea9ec030eaa16e3928456c5a3c46d86cc8c8

Upstream Comparison:

Branch GIT ID: a31589a97b13d747dcc409156d4e67907ead0bfd
Jenkins Build URL: Acceptance Upstream DXP (master) #1824

ci:test:stable - 9 out of 9 jobs PASSED
9 Successful Jobs:
ci:test:relevant - 20 out of 23 jobs PASSED
20 Successful Jobs:
For more details click here.

This pull contains no unique failures.


Failures in common with acceptance upstream results at a31589a:
  1. test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8/0
    Job Results:

    2 Tests Passed.
    3 Tests Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #385935
      1. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanOSGiLog
        junit.framework.AssertionFailedError: 
        Portal log assert failure, OSGi log found: /opt/dev/projects/github/liferay-portal/bundles/osgi/state/1620149846623.log:
        !SESSION 2021-05-04 17:37:49.318 -----------------------------------------------
        eclipse.buildId=unknown
        java.version=1.8.0_121
        java.vendor=Oracle Corporation
        BootLoader constants: OS=linux, ARCH=x86_64, WS=gtk, NL=en_US
        

        !ENTRY com.liferay.portal.vulcan.impl 4 0 2021-05-04 17:37:49.330
        !MESSAGE FrameworkEvent ERROR
        !STACK 0
        org.osgi.framework.BundleException: Could not resolve module: com.liferay.portal.vulcan.impl [964]
        Unresolved requirement: Import-Package: com.liferay.object.graphql; version="[1.0.0,2.0.0)"

        at org.eclipse.osgi.container.Module.start(Module.java:444)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1682)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1662)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1624)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1555)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1)
        at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
        at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:340)
        
        
        at com.liferay.portal.log...</code></pre></div></li><li><div><a href="https://test-1-10.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master/385935//testReport/com.liferay.portal.log.assertor/PortalLogAssertorTest/testScanXMLLog">com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog</a><pre><code>junit.framework.AssertionFailedError: 
        

        FrameworkEvent ERROR
        org.osgi.framework.BundleException: Could not resolve module: com.liferay.portal.vulcan.impl [964]
        Unresolved requirement: Import-Package: com.liferay.object.graphql; version="[1.0.0,2.0.0)"

        at org.eclipse.osgi.container.Module.start(Module.java:444)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1682)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1662)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1624)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1555)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1)
        at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
        at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:340)
        
        at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)
        at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)
        at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)
        at java.nio.file.Files.walkFileTree(Files.java:2670)
        at java.nio.file.Files.walkFileTree(Files.java:2742)
        at com.liferay.portal.log.assertor.Po...</code></pre></div></li><li><div><a href="https://test-1-10.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master/385935//testReport/com.liferay.poshi.runner/PoshiRunner/test_LocalFile_PortalSmoke_Smoke_">LocalFile.PortalSmoke#Smoke</a> - <a href="https://testray.liferay.com/reports/production/logs/2021-05/test-1-6/test-portal-acceptance-pullrequest(master)/8456/lpkg-base-jdk8/0/0/LocalFile.PortalSmoke_Smoke/index.html.gz">Poshi Report</a> - <a href="https://testray.liferay.com/reports/production/logs/2021-05/test-1-6/test-portal-acceptance-pullrequest(master)/8456/lpkg-base-jdk8/0/0/LocalFile.PortalSmoke_Smoke/summary.html.gz">Poshi Summary</a> - <a href="https://testray.liferay.com/reports/production/logs/2021-05/test-1-6/test-portal-acceptance-pullrequest(master)/8456/lpkg-base-jdk8/0/0/jenkins-console.txt.gz">Console Output</a></div></li></ol></div></li></ol></div></li></ol></details></details></html>
        

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 21 out of 23 jobs passed in 1 hour 51 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: af58ea9ec030eaa16e3928456c5a3c46d86cc8c8

Upstream Comparison:

Branch GIT ID: a31589a97b13d747dcc409156d4e67907ead0bfd
Jenkins Build URL: Acceptance Upstream DXP (master) #1824

ci:test:stable - 9 out of 9 jobs PASSED
9 Successful Jobs:
ci:test:relevant - 20 out of 23 jobs PASSED
20 Successful Jobs:
For more details click here.

This pull contains no unique failures.


Failures in common with acceptance upstream results at a31589a:
  1. test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8/0
    Job Results:

    2 Tests Passed.
    3 Tests Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #473981
      1. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanOSGiLog
        junit.framework.AssertionFailedError: 
        Portal log assert failure, OSGi log found: /opt/dev/projects/github/liferay-portal/bundles/osgi/state/1620149731310.log:
        !SESSION 2021-05-04 17:35:57.443 -----------------------------------------------
        eclipse.buildId=unknown
        java.version=1.8.0_121
        java.vendor=Oracle Corporation
        BootLoader constants: OS=linux, ARCH=x86_64, WS=gtk, NL=en_US
        

        !ENTRY com.liferay.portal.vulcan.impl 4 0 2021-05-04 17:35:57.443
        !MESSAGE FrameworkEvent ERROR
        !STACK 0
        org.osgi.framework.BundleException: Could not resolve module: com.liferay.portal.vulcan.impl [1114]
        Unresolved requirement: Import-Package: com.liferay.object.graphql; version="[1.0.0,2.0.0)"

        at org.eclipse.osgi.container.Module.start(Module.java:444)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1682)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1662)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1624)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1555)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1)
        at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
        at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:340)
        
        
        at com.liferay.portal.lo...</code></pre></div></li><li><div><a href="https://test-1-4.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master/473981//testReport/com.liferay.portal.log.assertor/PortalLogAssertorTest/testScanXMLLog">com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog</a><pre><code>junit.framework.AssertionFailedError: 
        

        FrameworkEvent ERROR
        org.osgi.framework.BundleException: Could not resolve module: com.liferay.portal.vulcan.impl [1114]
        Unresolved requirement: Import-Package: com.liferay.object.graphql; version="[1.0.0,2.0.0)"

        at org.eclipse.osgi.container.Module.start(Module.java:444)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1682)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1662)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1624)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1555)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1)
        at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
        at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:340)
        
        at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)
        at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)
        at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)
        at java.nio.file.Files.walkFileTree(Files.java:2670)
        at java.nio.file.Files.walkFileTree(Files.java:2742)
        at com.liferay.portal.log.assertor.P...</code></pre></div></li><li><div><a href="https://test-1-4.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master/473981//testReport/com.liferay.poshi.runner/PoshiRunner/test_LocalFile_PortalSmoke_Smoke_">LocalFile.PortalSmoke#Smoke</a> - <a href="https://testray.liferay.com/reports/production/logs/2021-05/test-1-4/test-portal-acceptance-pullrequest(master)/8164/lpkg-base-jdk8/0/0/LocalFile.PortalSmoke_Smoke/index.html.gz">Poshi Report</a> - <a href="https://testray.liferay.com/reports/production/logs/2021-05/test-1-4/test-portal-acceptance-pullrequest(master)/8164/lpkg-base-jdk8/0/0/LocalFile.PortalSmoke_Smoke/summary.html.gz">Poshi Summary</a> - <a href="https://testray.liferay.com/reports/production/logs/2021-05/test-1-4/test-portal-acceptance-pullrequest(master)/8164/lpkg-base-jdk8/0/0/jenkins-console.txt.gz">Console Output</a></div></li></ol></div></li></ol></div></li></ol></details></details></html>
        

@liferay-continuous-integration
Copy link
Collaborator

All required test suite(s) passed.
Forwarding pull request to brianchandotcom.
Console

@liferay-continuous-integration
Copy link
Collaborator

Pull request has been successfully forwarded to brianchandotcom#101389
Console

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants