Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TS] LPS-132128 #1818

Conversation

jonathanmccann
Copy link
Collaborator

@jonathanmccann jonathanmccann commented May 12, 2021

Hello,

This new API was taken from the following article - https://docs.microsoft.com/en-us/sharepoint/dev/solution-guidance/supporting-and-in-file-and-folder-with-the-resourcepath-api

With these changes the special characters are now properly handled. I ran through all of the available actions (add, update, delete, move, copy, check in/out) and didn't notice any issues. If you see anything please let me know.

Thank you.

@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@jonathanmccann
Copy link
Collaborator Author

ci:test:sf

@jonathanmccann
Copy link
Collaborator Author

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: e25e86ad2836cc213fb43a621a260f8ce1151ec2

Sender Branch:

Branch Name: LPS-132128
Branch GIT ID: 0d2b4712ee700e0aa850eaf2cb251ce660fe4772

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 22 out of 22 jobs passed in 1 hour 21 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: e25e86ad2836cc213fb43a621a260f8ce1151ec2

Upstream Comparison:

Branch GIT ID: 37333acd16aab537b5330c8e4d36dc0aaab3b45a
Jenkins Build URL: Acceptance Upstream DXP (master) #1857

ci:test:stable - 9 out of 9 jobs PASSED
9 Successful Jobs:
ci:test:relevant - 22 out of 22 jobs PASSED
22 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

@adolfopa
Copy link
Collaborator

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

Skipping previously passed test suites:
ci:test:relevant
ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

All required test suite(s) passed.
Forwarding pull request to brianchandotcom.
Console

@liferay-continuous-integration
Copy link
Collaborator

Pull request has been successfully forwarded to brianchandotcom#101735
Console

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants