Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-134428 Process OpenGraph metatag values as templates #1999

Closed

Conversation

adolfopa
Copy link
Collaborator

@adolfopa adolfopa commented Jun 29, 2021

Tried and tested; ready to forward when everything green.

Repository owner deleted a comment from liferay-continuous-integration Jun 30, 2021
Repository owner deleted a comment from liferay-continuous-integration Jun 30, 2021
Repository owner deleted a comment from liferay-continuous-integration Jun 30, 2021
Repository owner deleted a comment from liferay-continuous-integration Jun 30, 2021
Repository owner deleted a comment from liferay-continuous-integration Jun 30, 2021
Repository owner deleted a comment from liferay-continuous-integration Jun 30, 2021
Repository owner deleted a comment from liferay-continuous-integration Jun 30, 2021
Repository owner deleted a comment from liferay-continuous-integration Jun 30, 2021
@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 821d682bb25be3232c78740d7f39240795ee941a

Sender Branch:

Branch Name: LPS-134428
Branch GIT ID: fbdc9207981cc064e4750acfd196130640d52a87

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 10 out of 10 jobs passed

❌ ci:test:relevant - 22 out of 26 jobs passed in 4 hours 7 minutes

Click here for more details.

This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result:

ci:reevaluate:1237401_7915

Base Branch:

Branch Name: master
Branch GIT ID: 821d682bb25be3232c78740d7f39240795ee941a

Upstream Comparison:

Branch GIT ID: 880952a2ef107ca6d98c9988da04a18fd51b5a55
Jenkins Build URL: Acceptance Upstream DXP (master) #2060

ci:test:stable - 10 out of 10 jobs PASSED
10 Successful Jobs:
ci:test:relevant - 22 out of 26 jobs PASSED
22 Successful Jobs:
For more details click here.

Failures unique to this pull:


Failures in common with acceptance upstream results at 880952a:
  1. test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0
    Job Results:

    3446 Tests Passed.
    11 Tests Failed.

    1. AXIS_VARIABLE=10,label_exp=!master #333589
      1. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError: 
        Unable to connect to a valid mail server. Please make sure one is properly configured: Couldn't connect to host, port: localhost, 25; timeout -1
        	at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)
        	at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)
        	at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)
        	at java.nio.file.Files.walkFileTree(Files.java:2670)
        	at java.nio.file.Files.walkFileTree(Files.java:2742)
        	at com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog(PortalLogAssertorTest.java:86)
        
    2. AXIS_VARIABLE=4,label_exp=!master #333589
      1. com.liferay.document.library.convert.test.DocumentLibraryConvertProcessTest.testMigrateDLAndDeleteFilesInSourceStore
        com.liferay.portal.convert.ConvertException: com.liferay.portal.kernel.exception.SystemException: java.lang.AssertionError: {level=ERROR, loggerName=org.hibernate.util.JDBCExceptionReporter, message=Packet for query is too large (22,204,365 > 4,194,304). You can change this value on the server by setting the 'max_allowed_packet' variable.
        	at com.liferay.portal.convert.BaseConvertProcess.convert(BaseConvertProcess.java:70)
        	at com.liferay.document.library.convert.test.DocumentLibraryConvertProcessTest.testMigrateAndCheckOldRepositoryFiles(DocumentLibraryConvertProcessTest.java:274)
        	at com.liferay.document.library.convert.test.DocumentLibraryConvertProcessTest.testMigrateDLAndDeleteFilesInSourceStore(DocumentLibraryConvertProcessTest.java:132)
        	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        	at java.lang.reflect.Method.invoke(Method.java:498)
        	at com.liferay.arquillian.extension.junit.bridge.server.TestExecutorRunnable$3.evaluate(TestExecutorRunnable.java:353)
        	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
        	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
        	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
        	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTe...
      2. com.liferay.document.library.convert.test.DocumentLibraryConvertProcessTest.testMigrateDLAndKeepFilesInSourceStore
        com.liferay.portal.convert.ConvertException: com.liferay.portal.kernel.exception.SystemException: java.lang.AssertionError: {level=ERROR, loggerName=com.liferay.document.library.internal.convert.document.library.DLFileVersionDLStoreConvertProcess, message=Unable to migrate 1
        	at com.liferay.portal.convert.BaseConvertProcess.convert(BaseConvertProcess.java:70)
        	at com.liferay.document.library.convert.test.DocumentLibraryConvertProcessTest.testMigrateAndCheckOldRepositoryFiles(DocumentLibraryConvertProcessTest.java:274)
        	at com.liferay.document.library.convert.test.DocumentLibraryConvertProcessTest.testMigrateDLAndKeepFilesInSourceStore(DocumentLibraryConvertProcessTest.java:137)
        	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        	at java.lang.reflect.Method.invoke(Method.java:498)
        	at com.liferay.arquillian.extension.junit.bridge.server.TestExecutorRunnable$3.evaluate(TestExecutorRunnable.java:353)
        	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
        	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
        	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
        	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
        	at com.liferay.portal.kernel.test.rule.AbstractTes...
      3. com.liferay.document.library.convert.test.DocumentLibraryConvertProcessTest.testMigrateDLWhenFileEntryInFolder
        com.liferay.portal.convert.ConvertException: com.liferay.portal.kernel.exception.SystemException: java.lang.AssertionError: {level=ERROR, loggerName=com.liferay.document.library.internal.convert.document.library.DLFileVersionDLStoreConvertProcess, message=Unable to migrate 1
        	at com.liferay.portal.convert.BaseConvertProcess.convert(BaseConvertProcess.java:70)
        	at com.liferay.document.library.convert.test.DocumentLibraryConvertProcessTest.testMigrateDL(DocumentLibraryConvertProcessTest.java:314)
        	at com.liferay.document.library.convert.test.DocumentLibraryConvertProcessTest.testMigrateDLWhenFileEntryInFolder(DocumentLibraryConvertProcessTest.java:151)
        	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        	at java.lang.reflect.Method.invoke(Method.java:498)
        	at com.liferay.arquillian.extension.junit.bridge.server.TestExecutorRunnable$3.evaluate(TestExecutorRunnable.java:353)
        	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
        	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
        	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
        	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
        	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTes...
      4. ...
    3. AXIS_VARIABLE=6,label_exp=!master #333589
      1. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError: 
        JSON storage adapter is deprecated, using default storage adapter
        	at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)
        	at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)
        	at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)
        	at java.nio.file.Files.walkFileTree(Files.java:2670)
        	at java.nio.file.Files.walkFileTree(Files.java:2742)
        	at com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog(PortalLogAssertorTest.java:86)
        
    4. AXIS_VARIABLE=9,label_exp=!master #333589
      1. com.liferay.layout.set.prototype.exportimport.test.LayoutSetPrototypeExportImportTest.classMethod
        org.springframework.orm.hibernate3.HibernateOptimisticLockingFailureException: Object of class [com.liferay.portal.model.impl.LayoutSetPrototypeImpl] with identifier [64659]: optimistic locking failed; nested exception is org.hibernate.StaleObjectStateException: Row was updated or deleted by another transaction (or unsaved-value mapping was incorrect): [com.liferay.portal.model.impl.LayoutSetPrototypeImpl#64659]
        	at org.springframework.orm.hibernate3.SessionFactoryUtils.convertHibernateAccessException(SessionFactoryUtils.java:699)
        	at org.springframework.orm.hibernate3.SpringSessionSynchronization.translateException(SpringSessionSynchronization.java:165)
        	at org.springframework.orm.hibernate3.SpringSessionSynchronization.beforeCommit(SpringSessionSynchronization.java:153)
        	at org.springframework.transaction.support.TransactionSynchronizationUtils.triggerBeforeCommit(TransactionSynchronizationUtils.java:96)
        	at org.springframework.transaction.support.AbstractPlatformTransactionManager.triggerBeforeCommit(AbstractPlatformTransactionManager.java:919)
        	at org.springframework.transaction.support.AbstractPlatformTransactionManager.processCommit(AbstractPlatformTransactionManager.java:727)
        	at org.springframework.transaction.support.AbstractPlatformTransactionManager.commit(AbstractPlatformTransactionManager.java:711)
        	at com.liferay.portal.spring.transaction.DefaultTransactionExecutor.commit(DefaultTransactionExecutor.java:41)
        	at com.liferay.portal.spring.transaction.BaseTransa...

@liferay-continuous-integration
Copy link
Collaborator

@Hanlf
Copy link
Collaborator

Hanlf commented Jul 2, 2021

The failure of ContentPagesWithMapping#MapManualURLToImageFragment has been fixed under LRCI-2329.
Re-run it.

@Hanlf
Copy link
Collaborator

Hanlf commented Jul 2, 2021

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

Skipping previously passed test suites:
ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 10 out of 10 jobs passed

✔️ ci:test:relevant - 24 out of 26 jobs passed in 2 hours 4 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 3d81186d60867919f897756ae9ce187d7d96abcf

Upstream Comparison:

Branch GIT ID: 575db32a0ec08afa3fd4897140c67de9321d6247
Jenkins Build URL: Acceptance Upstream DXP (master) #2063

ci:test:stable - 10 out of 10 jobs PASSED
10 Successful Jobs:
ci:test:relevant - 23 out of 26 jobs PASSED
23 Successful Jobs:
For more details click here.

This pull contains no unique failures.


Failures in common with acceptance upstream results at 575db32:
  1. test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0
    Job Results:

    3447 Tests Passed.
    10 Tests Failed.

    1. AXIS_VARIABLE=4,label_exp=!master #16684
      1. com.liferay.document.library.convert.test.DocumentLibraryConvertProcessTest.testMigrateDLAndDeleteFilesInSourceStore
        com.liferay.portal.convert.ConvertException: com.liferay.portal.kernel.exception.SystemException: java.lang.AssertionError: {level=ERROR, loggerName=org.hibernate.util.JDBCExceptionReporter, message=Packet for query is too large (22,204,365 > 4,194,304). You can change this value on the server by setting the 'max_allowed_packet' variable.
        	at com.liferay.portal.convert.BaseConvertProcess.convert(BaseConvertProcess.java:70)
        	at com.liferay.document.library.convert.test.DocumentLibraryConvertProcessTest.testMigrateAndCheckOldRepositoryFiles(DocumentLibraryConvertProcessTest.java:274)
        	at com.liferay.document.library.convert.test.DocumentLibraryConvertProcessTest.testMigrateDLAndDeleteFilesInSourceStore(DocumentLibraryConvertProcessTest.java:132)
        	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        	at java.lang.reflect.Method.invoke(Method.java:498)
        	at com.liferay.arquillian.extension.junit.bridge.server.TestExecutorRunnable$3.evaluate(TestExecutorRunnable.java:353)
        	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
        	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
        	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
        	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTe...
      2. com.liferay.document.library.convert.test.DocumentLibraryConvertProcessTest.testMigrateDLAndKeepFilesInSourceStore
        com.liferay.portal.convert.ConvertException: com.liferay.portal.kernel.exception.SystemException: java.lang.AssertionError: {level=ERROR, loggerName=com.liferay.document.library.internal.convert.document.library.DLFileVersionDLStoreConvertProcess, message=Unable to migrate 1
        	at com.liferay.portal.convert.BaseConvertProcess.convert(BaseConvertProcess.java:70)
        	at com.liferay.document.library.convert.test.DocumentLibraryConvertProcessTest.testMigrateAndCheckOldRepositoryFiles(DocumentLibraryConvertProcessTest.java:274)
        	at com.liferay.document.library.convert.test.DocumentLibraryConvertProcessTest.testMigrateDLAndKeepFilesInSourceStore(DocumentLibraryConvertProcessTest.java:137)
        	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        	at java.lang.reflect.Method.invoke(Method.java:498)
        	at com.liferay.arquillian.extension.junit.bridge.server.TestExecutorRunnable$3.evaluate(TestExecutorRunnable.java:353)
        	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
        	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
        	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
        	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
        	at com.liferay.portal.kernel.test.rule.AbstractTes...
      3. com.liferay.document.library.convert.test.DocumentLibraryConvertProcessTest.testMigrateDLWhenFileEntryInFolder
        com.liferay.portal.convert.ConvertException: com.liferay.portal.kernel.exception.SystemException: java.lang.AssertionError: {level=ERROR, loggerName=com.liferay.document.library.internal.convert.document.library.DLFileVersionDLStoreConvertProcess, message=Unable to migrate 1
        	at com.liferay.portal.convert.BaseConvertProcess.convert(BaseConvertProcess.java:70)
        	at com.liferay.document.library.convert.test.DocumentLibraryConvertProcessTest.testMigrateDL(DocumentLibraryConvertProcessTest.java:314)
        	at com.liferay.document.library.convert.test.DocumentLibraryConvertProcessTest.testMigrateDLWhenFileEntryInFolder(DocumentLibraryConvertProcessTest.java:151)
        	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        	at java.lang.reflect.Method.invoke(Method.java:498)
        	at com.liferay.arquillian.extension.junit.bridge.server.TestExecutorRunnable$3.evaluate(TestExecutorRunnable.java:353)
        	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
        	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
        	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
        	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
        	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTes...
      4. ...
    2. AXIS_VARIABLE=6,label_exp=!master #16684
      1. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError: 
        JSON storage adapter is deprecated, using default storage adapter
        	at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)
        	at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)
        	at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)
        	at java.nio.file.Files.walkFileTree(Files.java:2670)
        	at java.nio.file.Files.walkFileTree(Files.java:2742)
        	at com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog(PortalLogAssertorTest.java:86)
        
    3. AXIS_VARIABLE=9,label_exp=!master #16684
      1. com.liferay.layout.set.prototype.exportimport.test.LayoutSetPrototypeExportImportTest.classMethod
        org.springframework.orm.hibernate3.HibernateOptimisticLockingFailureException: Object of class [com.liferay.portal.model.impl.LayoutSetPrototypeImpl] with identifier [64820]: optimistic locking failed; nested exception is org.hibernate.StaleObjectStateException: Row was updated or deleted by another transaction (or unsaved-value mapping was incorrect): [com.liferay.portal.model.impl.LayoutSetPrototypeImpl#64820]
        	at org.springframework.orm.hibernate3.SessionFactoryUtils.convertHibernateAccessException(SessionFactoryUtils.java:699)
        	at org.springframework.orm.hibernate3.SpringSessionSynchronization.translateException(SpringSessionSynchronization.java:165)
        	at org.springframework.orm.hibernate3.SpringSessionSynchronization.beforeCommit(SpringSessionSynchronization.java:153)
        	at org.springframework.transaction.support.TransactionSynchronizationUtils.triggerBeforeCommit(TransactionSynchronizationUtils.java:96)
        	at org.springframework.transaction.support.AbstractPlatformTransactionManager.triggerBeforeCommit(AbstractPlatformTransactionManager.java:919)
        	at org.springframework.transaction.support.AbstractPlatformTransactionManager.processCommit(AbstractPlatformTransactionManager.java:727)
        	at org.springframework.transaction.support.AbstractPlatformTransactionManager.commit(AbstractPlatformTransactionManager.java:711)
        	at com.liferay.portal.spring.transaction.DefaultTransactionExecutor.commit(DefaultTransactionExecutor.java:41)
        	at com.liferay.portal.spring.transaction.BaseTransa...

@liferay-continuous-integration
Copy link
Collaborator

All required test suite(s) passed.
Forwarding pull request to brianchandotcom.
Console

@liferay-continuous-integration
Copy link
Collaborator

Pull request has been successfully forwarded to brianchandotcom#103880
Console

@liferay-continuous-integration
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants