Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-136280 #2113

Closed
wants to merge 2 commits into from
Closed

LPS-136280 #2113

wants to merge 2 commits into from

Conversation

holatuwol
Copy link

https://issues.liferay.com/browse/LPS-136280

Re-send of #2109

From @tototrinh:

I noticed that when an image has an alt attribute (this is the default when adding an Image on WC) or some other attribute, the image won't be able to display as an image tag.

I noticed that changing the pattern caused the issue as mentioned at LPS-79815. So I added a commit to fix it.

@liferay-continuous-integration
Copy link
Collaborator

Please only forward critical changes to Brian Chan during stabilization. Nonurgent changes should wait until the ongoing 7.4 DXP EP3 & CE GA3 release has been completed. For more details on the release timeline and status, see product-delivery.

@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@holatuwol
Copy link
Author

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 20 out of 22 jobs passed in 1 hour 26 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 7cb912889719a27e3dff73a0501155c0f36610f9

Upstream Comparison:

Branch GIT ID: 7cb912889719a27e3dff73a0501155c0f36610f9
Jenkins Build URL: Acceptance Upstream DXP (master) #2168

ci:test:stable - 9 out of 9 jobs PASSED
9 Successful Jobs:
ci:test:relevant - 19 out of 22 jobs PASSED
19 Successful Jobs:
For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at 7cb9128:
  2. test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0
    Job Results:

    610 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #409
      1. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError: 
Unable to find default image scaler
	at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)
	at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)
	at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)
	at java.nio.file.Files.walkFileTree(Files.java:2670)
	at java.nio.file.Files.walkFileTree(Files.java:2742)
	at com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog(PortalLogAssertorTest.java:86)

@liferay-continuous-integration
Copy link
Collaborator

@AliciaGarciaGarcia
Copy link
Collaborator

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

Skipping previously passed test suites:
ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 7cb912889719a27e3dff73a0501155c0f36610f9

Sender Branch:

Branch Name: LPS-136280
Branch GIT ID: cbb52980d1671394aaeb247a74e267a51ad0581a

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

All required test suite(s) passed.
Forwarding pull request to brianchandotcom.
Console

@liferay-continuous-integration liferay-continuous-integration mentioned this pull request Aug 2, 2021
Closed
@liferay-continuous-integration
Copy link
Collaborator

Pull request has been successfully forwarded to brianchandotcom#104997
Console

@liferay-continuous-integration
Copy link
Collaborator

@holatuwol holatuwol deleted the LPS-136280 branch January 22, 2024 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AliciaGarciaGarcia AliciaGarciaGarcia AliciaGarciaGarcia approved these changes

Assignees
No one assigned
Labels
🔍 backend review needed ci:test:relevant - success ci:test:sf - success ci:test:stable - success
Projects
None yet
Milestone
No milestone
4 participants
@holatuwol @liferay-continuous-integration @AliciaGarciaGarcia @ces-totrinh