Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-137504 Preprocess HTML to remove template variables #2151

Closed

Conversation

adolfopa
Copy link
Collaborator

No description provided.

brianwulbern and others added 5 commits August 16, 2021 13:55
As long as the resulting HTML is valid, the replacement we use doesn't
really matter. Using a valid HTML identifier to avoid issues.
@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@adolfopa
Copy link
Collaborator Author

ci:test:sf

@adolfopa
Copy link
Collaborator Author

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 5f33f077a3f08ca5c2e9872d6f9d42c234e47a37

Sender Branch:

Branch Name: LPS-137504
Branch GIT ID: f6b79c6e9b1b11fac8d9e868ec5d26bee613dd0e

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

@AliciaGarciaGarcia
Copy link
Collaborator

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

Skipping previously passed test suites:
ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:stable - 10 out of 11 jobs passed

❌ ci:test:relevant - 22 out of 26 jobs passed in 2 hours 13 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 5f33f077a3f08ca5c2e9872d6f9d42c234e47a37

Upstream Comparison:

Branch GIT ID: 5f33f077a3f08ca5c2e9872d6f9d42c234e47a37
Jenkins Build URL: Acceptance Upstream DXP (master) #2222

ci:test:stable - 10 out of 11 jobs PASSED
10 Successful Jobs:
ci:test:relevant - 22 out of 26 jobs PASSED
22 Successful Jobs:
For more details click here.

Failures unique to this pull:

  1. test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0
    Job Results:

    1217 Tests Passed.
    4 Tests Failed.

    1. AXIS_VARIABLE=1,label_exp=!master #16125
      1. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError: 
        Unable to register portal instance {mvccVersion=1, companyId=45083, accountId=45087, webId=h1lyKyIj, mx=h1lyKyIj.NI8, homeURL=, logoId=0, system=false, maxUsers=0, active=true}
        com.liferay.portal.kernel.exception.SystemException: java.sql.SQLSyntaxErrorException: Table 'CommerceOrder_x' already exists
        	at com.liferay.object.service.base.ObjectDefinitionLocalServiceBaseImpl.runSQL(ObjectDefinitionLocalServiceBaseImpl.java:556)
        	at com.liferay.object.service.impl.ObjectDefinitionLocalServiceImpl._createTable(ObjectDefinitionLocalServiceImpl.java:615)
        	at com.liferay.object.service.impl.ObjectDefinitionLocalServiceImpl._addObjectDefinition(ObjectDefinitionLocalServiceImpl.java:598)
        	at com.liferay.object.service.impl.ObjectDefinitionLocalServiceImpl.addSystemObjectDefinition(ObjectDefinitionLocalServiceImpl.java:181)
        	at com.liferay.object.service.impl.ObjectDefinitionLocalServiceImpl.addOrUpdateSystemObjectDefinition(ObjectDefinitionLocalServiceImpl.java:119)
        	at com.liferay.portal.spring.aop.AopMethodInvocationImpl.proceed(AopMethodInvocationImpl.java:50)
        	at com.liferay.portal.spring.transaction.TransactionInterceptor.invoke(TransactionInterceptor.java:69)
        	at com.liferay.portal.spring.aop.AopMethodInvocationImpl.proceed(AopMethodInvocationImpl.java:57)
        	at com.liferay.change.tracking.internal.aop.CTTransactionAdvice.invoke(CTTransactionAdvice.java:80)
        	at com.liferay.portal.spring.aop.AopMethodInvocationImpl.proceed(AopMethodInvocati...
    2. AXIS_VARIABLE=2,label_exp=!master #16125
      1. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError: 
        Unable to register portal instance {mvccVersion=1, companyId=60724, accountId=60728, webId=m1jPI71h, mx=m1jPI71h.35p, homeURL=, logoId=0, system=false, maxUsers=0, active=true}
        com.liferay.portal.kernel.exception.SystemException: java.sql.SQLSyntaxErrorException: Table 'CommerceOrder_x' already exists
        	at com.liferay.object.service.base.ObjectDefinitionLocalServiceBaseImpl.runSQL(ObjectDefinitionLocalServiceBaseImpl.java:556)
        	at com.liferay.object.service.impl.ObjectDefinitionLocalServiceImpl._createTable(ObjectDefinitionLocalServiceImpl.java:615)
        	at com.liferay.object.service.impl.ObjectDefinitionLocalServiceImpl._addObjectDefinition(ObjectDefinitionLocalServiceImpl.java:598)
        	at com.liferay.object.service.impl.ObjectDefinitionLocalServiceImpl.addSystemObjectDefinition(ObjectDefinitionLocalServiceImpl.java:181)
        	at com.liferay.object.service.impl.ObjectDefinitionLocalServiceImpl.addOrUpdateSystemObjectDefinition(ObjectDefinitionLocalServiceImpl.java:119)
        	at com.liferay.portal.spring.aop.AopMethodInvocationImpl.proceed(AopMethodInvocationImpl.java:50)
        	at com.liferay.portal.spring.transaction.TransactionInterceptor.invoke(TransactionInterceptor.java:69)
        	at com.liferay.portal.spring.aop.AopMethodInvocationImpl.proceed(AopMethodInvocationImpl.java:57)
        	at com.liferay.change.tracking.internal.aop.CTTransactionAdvice.invoke(CTTransactionAdvice.java:80)
        	at com.liferay.portal.spring.aop.AopMethodInvocationImpl.proceed(AopMethodInvocati...
    3. AXIS_VARIABLE=3,label_exp=!master #16125
      1. com.liferay.layout.set.prototype.exportimport.test.LayoutSetPrototypeExportImportTest.classMethod
        org.springframework.orm.hibernate3.HibernateOptimisticLockingFailureException: Object of class [com.liferay.portal.model.impl.LayoutSetPrototypeImpl] with identifier [42221]: optimistic locking failed; nested exception is org.hibernate.StaleObjectStateException: Row was updated or deleted by another transaction (or unsaved-value mapping was incorrect): [com.liferay.portal.model.impl.LayoutSetPrototypeImpl#42221]
        	at org.springframework.orm.hibernate3.SessionFactoryUtils.convertHibernateAccessException(SessionFactoryUtils.java:699)
        	at org.springframework.orm.hibernate3.SpringSessionSynchronization.translateException(SpringSessionSynchronization.java:165)
        	at org.springframework.orm.hibernate3.SpringSessionSynchronization.beforeCommit(SpringSessionSynchronization.java:153)
        	at org.springframework.transaction.support.TransactionSynchronizationUtils.triggerBeforeCommit(TransactionSynchronizationUtils.java:96)
        	at org.springframework.transaction.support.AbstractPlatformTransactionManager.triggerBeforeCommit(AbstractPlatformTransactionManager.java:919)
        	at org.springframework.transaction.support.AbstractPlatformTransactionManager.processCommit(AbstractPlatformTransactionManager.java:727)
        	at org.springframework.transaction.support.AbstractPlatformTransactionManager.commit(AbstractPlatformTransactionManager.java:711)
        	at com.liferay.portal.spring.transaction.DefaultTransactionExecutor.commit(DefaultTransactionExecutor.java:41)
        	at com.liferay.portal.spring.transaction.BaseTransa...
      2. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError: 
        Unable to connect to a valid mail server. Please make sure one is properly configured: Couldn't connect to host, port: localhost, 25; timeout -1
        	at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)
        	at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)
        	at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)
        	at java.nio.file.Files.walkFileTree(Files.java:2670)
        	at java.nio.file.Files.walkFileTree(Files.java:2742)
        	at com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog(PortalLogAssertorTest.java:86)
        

For upstream results, click here.

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 11 out of 11 jobs passed

❌ ci:test:relevant - 23 out of 26 jobs passed in 2 hours 49 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 5f33f077a3f08ca5c2e9872d6f9d42c234e47a37

Upstream Comparison:

Branch GIT ID: 5f33f077a3f08ca5c2e9872d6f9d42c234e47a37
Jenkins Build URL: Acceptance Upstream DXP (master) #2222

ci:test:stable - 11 out of 11 jobs PASSED
11 Successful Jobs:
ci:test:relevant - 23 out of 26 jobs PASSED
23 Successful Jobs:
For more details click here.

Failures unique to this pull:

  1. test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0
    Job Results:

    1217 Tests Passed.
    4 Tests Failed.

    1. AXIS_VARIABLE=1,label_exp=!master #6686
      1. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError: 
        Unable to register portal instance {mvccVersion=1, companyId=46377, accountId=46381, webId=FoxxaCda, mx=FoxxaCda.tOv, homeURL=, logoId=0, system=false, maxUsers=0, active=true}
        com.liferay.portal.kernel.exception.SystemException: java.sql.SQLSyntaxErrorException: Table 'User__x' already exists
        	at com.liferay.object.service.base.ObjectDefinitionLocalServiceBaseImpl.runSQL(ObjectDefinitionLocalServiceBaseImpl.java:556)
        	at com.liferay.object.service.impl.ObjectDefinitionLocalServiceImpl._createTable(ObjectDefinitionLocalServiceImpl.java:615)
        	at com.liferay.object.service.impl.ObjectDefinitionLocalServiceImpl._addObjectDefinition(ObjectDefinitionLocalServiceImpl.java:598)
        	at com.liferay.object.service.impl.ObjectDefinitionLocalServiceImpl.addSystemObjectDefinition(ObjectDefinitionLocalServiceImpl.java:181)
        	at com.liferay.object.service.impl.ObjectDefinitionLocalServiceImpl.addOrUpdateSystemObjectDefinition(ObjectDefinitionLocalServiceImpl.java:119)
        	at com.liferay.portal.spring.aop.AopMethodInvocationImpl.proceed(AopMethodInvocationImpl.java:50)
        	at com.liferay.portal.spring.transaction.TransactionInterceptor.invoke(TransactionInterceptor.java:69)
        	at com.liferay.portal.spring.aop.AopMethodInvocationImpl.proceed(AopMethodInvocationImpl.java:57)
        	at com.liferay.change.tracking.internal.aop.CTTransactionAdvice.invoke(CTTransactionAdvice.java:80)
        	at com.liferay.portal.spring.aop.AopMethodInvocationImpl.proceed(AopMethodInvocationImpl.j...
    2. AXIS_VARIABLE=2,label_exp=!master #6686
      1. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError: 
        Unable to register portal instance {mvccVersion=1, companyId=60624, accountId=60628, webId=XZUz7QSv, mx=XZUz7QSv.8oR, homeURL=, logoId=0, system=false, maxUsers=0, active=true}
        com.liferay.portal.kernel.exception.SystemException: java.sql.SQLSyntaxErrorException: Table 'CommerceOrder_x' already exists
        	at com.liferay.object.service.base.ObjectDefinitionLocalServiceBaseImpl.runSQL(ObjectDefinitionLocalServiceBaseImpl.java:556)
        	at com.liferay.object.service.impl.ObjectDefinitionLocalServiceImpl._createTable(ObjectDefinitionLocalServiceImpl.java:615)
        	at com.liferay.object.service.impl.ObjectDefinitionLocalServiceImpl._addObjectDefinition(ObjectDefinitionLocalServiceImpl.java:598)
        	at com.liferay.object.service.impl.ObjectDefinitionLocalServiceImpl.addSystemObjectDefinition(ObjectDefinitionLocalServiceImpl.java:181)
        	at com.liferay.object.service.impl.ObjectDefinitionLocalServiceImpl.addOrUpdateSystemObjectDefinition(ObjectDefinitionLocalServiceImpl.java:119)
        	at com.liferay.portal.spring.aop.AopMethodInvocationImpl.proceed(AopMethodInvocationImpl.java:50)
        	at com.liferay.portal.spring.transaction.TransactionInterceptor.invoke(TransactionInterceptor.java:69)
        	at com.liferay.portal.spring.aop.AopMethodInvocationImpl.proceed(AopMethodInvocationImpl.java:57)
        	at com.liferay.change.tracking.internal.aop.CTTransactionAdvice.invoke(CTTransactionAdvice.java:80)
        	at com.liferay.portal.spring.aop.AopMethodInvocationImpl.proceed(AopMethodInvocati...
    3. AXIS_VARIABLE=3,label_exp=!master #6686
      1. com.liferay.layout.set.prototype.exportimport.test.LayoutSetPrototypeExportImportTest.classMethod
        org.springframework.orm.hibernate3.HibernateOptimisticLockingFailureException: Object of class [com.liferay.portal.model.impl.LayoutSetPrototypeImpl] with identifier [42380]: optimistic locking failed; nested exception is org.hibernate.StaleObjectStateException: Row was updated or deleted by another transaction (or unsaved-value mapping was incorrect): [com.liferay.portal.model.impl.LayoutSetPrototypeImpl#42380]
        	at org.springframework.orm.hibernate3.SessionFactoryUtils.convertHibernateAccessException(SessionFactoryUtils.java:699)
        	at org.springframework.orm.hibernate3.SpringSessionSynchronization.translateException(SpringSessionSynchronization.java:165)
        	at org.springframework.orm.hibernate3.SpringSessionSynchronization.beforeCommit(SpringSessionSynchronization.java:153)
        	at org.springframework.transaction.support.TransactionSynchronizationUtils.triggerBeforeCommit(TransactionSynchronizationUtils.java:96)
        	at org.springframework.transaction.support.AbstractPlatformTransactionManager.triggerBeforeCommit(AbstractPlatformTransactionManager.java:919)
        	at org.springframework.transaction.support.AbstractPlatformTransactionManager.processCommit(AbstractPlatformTransactionManager.java:727)
        	at org.springframework.transaction.support.AbstractPlatformTransactionManager.commit(AbstractPlatformTransactionManager.java:711)
        	at com.liferay.portal.spring.transaction.DefaultTransactionExecutor.commit(DefaultTransactionExecutor.java:41)
        	at com.liferay.portal.spring.transaction.BaseTransa...
      2. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError: 
        Unable to register portal instance {mvccVersion=1, companyId=46806, accountId=46810, webId=VXTqiOhC, mx=VXTqiOhC.8A7, homeURL=, logoId=0, system=false, maxUsers=0, active=true}
        com.liferay.portal.kernel.exception.SystemException: java.sql.SQLSyntaxErrorException: Table 'CommerceOrder_x' already exists
        	at com.liferay.object.service.base.ObjectDefinitionLocalServiceBaseImpl.runSQL(ObjectDefinitionLocalServiceBaseImpl.java:556)
        	at com.liferay.object.service.impl.ObjectDefinitionLocalServiceImpl._createTable(ObjectDefinitionLocalServiceImpl.java:615)
        	at com.liferay.object.service.impl.ObjectDefinitionLocalServiceImpl._addObjectDefinition(ObjectDefinitionLocalServiceImpl.java:598)
        	at com.liferay.object.service.impl.ObjectDefinitionLocalServiceImpl.addSystemObjectDefinition(ObjectDefinitionLocalServiceImpl.java:181)
        	at com.liferay.object.service.impl.ObjectDefinitionLocalServiceImpl.addOrUpdateSystemObjectDefinition(ObjectDefinitionLocalServiceImpl.java:119)
        	at com.liferay.portal.spring.aop.AopMethodInvocationImpl.proceed(AopMethodInvocationImpl.java:50)
        	at com.liferay.portal.spring.transaction.TransactionInterceptor.invoke(TransactionInterceptor.java:69)
        	at com.liferay.portal.spring.aop.AopMethodInvocationImpl.proceed(AopMethodInvocationImpl.java:57)
        	at com.liferay.change.tracking.internal.aop.CTTransactionAdvice.invoke(CTTransactionAdvice.java:80)
        	at com.liferay.portal.spring.aop.AopMethodInvocationImpl.proceed(AopMethodInvocati...

For upstream results, click here.

@AliciaGarciaGarcia
Copy link
Collaborator

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 11 out of 11 jobs passed

✔️ ci:test:relevant - 23 out of 26 jobs passed in 2 hours 4 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 6154b45274e3f51a84b3c408302ec150b137ea3e

Upstream Comparison:

Branch GIT ID: 6154b45274e3f51a84b3c408302ec150b137ea3e
Jenkins Build URL: Acceptance Upstream DXP (master) #2223

ci:test:stable - 11 out of 11 jobs PASSED
11 Successful Jobs:
ci:test:relevant - 22 out of 26 jobs PASSED
22 Successful Jobs:
For more details click here.

This pull contains no unique failures.


Failures in common with acceptance upstream results at 6154b45:
  1. test-portal-acceptance-pullrequest-batch(master)/central-requirements-jdk8/0
    Job Results:

    7 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #391529
      1. com.liferay.portal.modules.ModulesStructureTest.testScanBuildScripts
        junit.framework.AssertionFailedError: Missing modules/apps/headless/headless-portal-instances/headless-portal-instances-client/build.gradle
        	at com.liferay.portal.modules.ModulesStructureTest$2.preVisitDirectory(ModulesStructureTest.java:293)
        	at com.liferay.portal.modules.ModulesStructureTest$2.preVisitDirectory(ModulesStructureTest.java:171)
        	at java.nio.file.Files.walkFileTree(Files.java:2677)
        	at java.nio.file.Files.walkFileTree(Files.java:2742)
        	at com.liferay.portal.modules.ModulesStructureTest.testScanBuildScripts(ModulesStructureTest.java:169)
        
  2. test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0
    Job Results:

    1217 Tests Passed.
    4 Tests Failed.

    1. AXIS_VARIABLE=3,label_exp=!master #233405
      1. com.liferay.layout.set.prototype.exportimport.test.LayoutSetPrototypeExportImportTest.classMethod
        org.springframework.orm.hibernate3.HibernateOptimisticLockingFailureException: Object of class [com.liferay.portal.model.impl.LayoutSetPrototypeImpl] with identifier [42280]: optimistic locking failed; nested exception is org.hibernate.StaleObjectStateException: Row was updated or deleted by another transaction (or unsaved-value mapping was incorrect): [com.liferay.portal.model.impl.LayoutSetPrototypeImpl#42280]
        	at org.springframework.orm.hibernate3.SessionFactoryUtils.convertHibernateAccessException(SessionFactoryUtils.java:699)
        	at org.springframework.orm.hibernate3.SpringSessionSynchronization.translateException(SpringSessionSynchronization.java:165)
        	at org.springframework.orm.hibernate3.SpringSessionSynchronization.beforeCommit(SpringSessionSynchronization.java:153)
        	at org.springframework.transaction.support.TransactionSynchronizationUtils.triggerBeforeCommit(TransactionSynchronizationUtils.java:96)
        	at org.springframework.transaction.support.AbstractPlatformTransactionManager.triggerBeforeCommit(AbstractPlatformTransactionManager.java:919)
        	at org.springframework.transaction.support.AbstractPlatformTransactionManager.processCommit(AbstractPlatformTransactionManager.java:727)
        	at org.springframework.transaction.support.AbstractPlatformTransactionManager.commit(AbstractPlatformTransactionManager.java:711)
        	at com.liferay.portal.spring.transaction.DefaultTransactionExecutor.commit(DefaultTransactionExecutor.java:41)
        	at com.liferay.portal.spring.transaction.BaseTransa...
      2. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError: 
        Unable to connect to a valid mail server. Please make sure one is properly configured: Couldn't connect to host, port: localhost, 25; timeout -1
        	at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)
        	at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)
        	at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)
        	at java.nio.file.Files.walkFileTree(Files.java:2670)
        	at java.nio.file.Files.walkFileTree(Files.java:2742)
        	at com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog(PortalLogAssertorTest.java:86)
        

@liferay-continuous-integration
Copy link
Collaborator

@AliciaGarciaGarcia
Copy link
Collaborator

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

Skipping previously passed test suites:
ci:test:relevant
ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

All required test suite(s) passed.
Forwarding pull request to brianchandotcom.
Console

@liferay-continuous-integration
Copy link
Collaborator

Pull request has been successfully forwarded to brianchandotcom#105675
Console

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants