Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-140315 It is not possible to edit the header image alt text on a blog post #2361

Closed
wants to merge 2 commits into from
Closed

LPS-140315 It is not possible to edit the header image alt text on a blog post #2361

wants to merge 2 commits into from

Conversation

boton
Copy link
Collaborator

@boton boton commented Oct 8, 2021

Bug: https://issues.liferay.com/browse/LPS-140315

This PR adds a description to the cover background image on a blog entry using the cover image caption.

We can improve it in the future by using the DM file description (adding Documents
& Media file description to blogs images) or adding a field in the blog entry.

@liferay-continuous-integration
Copy link
Collaborator

Please only forward necessary changes to Brian Chan during stabilization. Nonurgent changes should wait until the ongoing DXP 7.4 GA1 and Portal 7.4 GA4 release has been completed. For more details on the release timeline and status, see product-delivery.

@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@boton
Copy link
Collaborator Author

boton commented Oct 8, 2021 •
edited

@adolfopa @AliciaGarciaGarcia I'm not sure if this is the best way 6a1cb30 to add conditional attributes at HTML elements in JSP. Please can you check it?

@boton
Copy link
Collaborator Author

boton commented Oct 8, 2021

ci:test:sf

@boton
Copy link
Collaborator Author

boton commented Oct 8, 2021

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: f0aba919aadce917de35582df7a4339ac8a79f92

Sender Branch:

Branch Name: LPS-140315-bug-blogs-cover-image-without-alt-text
Branch GIT ID: 6a1cb30b938aaac2fa7733e510f079dcc3f7a640

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 10 out of 10 jobs passed

❌ ci:test:relevant - 22 out of 24 jobs passed in 1 hour 45 minutes

Click here for more details.

This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result:

ci:reevaluate:1257401_554

Base Branch:

Branch Name: master
Branch GIT ID: f0aba919aadce917de35582df7a4339ac8a79f92

Upstream Comparison:

Branch GIT ID: 2ef2546d5f8ce61aaecc9898bdd386cc6f29aae1
Jenkins Build URL: Acceptance Upstream DXP (master) #2414

ci:test:stable - 10 out of 10 jobs PASSED
10 Successful Jobs:
ci:test:relevant - 22 out of 24 jobs PASSED
22 Successful Jobs:
For more details click here.

Failures unique to this pull:

For upstream results, click here.

@liferay-continuous-integration
Copy link
Collaborator

@boton boton force-pushed the LPS-140315-bug-blogs-cover-image-without-alt-text branch from 6a1cb30 to eaef448 Compare October 8, 2021 14:50
@liuxingye
Copy link
Collaborator

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 10 out of 10 jobs passed

❌ ci:test:relevant - 22 out of 24 jobs passed in 1 hour 36 minutes

Click here for more details.

This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result:

ci:reevaluate:1297401_438

Base Branch:

Branch Name: master
Branch GIT ID: 697d9c132831ad7d1a19e35b5dea8de56f831877

Upstream Comparison:

Branch GIT ID: fbc6889b98c1c40185f6b136e0554be917c310b5
Jenkins Build URL: Acceptance Upstream DXP (master) #2425

ci:test:stable - 10 out of 10 jobs PASSED
10 Successful Jobs:
ci:test:relevant - 22 out of 24 jobs PASSED
22 Successful Jobs:
For more details click here.

Failures unique to this pull:

  1. test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0
    Job Results:

    881 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0 #99
      1. com.liferay.blogs.service.test.BlogsEntryServiceTest.testGetGroupEntriesWithoutViewPermission
        java.lang.AssertionError: [{"mvccVersion": 1, "uuid": "d0359a82-06c7-00f0-4e8e-ce36c0667bc6", "externalReferenceCode": "64573", "entryId": 64573, "groupId": 64547, "companyId": 61394, "userId": 63660, "userName": "5UF4wU1D JUF4rcNb", "createDate": "2021-10-12 01:25:21.369", "modifiedDate": "2021-10-12 01:25:21.375", "title": "3", "subtitle": "", "urlTitle": "64573", "description": "", "content": "xzoRNhD4", "displayDate": "2021-10-12 01:25:21.361", "allowPingbacks": true, "allowTrackbacks": true, "trackbacks": "", "coverImageCaption": "", "coverImageFileEntryId": 0, "coverImageURL": "", "smallImage": false, "smallImageFileEntryId": 0, "smallImageId": 0, "smallImageURL": "", "lastPublishDate": null, "status": 0, "statusByUserId": 63660, "statusByUserName": "5UF4wU1D JUF4rcNb", "statusDate": "2021-10-12 01:25:21.375"}] expected:<2> but was:<1>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)
	at org.junit.Assert.assertEquals(Assert.java:647)
	at com.liferay.blogs.service.test.BlogsEntryServiceTest.testGetGroupEntriesWithoutViewPermission(BlogsEntryServiceTest.java:937)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at com.liferay.arquillian.extension.junit.bridge.server.TestExecutorRunnable$3...

For upstream results, click here.

@liferay-continuous-integration
Copy link
Collaborator

@boton
Copy link
Collaborator Author

boton commented Oct 13, 2021

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 10 out of 10 jobs passed

✔️ ci:test:relevant - 24 out of 24 jobs passed in 2 hours 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 05e1f5030d43bb6c1bf943c483fd50aae7a75a23

Upstream Comparison:

Branch GIT ID: 05e1f5030d43bb6c1bf943c483fd50aae7a75a23
Jenkins Build URL: Acceptance Upstream DXP (master) #2433

ci:test:stable - 10 out of 10 jobs PASSED
10 Successful Jobs:
ci:test:relevant - 24 out of 24 jobs PASSED
24 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

@adolfopa
Copy link
Collaborator

@AliciaGarciaGarcia @boton Is there anything else to do here? can this be forwarded?

@boton
Copy link
Collaborator Author

boton commented Oct 14, 2021 •
edited

I’m not sure if is good enough to forward it because we only adding redundant information to screen readers ¯\_(ツ)_/¯

@rolandpakai
Copy link

Hi @adolfopa

could you please forward this PR?
The customer ticket has dependecie on it and i would like to move forward on it too.

Thanks, Roland

@adolfopa
Copy link
Collaborator

Yes, I see no problem forwarding this.

@adolfopa
Copy link
Collaborator

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

Skipping previously passed test suites:
ci:test:relevant
ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

All required test suite(s) passed.
Forwarding pull request to brianchandotcom.
Console

Closed
@liferay-continuous-integration
Copy link
Collaborator

Pull request has been successfully forwarded to brianchandotcom#108820
Console

@boton boton deleted the LPS-140315-bug-blogs-cover-image-without-alt-text branch January 26, 2022 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AliciaGarciaGarcia AliciaGarciaGarcia AliciaGarciaGarcia left review comments

Assignees
No one assigned
Labels
🔍 backend review needed ci:test:relevant - success ci:test:sf - success ci:test:stable - success
Projects
None yet
Milestone
No milestone
6 participants
@boton @liferay-continuous-integration @liuxingye @adolfopa @rolandpakai @AliciaGarciaGarcia