Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TS] LPS-147498 Revert "LPS-143165 Obtain urlTitleMap from unique title produced by friendlyURLEntryLocalService" #2822

Conversation

ericyanLr
Copy link

Hi Team,

Notes from @noornajj

This reverts commit 29c2735.

https://issues.liferay.com/browse/LPS-147498

The issue here is that the friendly URL gets incremented when being updated to another layout's old friendly URL. The expected behavior is it should show a UI error that the friendly URL is being used.

To fix the issue I reverted LPS-143165. This fix is no longer reproducible and therefore the changes are no longer needed. See discussion in PTR-2863

Please let us know if you have any questions.
Thanks!

…oduced by friendlyURLEntryLocalService"

This reverts commit 29c2735.
@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@ericyanLr
Copy link
Author

ci:test:sf

@ericyanLr
Copy link
Author

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 27c9e3845addd7bc674810b1ee258e2df5597105

Sender Branch:

Branch Name: pr-265_noornajj_LPS-147498
Branch GIT ID: 6f7e5104946b331a23315c9723174aebe123377e

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 10 out of 10 jobs passed

✔️ ci:test:relevant - 11 out of 11 jobs passed in 1 hour 15 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 27c9e3845addd7bc674810b1ee258e2df5597105

Upstream Comparison:

Branch GIT ID: 6697a2d0524bdfae21fd98804118b831717a9365
Jenkins Build URL: Acceptance Upstream DXP (master) #3021

ci:test:stable - 10 out of 10 jobs PASSED
10 Successful Jobs:
ci:test:relevant - 11 out of 11 jobs PASSED
11 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

@adolfopa adolfopa self-requested a review March 14, 2022 16:14
@adolfopa
Copy link
Collaborator

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

Skipping previously passed test suites:
ci:test:relevant
ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

All required test suite(s) passed.
Forwarding pull request to brianchandotcom.
Console

@liferay-continuous-integration
Copy link
Collaborator

Pull request has been successfully forwarded to brianchandotcom#114608
Console

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants