Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-136235 Reuse methods #14

Closed
wants to merge 5 commits into from

Conversation

gabrielwas
Copy link
Collaborator

No description provided.

@liferay-continuous-integration
Copy link
Collaborator

Please only forward critical changes to Brian Chan during stabilization. Nonurgent changes should wait until the ongoing 7.4 DXP EP3 & CE GA3 release has been completed. For more details on the release timeline and status, see product-delivery.

@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@gabrielwas
Copy link
Collaborator Author

ci:test:sf

@gabrielwas
Copy link
Collaborator Author

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 6622dc1d1d269468437da9efc126bac5be5bdec2

Sender Branch:

Branch Name: LPS-136235
Branch GIT ID: 855c5a5bb632cf264ab13f5208173e4d589c2c32

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 9 out of 9 jobs passed

❌ ci:test:relevant - 18 out of 21 jobs passed in 1 hour 42 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 6622dc1d1d269468437da9efc126bac5be5bdec2

Upstream Comparison:

Branch GIT ID: 6622dc1d1d269468437da9efc126bac5be5bdec2
Jenkins Build URL: Acceptance Upstream DXP (master) #2152

ci:test:stable - 9 out of 9 jobs PASSED
9 Successful Jobs:
ci:test:relevant - 18 out of 21 jobs PASSED
18 Successful Jobs:
For more details click here.

Failures unique to this pull:

  1. test-portal-acceptance-pullrequest-batch(master)/semantic-versioning-jdk8/0
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #331998
      clean-up-java-processes:
         [delete] Deleting: /opt/dev/projects/github/liferay-portal/clean_up_java_processes.sh
      [stopwatch] [run.batch.test.setup: 31:35.878 sec]
           [echo] run.batch.test.action.start.timestamp: 07-25-2021 07:08:07:784 PDT
           [echo] Checking for baseline log files.
           [echo] 
           [echo] ##
           [echo] ## /opt/dev/projects/github/liferay-portal/baseline-reports/portal-impl-7.log
           [echo] ##
           [echo] 
      [beanshell] [Baseline Warning] Bundle Version Change Recommended: 7.8.8
      [beanshell] 
           [echo] 
           [echo] ##
           [echo] ## /opt/dev/projects/github/liferay-portal/baseline-reports/portal-kernel-12.log
           [echo] ##
           [echo] 
      [beanshell] [Baseline Warning] Bundle Version Change Recommended: 12.2.2
      [beanshell] 
      [stopwatch] [run.batch.test.action: 14.455 sec]
           [echo] Semantic versioning is incorrect.
            [get] Getting: http://test-1-23/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master/331998//consoleText
            [get] To: /opt/dev/projects/github/liferay-portal/20210725070822239.txt
         [delete] Deleting: /opt/dev/projects/github/liferay-portal/20210725070822239.txt
         [delete] Deleting: /opt/dev/projects/github/liferay-portal/null649268057.properties

Failures in common with acceptance upstream results at 6622dc1:
  1. test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0
    Job Results:

    590 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=1,label_exp=!master #342329
      1. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError: 
        Unable to connect to a valid mail server. Please make sure one is properly configured: Couldn't connect to host, port: localhost, 25; timeout -1
        	at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)
        	at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)
        	at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)
        	at java.nio.file.Files.walkFileTree(Files.java:2670)
        	at java.nio.file.Files.walkFileTree(Files.java:2742)
        	at com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog(PortalLogAssertorTest.java:86)
        

@gabrielwas
Copy link
Collaborator Author

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:stable - 1 out of 9 jobs passed

❌ ci:test:relevant - 1 out of 21 jobs passed in 15 hours 23 minutes

Click here for more details.

This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result:

ci:reevaluate:1177401_7914

Base Branch:

Branch Name: master
Branch GIT ID: 50ec3cad83bd9f0a1b2067c56c772c83b84f51c7

Upstream Comparison:

Branch GIT ID: 6622dc1d1d269468437da9efc126bac5be5bdec2
Jenkins Build URL: Acceptance Upstream DXP (master) #2152

ci:test:stable - 1 out of 9 jobs PASSED
1 Successful Jobs:
ci:test:relevant - 1 out of 21 jobs PASSED

20 Failed Jobs:

1 Successful Jobs:
For more details click here.

Failures unique to this pull:

  1. ...

For upstream results, click here.

@liferay-continuous-integration
Copy link
Collaborator

@gabrielwas
Copy link
Collaborator Author

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 20 out of 21 jobs passed in 3 hours 7 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 5d67ea8c2b3b9a21f20ba2b77a1b5ea72ed5c809

Upstream Comparison:

Branch GIT ID: 50ec3cad83bd9f0a1b2067c56c772c83b84f51c7
Jenkins Build URL: Acceptance Upstream DXP (master) #2153

ci:test:stable - 9 out of 9 jobs PASSED
9 Successful Jobs:
ci:test:relevant - 19 out of 21 jobs PASSED
19 Successful Jobs:
For more details click here.

This pull contains no unique failures.


Failures in common with acceptance upstream results at 50ec3ca:
  1. test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8/0
    Job Results:

    3 Tests Passed.
    2 Tests Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #477957
      1. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanOSGiLog
        junit.framework.AssertionFailedError: 
        Portal log assert failure, OSGi log found: /opt/dev/projects/github/liferay-portal/bundles/osgi/state/1627365243706.log:
        !SESSION 2021-07-27 05:54:30.330 -----------------------------------------------
        eclipse.buildId=unknown
        java.version=1.8.0_121
        java.vendor=Oracle Corporation
        BootLoader constants: OS=linux, ARCH=x86_64, WS=gtk, NL=en_US
        

        !ENTRY com.liferay.image.service 4 0 2021-07-27 05:54:30.331
        !MESSAGE FrameworkEvent ERROR
        !STACK 0
        org.osgi.framework.BundleException: Could not resolve module: com.liferay.image.service [1114]
        Unresolved requirement: Import-Package: com.liferay.commerce.model; version="[8.0.0,9.0.0)"

        at org.eclipse.osgi.container.Module.start(Module.java:444)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1682)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1662)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1624)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1555)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1)
        at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
        at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:340)
        
        
        at com.liferay.portal.log.assertor...</code></pre></div></li><li><div><a href="https://test-1-14.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master/477957//testReport/com.liferay.portal.log.assertor/PortalLogAssertorTest/testScanXMLLog">com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog</a><pre><code>junit.framework.AssertionFailedError: 
        

        FrameworkEvent ERROR
        org.osgi.framework.BundleException: Could not resolve module: com.liferay.image.service [1114]
        Unresolved requirement: Import-Package: com.liferay.commerce.model; version="[8.0.0,9.0.0)"

        at org.eclipse.osgi.container.Module.start(Module.java:444)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1682)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1662)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1624)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1555)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1)
        at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
        at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:340)
        
        at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)
        at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)
        at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)
        at java.nio.file.Files.walkFileTree(Files.java:2670)
        at java.nio.file.Files.walkFileTree(Files.java:2742)
        at com.liferay.portal.log.assertor.Portal...</code></pre></div></li></ol></div></li></ol></div></li></ol></details></details></html>
        

@liferay-continuous-integration
Copy link
Collaborator

@gabrielwas
Copy link
Collaborator Author

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

Skipping previously passed test suites:
ci:test:relevant
ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

All required test suite(s) passed.
Forwarding pull request to brianchandotcom.
Console

@liferay-continuous-integration
Copy link
Collaborator

Pull request has been successfully forwarded to brianchandotcom#104820
Console

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants