Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-144391 search-experiences-web: Return full element JSON when clicking on 'View Element JSON' #379

Closed
wants to merge 3 commits into from
Closed

LPS-144391 search-experiences-web: Return full element JSON when clicking on 'View Element JSON' #379

wants to merge 3 commits into from

Conversation

oliv-yu
Copy link
Collaborator

@oliv-yu oliv-yu commented Mar 29, 2022

https://issues.liferay.com/browse/LPS-144391 - "View Element JSON" should return the full JSON of the Element (with replaced variables)

Notes:

  • Created the util getSXPElementJSON inside util.js so as not to clutter the SXPElement component
  • Ended up alphabetizing some of the util functions related to elements and configurations

Thanks for taking a look!

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:search
  •     ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: fc0df1a3be0b5b6d4a1ed1680580676457a03816

Sender Branch:

Branch Name: LPS-144391-view-element-JSON
Branch GIT ID: bedce2cee3f6a8c021ecd95f8ee26da33df5afa4

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@oliv-yu oliv-yu requested a review from thektan March 29, 2022 21:59
@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:search - 11 out of 14 jobs passed in 1 hour 35 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: fc0df1a3be0b5b6d4a1ed1680580676457a03816

Upstream Comparison:

Branch GIT ID: fc0df1a3be0b5b6d4a1ed1680580676457a03816
Jenkins Build URL: Acceptance Upstream DXP (master) #3070

ci:test:search - 11 out of 14 jobs PASSED
11 Successful Jobs:
For more details click here.

Failures unique to this pull:

  1. test-portal-acceptance-pullrequest-batch(master)/modules-unit-jdk8/0
    Job Results:

    1235 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0 #42074
      1. com.liferay.portal.search.elasticsearch7.internal.pagination.ElasticsearchPaginationTest.testMiddleOne
        java.lang.AssertionError: {docs={}, length=0, query=null] expected:<20> but was:<0>
  at org.junit.Assert.fail(Assert.java:88)
  at org.junit.Assert.failNotEquals(Assert.java:834)
  at org.junit.Assert.assertEquals(Assert.java:645)
  at com.liferay.portal.search.test.util.pagination.BasePaginationTestCase.lambda$_assertPagination$0(BasePaginationTestCase.java:151)
  at com.liferay.portal.search.test.util.IdempotentRetryAssert.retryAssert(IdempotentRetryAssert.java:43)
  at com.liferay.portal.search.test.util.IdempotentRetryAssert.retryAssert(IdempotentRetryAssert.java:29)
  at com.liferay.portal.search.test.util.pagination.BasePaginationTestCase._assertPagination(BasePaginationTestCase.java:141)
  at com.liferay.portal.search.test.util.pagination.BasePaginationTestCase.testMiddleOne(BasePaginationTestCase.java:94)
  at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
  at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
  at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
  at java.lang.reflect.Method.invoke(Method.java:498)
  at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
  at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
  at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
  at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
  at org.junit.internal.runners.statement...
Failures in common with acceptance upstream results at fc0df1a:
  1. test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0
    Job Results:

    2110 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=4 #28581
      1. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError: 
Duplicate entry '20100-com.liferay.portal.kernel.model.LayoutPrototype-4-com.life' for key 'IX_A9FF4B2C'
  at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)
  at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)
  at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)
  at java.nio.file.Files.walkFileTree(Files.java:2670)
  at java.nio.file.Files.walkFileTree(Files.java:2742)
  at com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog(PortalLogAssertorTest.java:86)
Test bundle downloads:

@liferay-continuous-integration
Copy link
Collaborator

thektan
thektan requested changes Mar 29, 2022
View reviewed changes
Copy link
Collaborator

@thektan thektan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just that one small doc correction.

Looks good though! I'm definitely in favor of this specific function with clear documentation of its purpose. I also appreciate you putting the formatting changes in a separate commit. 💯

...-experiences-web/src/main/resources/META-INF/resources/sxp_blueprint_admin/js/utils/utils.js Outdated Show resolved Hide resolved
@thektan
Copy link
Collaborator

thektan commented Mar 29, 2022

@oliv-yu You can run ci:forward once you make that doc change. Thanks!

@oliv-yu oliv-yu changed the title LPS-144391 search-experiences-web: Return full element JSON when clicking on 'Element Template (JSON)' LPS-144391 search-experiences-web: Return full element JSON when clicking on 'View Element JSON' Mar 29, 2022
@oliv-yu
Copy link
Collaborator Author

oliv-yu commented Mar 30, 2022

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 3d2d025eeb12a377a165bc6479d9ed806372e07c

Sender Branch:

Branch Name: LPS-144391-view-element-JSON
Branch GIT ID: 3e3f67145b0ed9b6fe5c09744dbc36212c2d94b1

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 25 out of 25 jobs passed

✔️ ci:test:relevant - 26 out of 26 jobs passed in 1 hour 40 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 3d2d025eeb12a377a165bc6479d9ed806372e07c

Upstream Comparison:

Branch GIT ID: fc0df1a3be0b5b6d4a1ed1680580676457a03816
Jenkins Build URL: Acceptance Upstream DXP (master) #3070

ci:test:stable - 25 out of 25 jobs PASSED
25 Successful Jobs:
ci:test:relevant - 26 out of 26 jobs PASSED
26 Successful Jobs:
For more details click here.
Test bundle downloads:

@liferay-continuous-integration
Copy link
Collaborator

All required test suite(s) passed.
Forwarding pull request to brianchandotcom.
Console

Closed
@liferay-continuous-integration
Copy link
Collaborator

Pull request has been successfully forwarded to brianchandotcom#115390
Console

@liferay-continuous-integration
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thektan thektan thektan approved these changes

Assignees
No one assigned
Labels
ci:test:relevant - success ci:test:search - failure ci:test:sf - success ci:test:stable - success
Projects
None yet
Milestone
No milestone
3 participants
@oliv-yu @liferay-continuous-integration @thektan