LPS-125851 & LPS-128383 Using system settings only to completely disable the feature #1272

4lejandrito · 2021-06-10T10:44:38Z

New behaviour:

Api Key and Strategy will only be configurable at instance level. Default values will be set via System Settings -> Virtual Instance Scope.
System settings will only have the Enabled check.
If the feature is disabled in system settings the instance settings configurations disappear.
The Configure Google Page speed button will take you to instance settings.

liferay-continuous-integration · 2021-06-10T10:44:41Z

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

4lejandrito · 2021-06-10T10:49:50Z

ci:forward

liferay-continuous-integration · 2021-06-10T10:49:53Z

CI is automatically triggering the following test suites:

ci:test:relevant
ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

ci:test:relevant
ci:test:sf
ci:test:stable

liferay-continuous-integration · 2021-06-10T10:54:00Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: cbb73af51883b8ddb6925f2c6e6a1af4013dcfd2

Sender Branch:

Branch Name: LPS-125851-LPS-128383-2
Branch GIT ID: d74de31f8c894a3b4f59c3bc23c6d0d4cd06b494

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2021-06-10T10:55:36Z

Jenkins Build:test-portal-source-format#3736

Jenkins Report:jenkins-report.html

Jenkins Suite:sf

Pull Request:liferay-tango#1272

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:sf - 4lejandrito > liferay-tango - PR#1272 - 2021-06-10[03:50:51]

Testray Importer:publish-testray-report#1086

liferay-continuous-integration · 2021-06-10T17:09:28Z

✔️ ci:test:stable - 10 out of 10 jobs passed

❌ ci:test:relevant - 23 out of 25 jobs passed in 4 hours 46 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: cbb73af51883b8ddb6925f2c6e6a1af4013dcfd2

Upstream Comparison:

Branch GIT ID: cbb73af51883b8ddb6925f2c6e6a1af4013dcfd2
Jenkins Build URL: Acceptance Upstream DXP (master) #1973

ci:test:stable - 10 out of 10 jobs PASSED

10 Successful Jobs:

ci:test:relevant - 23 out of 25 jobs PASSED

2 Failed Jobs:

23 Successful Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0

Job Results:

1205 Tests Passed.
2 Tests Failed.

AXIS_VARIABLE=2,label_exp=!master #387940

com.liferay.layout.reports.web.internal.portlet.action.test.LayoutReportsDataMVCResourceCommandTest.testGetData

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertTrue(Assert.java:53)
	at com.liferay.layout.reports.web.internal.portlet.action.test.LayoutReportsDataMVCResourceCommandTest.testGetData(LayoutReportsDataMVCResourceCommandTest.java:159)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at com.liferay.arquillian.extension.junit.bridge.server.TestExecutorRunnable$3.evaluate(TestExecutorRunnable.java:353)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
	at org.junit.rules...

com.liferay.layout.reports.web.internal.portlet.action.test.LayoutReportsDataMVCResourceCommandTest.testGetDataWithLayoutTypeAssetDisplay

java.lang.AssertionError
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertTrue(Assert.java:53)
	at com.liferay.layout.reports.web.internal.portlet.action.test.LayoutReportsDataMVCResourceCommandTest.testGetDataWithLayoutTypeAssetDisplay(LayoutReportsDataMVCResourceCommandTest.java:296)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at com.liferay.arquillian.extension.junit.bridge.server.TestExecutorRunnable$3.evaluate(TestExecutorRunnable.java:353)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.ja...

Failures in common with acceptance upstream results at cbb73af:

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0

Job Results:

1205 Tests Passed.
2 Tests Failed.

AXIS_VARIABLE=3,label_exp=!master #387940

com.liferay.layout.set.prototype.exportimport.test.LayoutSetPrototypeExportImportTest.classMethod

org.springframework.orm.hibernate3.HibernateOptimisticLockingFailureException: Object of class [com.liferay.portal.model.impl.LayoutSetPrototypeImpl] with identifier [41980]: optimistic locking failed; nested exception is org.hibernate.StaleObjectStateException: Row was updated or deleted by another transaction (or unsaved-value mapping was incorrect): [com.liferay.portal.model.impl.LayoutSetPrototypeImpl#41980]
	at org.springframework.orm.hibernate3.SessionFactoryUtils.convertHibernateAccessException(SessionFactoryUtils.java:699)
	at org.springframework.orm.hibernate3.SpringSessionSynchronization.translateException(SpringSessionSynchronization.java:165)
	at org.springframework.orm.hibernate3.SpringSessionSynchronization.beforeCommit(SpringSessionSynchronization.java:153)
	at org.springframework.transaction.support.TransactionSynchronizationUtils.triggerBeforeCommit(TransactionSynchronizationUtils.java:96)
	at org.springframework.transaction.support.AbstractPlatformTransactionManager.triggerBeforeCommit(AbstractPlatformTransactionManager.java:919)
	at org.springframework.transaction.support.AbstractPlatformTransactionManager.processCommit(AbstractPlatformTransactionManager.java:727)
	at org.springframework.transaction.support.AbstractPlatformTransactionManager.commit(AbstractPlatformTransactionManager.java:711)
	at com.liferay.portal.spring.transaction.DefaultTransactionExecutor.commit(DefaultTransactionExecutor.java:41)
	at com.liferay.portal.spring.transaction.BaseTransa...

com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog

junit.framework.AssertionFailedError: 
Unable to connect to a valid mail server. Please make sure one is properly configured: Couldn't connect to host, port: localhost, 25; timeout -1
	at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)
	at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)
	at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)
	at java.nio.file.Files.walkFileTree(Files.java:2670)
	at java.nio.file.Files.walkFileTree(Files.java:2742)
	at com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog(PortalLogAssertorTest.java:86)

liferay-continuous-integration · 2021-06-10T17:16:24Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#4851

Jenkins Report:jenkins-report.html

Jenkins Suite:relevant

Pull Request:liferay-tango#1272

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:relevant - 4lejandrito > liferay-tango - PR#1272 - 2021-06-10[05:21:58]

Testray Importer:publish-testray-report#1089

Instance settings default values will be configured from the system settings virtual instance section. They will be automatically inherited.

4lejandrito · 2021-06-10T22:43:32Z

ci:forward

liferay-continuous-integration · 2021-06-10T22:43:36Z

CI is automatically triggering the following test suites:

ci:test:relevant
ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

ci:test:relevant
ci:test:sf
ci:test:stable

liferay-continuous-integration · 2021-06-10T22:45:49Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: e6cd70daf20d8ea4f7a09b7f713c608a85a70bcd

Sender Branch:

Branch Name: LPS-125851-LPS-128383-2
Branch GIT ID: e78d9b0c40602644f112ec52e08ea470d4a76c9d

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2021-06-10T22:46:58Z

Jenkins Build:test-portal-source-format#1009

Jenkins Report:jenkins-report.html

Jenkins Suite:sf

Pull Request:liferay-tango#1272

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:sf - 4lejandrito > liferay-tango - PR#1272 - 2021-06-10[15:43:49]

Testray Importer:publish-testray-report#2934

liferay-continuous-integration · 2021-06-11T02:58:37Z

✔️ ci:test:stable - 10 out of 10 jobs passed

✔️ ci:test:relevant - 23 out of 25 jobs passed in 2 hours 35 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: e6cd70daf20d8ea4f7a09b7f713c608a85a70bcd

Upstream Comparison:

Branch GIT ID: e6cd70daf20d8ea4f7a09b7f713c608a85a70bcd
Jenkins Build URL: Acceptance Upstream DXP (master) #1976

ci:test:stable - 10 out of 10 jobs PASSED

10 Successful Jobs:

ci:test:relevant - 22 out of 25 jobs PASSED

3 Failed Jobs:

22 Successful Jobs:

For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at e6cd70d:

test-portal-acceptance-pullrequest-batch(master)/semantic-versioning-jdk8/0

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #12318

clean-up-java-processes:
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/clean_up_java_processes.sh
[stopwatch] [run.batch.test.setup: 35:16.392 sec]
     [echo] run.batch.test.action.start.timestamp: 06-10-2021 19:09:13:143 PDT
     [echo] Checking for baseline log files.
     [echo] 
     [echo] ##
     [echo] ## /opt/dev/projects/github/liferay-portal/baseline-reports/portal-impl-7.log
     [echo] ##
     [echo] 
[beanshell] [Baseline Warning] Bundle Version Change Recommended: 7.7.8
[beanshell] 
     [echo] 
     [echo] ##
     [echo] ## /opt/dev/projects/github/liferay-portal/baseline-reports/portal-kernel-11.log
     [echo] ##
     [echo] 
[beanshell] [Baseline Warning] Bundle Version Change Recommended: 11.8.1
[beanshell] 
[stopwatch] [run.batch.test.action: 16.170 sec]
     [echo] Semantic versioning is incorrect.
      [get] Getting: http://test-1-2/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0,label_exp=!master/12318//consoleText
      [get] To: /opt/dev/projects/github/liferay-portal/20210610190929315.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/20210610190929315.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/null358157078.properties

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0

Job Results:

1207 Tests Passed.
2 Tests Failed.

AXIS_VARIABLE=3,label_exp=!master #464377

com.liferay.layout.set.prototype.exportimport.test.LayoutSetPrototypeExportImportTest.classMethod

org.springframework.orm.hibernate3.HibernateOptimisticLockingFailureException: Object of class [com.liferay.portal.model.impl.LayoutSetPrototypeImpl] with identifier [41980]: optimistic locking failed; nested exception is org.hibernate.StaleObjectStateException: Row was updated or deleted by another transaction (or unsaved-value mapping was incorrect): [com.liferay.portal.model.impl.LayoutSetPrototypeImpl#41980]
	at org.springframework.orm.hibernate3.SessionFactoryUtils.convertHibernateAccessException(SessionFactoryUtils.java:699)
	at org.springframework.orm.hibernate3.SpringSessionSynchronization.translateException(SpringSessionSynchronization.java:165)
	at org.springframework.orm.hibernate3.SpringSessionSynchronization.beforeCommit(SpringSessionSynchronization.java:153)
	at org.springframework.transaction.support.TransactionSynchronizationUtils.triggerBeforeCommit(TransactionSynchronizationUtils.java:96)
	at org.springframework.transaction.support.AbstractPlatformTransactionManager.triggerBeforeCommit(AbstractPlatformTransactionManager.java:919)
	at org.springframework.transaction.support.AbstractPlatformTransactionManager.processCommit(AbstractPlatformTransactionManager.java:727)
	at org.springframework.transaction.support.AbstractPlatformTransactionManager.commit(AbstractPlatformTransactionManager.java:711)
	at com.liferay.portal.spring.transaction.DefaultTransactionExecutor.commit(DefaultTransactionExecutor.java:41)
	at com.liferay.portal.spring.transaction.BaseTransa...

com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog

junit.framework.AssertionFailedError: 
Unable to connect to a valid mail server. Please make sure one is properly configured: Couldn't connect to host, port: localhost, 25; timeout -1
	at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)
	at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)
	at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)
	at java.nio.file.Files.walkFileTree(Files.java:2670)
	at java.nio.file.Files.walkFileTree(Files.java:2742)
	at com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog(PortalLogAssertorTest.java:86)

liferay-continuous-integration · 2021-06-11T02:59:29Z

All required test suite(s) passed.
Forwarding pull request to brianchandotcom.
Console

liferay-continuous-integration · 2021-06-11T02:59:43Z

Pull request has been successfully forwarded to brianchandotcom#103058
Console

liferay-continuous-integration · 2021-06-11T03:18:47Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#1107

Jenkins Report:jenkins-report.html

Jenkins Suite:relevant

Pull Request:liferay-tango#1272

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:relevant - 4lejandrito > liferay-tango - PR#1272 - 2021-06-10[17:22:25]

Testray Importer:publish-testray-report#2963

4lejandrito changed the title ~~LPS 125851 LPS 128383 2~~ LPS-125851 & LPS-128383 Using system settings only to completely disable the feature Jun 10, 2021

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - success and removed ci:test:sf - pending labels Jun 10, 2021

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending ci:test:relevant - failure ci:test:stable - success and removed ci:test:relevant - pending ci:test:stable - pending labels Jun 10, 2021

4lejandrito added 2 commits June 11, 2021 00:42

LPS-125851 Using system settings only to completely disable the feature

9c1d685

Instance settings default values will be configured from the system settings virtual instance section. They will be automatically inherited.

LPS-128383 Hiding instance settings when disabled at system level

e78d9b0

4lejandrito force-pushed the LPS-125851-LPS-128383-2 branch from d74de31 to e78d9b0 Compare June 10, 2021 22:43

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - success and removed ci:test:sf - success ci:test:sf - pending labels Jun 10, 2021

liferay-continuous-integration added ci:test:relevant - pending and removed ci:test:relevant - failure labels Jun 11, 2021

liferay-continuous-integration added ci:test:stable - pending ci:test:relevant - success ci:test:stable - success and removed ci:test:stable - success ci:test:relevant - pending ci:test:stable - pending labels Jun 11, 2021

liferay-continuous-integration mentioned this pull request Jun 11, 2021

LPS-125851 & LPS-128383 Using system settings only to completely disable the feature brianchandotcom/liferay-portal#103058

Closed

liferay-continuous-integration closed this Jun 11, 2021

LPS-125851 & LPS-128383 Using system settings only to completely disable the feature #1272

LPS-125851 & LPS-128383 Using system settings only to completely disable the feature #1272

Conversation

4lejandrito commented Jun 10, 2021 • edited

liferay-continuous-integration commented Jun 10, 2021

4lejandrito commented Jun 10, 2021

liferay-continuous-integration commented Jun 10, 2021

liferay-continuous-integration commented Jun 10, 2021

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Jun 10, 2021

liferay-continuous-integration commented Jun 10, 2021

✔️ ci:test:stable - 10 out of 10 jobs passed

❌ ci:test:relevant - 23 out of 25 jobs passed in 4 hours 46 minutes

Base Branch:

Upstream Comparison:

2 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0

Job Results:

liferay-continuous-integration commented Jun 10, 2021

4lejandrito commented Jun 10, 2021

liferay-continuous-integration commented Jun 10, 2021

liferay-continuous-integration commented Jun 10, 2021

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Jun 10, 2021

liferay-continuous-integration commented Jun 11, 2021

✔️ ci:test:stable - 10 out of 10 jobs passed

✔️ ci:test:relevant - 23 out of 25 jobs passed in 2 hours 35 minutes

Base Branch:

Upstream Comparison:

3 Failed Jobs:

For more details click here.

This pull contains no unique failures.

test-portal-acceptance-pullrequest-batch(master)/semantic-versioning-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0

Job Results:

liferay-continuous-integration commented Jun 11, 2021

liferay-continuous-integration commented Jun 11, 2021

liferay-continuous-integration commented Jun 11, 2021

4lejandrito commented Jun 10, 2021 •

edited