LPS-137687 File URL to be copyable and placed in first section #1712

beltranrengifo · 2021-10-15T14:13:21Z

liferay-continuous-integration · 2021-10-15T14:13:24Z

Please only forward necessary changes to Brian Chan during stabilization. Nonurgent changes should wait until the ongoing DXP 7.4 GA1 and Portal 7.4 GA4 release has been completed. For more details on the release timeline and status, see product-delivery.

liferay-continuous-integration · 2021-10-15T14:13:26Z

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

beltranrengifo · 2021-10-18T13:17:21Z

ci:test:sf

liferay-continuous-integration · 2021-10-18T13:21:09Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: a18974e510ab9f99a8d858e58727a3abb97b8c77

Sender Branch:

Branch Name: LPS-137687
Branch GIT ID: 23dbb1199e6f81306a36070fe45fcaa088847b31

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2021-10-18T13:22:31Z

Jenkins Build:test-portal-source-format#46

Jenkins Report:jenkins-report.html

Jenkins Suite:sf

Pull Request:liferay-tango#1712

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:sf - beltranrengifo > liferay-tango - PR#1712 - 2021-10-18[06:17:53]

Testray Importer:publish-testray-report#154

beltranrengifo · 2021-10-18T13:24:00Z

ci:test:relevant

liferay-continuous-integration · 2021-10-18T15:48:09Z

✔️ ci:test:stable - 11 out of 11 jobs passed

✔️ ci:test:relevant - 24 out of 24 jobs passed in 2 hours 23 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: a18974e510ab9f99a8d858e58727a3abb97b8c77

Upstream Comparison:

Branch GIT ID: 2c460a267949243af11c9f279a49d014a1f8621c
Jenkins Build URL: Acceptance Upstream DXP (master) #2457

ci:test:stable - 11 out of 11 jobs PASSED

11 Successful Jobs:

ci:test:relevant - 24 out of 24 jobs PASSED

24 Successful Jobs:

For more details click here.

liferay-continuous-integration · 2021-10-18T15:52:04Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#43

Jenkins Report:jenkins-report.html

Jenkins Suite:relevant

Pull Request:liferay-tango#1712

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:relevant - beltranrengifo > liferay-tango - PR#1712 - 2021-10-18[06:24:28]

Testray Importer:publish-testray-report#162

claraizquierdo

Everything works fine. I just see one visual detail. I think that the input with the url should be in a disabled state, like in Documents and Media:

:

…ew component

liferay-continuous-integration · 2021-10-19T15:31:01Z

Previous ci:test:relevantbuild was unsuccessfully reevaluated against more recent upstream results.

❌ ci:test:stable - 10 out of 11 jobs passed

❌ ci:test:relevant - 18 out of 25 jobs passed in 1 hour 39 minutes

Click here for more details.

This pull is eligible for reevaluation. When this upstream build has completed, using the following CI command will compare this pull request result against a more recent upstream result:

ci:reevaluate:1317401_881

Base Branch:

Branch Name: master
Branch GIT ID: f49ab2fc1bfa8ba9bd60157801d7ef33684350bb

Upstream Comparison:

Branch GIT ID: 5651d7d71bbff210e87d1c638ddc260b8aacc1a3
Jenkins Build URL: Acceptance Upstream DXP (master) #2462

ci:test:stable - 10 out of 11 jobs PASSED

1 Failed Jobs:

~~test-portal-acceptance-pullrequest-batch(master)/portal-license-smoke-jdk8/0~~

10 Successful Jobs:

ci:test:relevant - 18 out of 25 jobs PASSED

7 Failed Jobs:

18 Successful Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/empty-temp-dir-jdk8/0

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0 #11569

delete-liferay-home:
     [exec] ERROR 1064 (42000) at line 5: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '(6) null,
     [exec] 	modifiedDate datetime(6) null,
     [exec] 	classNameId bigint,
     [exec] 	classPK bigint,
     [exec] ' at line 9
[stopwatch] [run.batch.test.action: 11.792 sec]
     [echo] The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:365: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:434: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:11755: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-common.xml:521: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-common.xml:640: exec returned: 1
      [get] Getting: http://test-1-32/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0/11569//consoleText
      [get] To: /opt/dev/projects/github/liferay-portal/20211019062305098.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/20211019062305098.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/null1804893463.properties

test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8/0

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0 #11699

delete-liferay-home:
     [exec] ERROR 1064 (42000) at line 5: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '(6) null,
     [exec] 	modifiedDate datetime(6) null,
     [exec] 	classNameId bigint,
     [exec] 	classPK bigint,
     [exec] ' at line 9
[stopwatch] [run.batch.test.action: 11.931 sec]
     [echo] The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:365: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:434: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:11755: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-common.xml:521: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-common.xml:640: exec returned: 1
      [get] Getting: http://test-1-31/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0/11699//consoleText
      [get] To: /opt/dev/projects/github/liferay-portal/20211019062242870.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/20211019062242870.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/null258772346.properties

test-portal-acceptance-pullrequest-batch(master)/lpkg-controller-jdk8/0

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0 #11696

delete-liferay-home:
     [exec] ERROR 1064 (42000) at line 5: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '(6) null,
     [exec] 	modifiedDate datetime(6) null,
     [exec] 	classNameId bigint,
     [exec] 	classPK bigint,
     [exec] ' at line 9
[stopwatch] [run.batch.test.action: 12.133 sec]
     [echo] The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:365: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:434: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:11755: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-common.xml:521: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-common.xml:640: exec returned: 1
      [get] Getting: http://test-1-31/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0/11696//consoleText
      [get] To: /opt/dev/projects/github/liferay-portal/20211019062357317.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/20211019062357317.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/null343609479.properties

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0

Job Results:

4 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=1 #5299

     [exec] * What went wrong:
     [exec] Execution failed for task ':baseline10'.
     [exec] > Could not resolve all files for configuration ':detachedConfiguration6'.
     [exec]    > Could not resolve com.liferay.portal:com.liferay.portal.test:[10.0.0,11.0.0).
     [exec]      Required by:
     [exec]          project :
     [exec]       > Failed to list versions for com.liferay.portal:com.liferay.portal.test.
     [exec]          > Unable to load Maven meta-data from https://repository-cdn.liferay.com/nexus/content/groups/public/com/liferay/portal/com.liferay.portal.test/maven-metadata.xml.
     [exec]             > Could not get resource 'https://repository-cdn.liferay.com/nexus/content/groups/public/com/liferay/portal/com.liferay.portal.test/maven-metadata.xml'.
     [exec]                > Could not GET 'https://repository-cdn.liferay.com/nexus/content/groups/public/com/liferay/portal/com.liferay.portal.test/maven-metadata.xml'.
     [exec]                   > repository-cdn.liferay.com: Name or service not known
     [exec] 
     [exec] * Try:
     [exec] Run with --info or --debug option to get more log output. Run with --scan to get full insights.
     [exec] 
     [exec] * Exception is:
     [exec] org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':baseline10'.
     [exec] 	at org.gradle.api.internal.tasks.execution.CatchExceptionTaskExecuter.execute(CatchExceptionTaskExecuter.java:38)
     [exec] 	at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter\$1.executeTask(EventFiringTaskExecuter.java:77)
     [exec] 	at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter\$1.call(EventFiringTaskExecuter.java:55)
     [exec] 	at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter\$1.call(EventFiringTaskExecuter.java:52)
     [exec] 	at org.gradle.internal.operations.DefaultBuildOperationExecutor\$CallableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:409)
     [exec] 	at org.gradle.internal.operations.DefaultBuildOperationExecutor\$CallableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:399)
     [exec] 	at org.gradle.internal.operations.DefaultBuildOperationExecutor\$1.execute(DefaultBuildOperationExecutor.java:157)
     [exec] 	at org.gradle.internal.operations.DefaultBuildOperationExecutor.execute(DefaultBuildOperationExecutor.java:242)
     [exec] 	at org.gradle.internal.operations.DefaultBuildOperationExecutor.execute(DefaultBuildOperationExecutor.java:150)

test-portal-acceptance-pullrequest-batch(master)/patching-tool-jdk8/0

Job Results:

0 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0 #9428

delete-liferay-home:
   [delete] Deleting directory /tmp/sprite
     [exec] ERROR 1064 (42000) at line 5: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '(6) null,
     [exec] 	modifiedDate datetime(6) null,
     [exec] 	classNameId bigint,
     [exec] 	classPK bigint,
     [exec] ' at line 9
[stopwatch] [run.batch.test.action: 12.706 sec]
     [echo] The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:365: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test-batch.xml:434: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-test.xml:11755: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-common.xml:521: The following error occurred while executing this line:
     [echo] /opt/dev/projects/github/liferay-portal/build-common.xml:640: exec returned: 1
      [get] Getting: http://test-1-27/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0/9428//consoleText
      [get] To: /opt/dev/projects/github/liferay-portal/20211019062403189.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/20211019062403189.txt
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/null399205695.properties

...

…y infoPanel

beltranrengifo · 2021-10-19T15:35:08Z

ci:test:sf

liferay-continuous-integration · 2021-10-19T15:38:08Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 34d82cdbffee730a3f27bc996acb53b67ce20bb3

Sender Branch:

Branch Name: LPS-137687
Branch GIT ID: 9143a38396a7c6e04df61909a4615c2092a69ab4

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

beltranrengifo · 2021-10-19T15:40:05Z

cI.test:relevant

liferay-continuous-integration · 2021-10-19T15:40:27Z

Jenkins Build:test-portal-source-format#720

Jenkins Report:jenkins-report.html

Jenkins Suite:sf

Pull Request:liferay-tango#1712

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:sf - beltranrengifo > liferay-tango - PR#1712 - 2021-10-19[08:35:31]

Testray Importer:publish-testray-report#2426

beltranrengifo · 2021-10-20T07:43:06Z

ci:test:relevant

liferay-continuous-integration · 2021-10-20T10:28:53Z

✔️ ci:test:stable - 11 out of 11 jobs passed

✔️ ci:test:relevant - 24 out of 25 jobs passed in 2 hours 44 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: ffd3940977d8d3d5163a8baf74999386e2e62765

Upstream Comparison:

Branch GIT ID: ffd3940977d8d3d5163a8baf74999386e2e62765
Jenkins Build URL: Acceptance Upstream DXP (master) #2468

ci:test:stable - 11 out of 11 jobs PASSED

11 Successful Jobs:

ci:test:relevant - 23 out of 25 jobs PASSED

2 Failed Jobs:

23 Successful Jobs:

For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at ffd3940:

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0
Job Results:
4 Tests Passed.
0 Tests Failed.
1. AXIS_VARIABLE=5 #236107
  Build was aborted

beltranrengifo · 2021-10-20T10:31:48Z

ci:forward

liferay-continuous-integration · 2021-10-20T10:31:52Z

CI is automatically triggering the following test suites:

ci:test:relevant
ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

ci:test:relevant
ci:test:sf
ci:test:stable

liferay-continuous-integration · 2021-10-20T10:31:53Z

Skipping previously passed test suites:
ci:test:relevant
ci:test:sf

liferay-continuous-integration · 2021-10-20T10:32:41Z

All required test suite(s) passed.
Forwarding pull request to brianchandotcom.
Console

liferay-continuous-integration · 2021-10-20T10:32:54Z

Pull request has been successfully forwarded to brianchandotcom#108827
Console

liferay-continuous-integration · 2021-10-20T10:42:45Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#692

Jenkins Report:jenkins-report.html

Jenkins Suite:relevant

Pull Request:liferay-tango#1712

Testray Routine:EE Pull Request

Testray Build:[master] ci:test:relevant - beltranrengifo > liferay-tango - PR#1712 - 2021-10-20[00:43:29]

Testray Importer:publish-testray-report#1975

beltranrengifo marked this pull request as draft October 15, 2021 14:13

beltranrengifo self-assigned this Oct 15, 2021

beltranrengifo changed the title ~~LPS 137687~~ LPS-137687 File URL to be copyable and placed in first section Oct 15, 2021

beltranrengifo force-pushed the LPS-137687 branch 4 times, most recently from e9bb963 to 4005ca9 Compare October 18, 2021 06:55

beltranrengifo requested a review from claraizquierdo October 18, 2021 06:57

beltranrengifo marked this pull request as ready for review October 18, 2021 06:57

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - success and removed ci:test:sf - pending labels Oct 18, 2021

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending ci:test:relevant - success ci:test:stable - success and removed ci:test:relevant - pending ci:test:stable - pending labels Oct 18, 2021

claraizquierdo reviewed Oct 18, 2021

View reviewed changes

Beltran Rengifo added 3 commits October 19, 2021 08:28

LPS-137687 FileUrlCopyButton component is functional

5698999

LPS-137687 Using c-* prefix for spacing classes in SidebarPanelInfoVi…

000ad38

…ew component

LPS-137687 Unit testing for FileUrlCopyButton plus fixes

ea0d847

Beltran Rengifo added 2 commits October 19, 2021 17:34

LPS-137687 Fixes for units

d06fabe

LPS-137687 Add readonly attributes to copy-url inputs in Media Librar…

9143a38

…y infoPanel

beltranrengifo force-pushed the LPS-137687 branch from 5ca4ad7 to 9143a38 Compare October 19, 2021 15:34

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - success and removed ci:test:sf - success ci:test:sf - pending labels Oct 19, 2021

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending ci:test:relevant - success ci:test:stable - success and removed ci:test:relevant - failure ci:test:stable - failure ci:test:relevant - pending ci:test:stable - pending labels Oct 20, 2021

liferay-continuous-integration mentioned this pull request Oct 20, 2021

LPS-137687 File URL to be copyable and placed in first section brianchandotcom/liferay-portal#108827

Closed

liferay-continuous-integration closed this Oct 20, 2021

LPS-137687 File URL to be copyable and placed in first section #1712

LPS-137687 File URL to be copyable and placed in first section #1712

Conversation

beltranrengifo commented Oct 15, 2021 • edited

liferay-continuous-integration commented Oct 15, 2021

liferay-continuous-integration commented Oct 15, 2021

beltranrengifo commented Oct 18, 2021

liferay-continuous-integration commented Oct 18, 2021

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Oct 18, 2021

beltranrengifo commented Oct 18, 2021

liferay-continuous-integration commented Oct 18, 2021

✔️ ci:test:stable - 11 out of 11 jobs passed

✔️ ci:test:relevant - 24 out of 24 jobs passed in 2 hours 23 minutes

Base Branch:

Upstream Comparison:

For more details click here.

liferay-continuous-integration commented Oct 18, 2021

claraizquierdo left a comment

Choose a reason for hiding this comment

liferay-continuous-integration commented Oct 19, 2021

❌ ci:test:stable - 10 out of 11 jobs passed

❌ ci:test:relevant - 18 out of 25 jobs passed in 1 hour 39 minutes

Base Branch:

Upstream Comparison:

1 Failed Jobs:

7 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/empty-temp-dir-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/lpkg-controller-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0

Job Results:

test-portal-acceptance-pullrequest-batch(master)/patching-tool-jdk8/0

Job Results:

beltranrengifo commented Oct 19, 2021

liferay-continuous-integration commented Oct 19, 2021

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Base Branch:

Sender Branch:

For more details click here.

beltranrengifo commented Oct 19, 2021

liferay-continuous-integration commented Oct 19, 2021

beltranrengifo commented Oct 20, 2021

liferay-continuous-integration commented Oct 20, 2021

✔️ ci:test:stable - 11 out of 11 jobs passed

✔️ ci:test:relevant - 24 out of 25 jobs passed in 2 hours 44 minutes

Base Branch:

Upstream Comparison:

2 Failed Jobs:

For more details click here.

This pull contains no unique failures.

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0

Job Results:

beltranrengifo commented Oct 20, 2021

liferay-continuous-integration commented Oct 20, 2021

liferay-continuous-integration commented Oct 20, 2021

liferay-continuous-integration commented Oct 20, 2021

liferay-continuous-integration commented Oct 20, 2021

liferay-continuous-integration commented Oct 20, 2021

beltranrengifo commented Oct 15, 2021 •

edited