Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-138663 Delete reads metrics for documents #2183

Closed
wants to merge 2 commits into from
Closed

Conversation

cgoncas
Copy link
Collaborator

@cgoncas cgoncas commented Feb 7, 2022

Motivation

Documents should not include reads metrics in the content performance panel

Link to story or ticket

Proposed Solution

Don't fill the read metrics for Documents in the Content Performance Panel

Steps to Verify:

  1. Create a Display Page for Documents
  2. Mark it as default
  3. Create a Document
  4. Create a Content Page with an Asset Publisher fragment.
  5. Click on the title of the document in the Asset Publisher
  6. Open the Content Performance panel for the document
  7. Read metrics are not shown in the content performance panel

Screencaps:

Screenshot 2022-02-08 at 15 58 18

@liferay-continuous-integration

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@cgoncas
Copy link
Collaborator Author

cgoncas commented Feb 7, 2022

ci:test:sf

@cgoncas
Copy link
Collaborator Author

cgoncas commented Feb 7, 2022

ci:test:relevant

@cgoncas
Copy link
Collaborator Author

cgoncas commented Feb 7, 2022

Hey @CarlosBrichete !!

Could you tests if with the changes in this PR https://issues.liferay.com/browse/LPS-138663 is no longer reproducible?

Thanks!!!

@liferay-continuous-integration

✔️ ci:test:sf - 1 out of 1 jobs passed in 2 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 92c72dd04b76a0c36f8ad77efeaf18728ebdf1c6

Sender Branch:

Branch Name: LPS-138663
Branch GIT ID: ad7cc1f30406aee7a198fd3ff1f34e7c7a112275

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration

@liferay-continuous-integration

✔️ ci:test:stable - 21 out of 25 jobs passed

✔️ ci:test:relevant - 24 out of 28 jobs passed in 1 hour 29 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 92c72dd04b76a0c36f8ad77efeaf18728ebdf1c6

Upstream Comparison:

Branch GIT ID: 92c72dd04b76a0c36f8ad77efeaf18728ebdf1c6
Jenkins Build URL: Acceptance Upstream DXP (master) #2895

ci:test:stable - 21 out of 25 jobs PASSED
21 Successful Jobs:
ci:test:relevant - 23 out of 28 jobs PASSED
23 Successful Jobs:
For more details click here.

This pull contains no unique failures.


Failures in common with acceptance upstream results at 92c72dd:
  1. test-portal-acceptance-pullrequest-batch(master)/semantic-versioning-jdk8/0
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0 #29012
      clean-up-java-processes:
         [delete] Deleting: /opt/dev/projects/github/liferay-portal/clean_up_java_processes.sh
      [stopwatch] [run.batch.test.setup: 26:06.008 sec]
           [echo] run.batch.test.action.start.timestamp: 02-07-2022 02:40:42:720 PST
           [echo] Checking for baseline log files.
           [echo] 
           [echo] ##
           [echo] ## /opt/dev/projects/github/liferay-portal/baseline-reports/portal-kernel.log
           [echo] ##
           [echo] 
      [beanshell] [Baseline Warning] Bundle Version Change Recommended: 35.0.0
      [beanshell] 
      [stopwatch] [run.batch.test.action: 10.458 sec]
           [echo] Semantic versioning is incorrect.
            [get] Getting: http://test-1-27/job/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=0/29012//consoleText
            [get] To: /opt/dev/projects/github/liferay-portal/20220207024053179.txt
         [delete] Deleting: /opt/dev/projects/github/liferay-portal/20220207024053179.txt
         [delete] Deleting: /opt/dev/projects/github/liferay-portal/null1110391283.properties
  2. test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8/0
    Job Results:

    2 Tests Passed.
    3 Tests Failed.

    1. AXIS_VARIABLE=0 #26986
      1. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanOSGiLog
        junit.framework.AssertionFailedError: 
        Portal log assert failure, OSGi log found: /opt/dev/projects/github/liferay-portal/bundles/osgi/state/1644229897006.log:
        !SESSION 2022-02-07 10:32:02.484 -----------------------------------------------
        eclipse.buildId=unknown
        java.version=1.8.0_121
        java.vendor=Oracle Corporation
        BootLoader constants: OS=linux, ARCH=x86_64, WS=gtk, NL=en_US
        

        !ENTRY com.liferay.site.initializer.extender 4 0 2022-02-07 10:32:02.484
        !MESSAGE FrameworkEvent ERROR
        !STACK 0
        org.osgi.framework.BundleException: Could not resolve module: com.liferay.site.initializer.extender [745]
        Unresolved requirement: Import-Package: com.liferay.commerce.account.util; version="1.3.0"

        at org.eclipse.osgi.container.Module.start(Module.java:444)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1682)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1662)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1624)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1555)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1)
        at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
        at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:340)

        !ENTRY com.lif...

      2. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError:
        FrameworkEvent ERROR
        org.osgi.framework.BundleException: Could not resolve module: com.liferay.site.initializer.extender [745]
        Unresolved requirement: Import-Package: com.liferay.commerce.account.util; version="1.3.0"

        at org.eclipse.osgi.container.Module.start(Module.java:444)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1682)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1662)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1624)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1555)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1)
        at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
        at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:340)

        at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)
        at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)
        at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)
        at java.nio.file.Files.walkFileTree(Files.java:2670)
        at java.nio.file.Files.walkFileTree(Files.java:2742)
        at com.liferay.portal.log.asser...

  3. test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0
    Job Results:

    1117 Tests Passed.
    2 Tests Failed.

    1. AXIS_VARIABLE=1 #15812
      1. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError:
        com.liferay.portal.kernel.exception.PortalException: Unable to search with filter ((customField/_52327_k4ryBHkN eq 'BHd7K2x3')) and (classPK eq '20128')
        com.liferay.portal.kernel.exception.PortalException: Unable to search with filter ((customField/_52327_k4ryBHkN eq 'BHd7K2x3')) and (classPK eq '20128')
        at com.liferay.segments.internal.odata.search.ODataSearchAdapterImpl.searchCount(ODataSearchAdapterImpl.java:110)
        at com.liferay.segments.internal.odata.retriever.UserODataRetriever.getResultsCount(UserODataRetriever.java:69)
        at com.liferay.segments.internal.provider.BaseSegmentsEntryProvider.isMember(BaseSegmentsEntryProvider.java:286)
        at com.liferay.segments.internal.provider.BaseSegmentsEntryProvider.lambda$getSegmentsEntryIds$1(BaseSegmentsEntryProvider.java:153)
        at java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:174)
        at java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1374)
        at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481)
        at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:471)
        at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:545)
        at java.util.stream.AbstractPipeline.evaluateToArrayNode(AbstractPipeline.java:260)
        at java.util.stream.LongPipeline.toArray(LongPipeline.java:484)
        at com.liferay.segments.internal.provider.BaseSegmentsEntryProvider.getSegmentsEntryIds(BaseSegmentsEntryProvider.java:157)
        at com.lif...
    2. AXIS_VARIABLE=2 #15812
      1. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError:
        com.liferay.portal.kernel.exception.PortalException: Unable to search with filter ((customField/_113115_qc9HjU2R eq '30nmLmbt')) and (classPK eq '20128')
        com.liferay.portal.kernel.exception.PortalException: Unable to search with filter ((customField/_113115_qc9HjU2R eq '30nmLmbt')) and (classPK eq '20128')
        at com.liferay.segments.internal.odata.search.ODataSearchAdapterImpl.searchCount(ODataSearchAdapterImpl.java:110)
        at com.liferay.segments.internal.odata.retriever.UserODataRetriever.getResultsCount(UserODataRetriever.java:69)
        at com.liferay.segments.internal.provider.BaseSegmentsEntryProvider.isMember(BaseSegmentsEntryProvider.java:286)
        at com.liferay.segments.internal.provider.BaseSegmentsEntryProvider.lambda$getSegmentsEntryIds$1(BaseSegmentsEntryProvider.java:153)
        at java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:174)
        at java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1374)
        at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481)
        at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:471)
        at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:545)
        at java.util.stream.AbstractPipeline.evaluateToArrayNode(AbstractPipeline.java:260)
        at java.util.stream.LongPipeline.toArray(LongPipeline.java:484)
        at com.liferay.segments.internal.provider.BaseSegmentsEntryProvider.getSegmentsEntryIds(BaseSegmentsEntryProvider.java:157)
        at com.l...

@liferay-continuous-integration

@YurenaC
Copy link
Collaborator

YurenaC commented Feb 7, 2022

LGTM

@CarlosBrichete
Copy link
Collaborator

LGTM 👍

@cgoncas
Copy link
Collaborator Author

cgoncas commented Feb 7, 2022

ci:forward

@liferay-continuous-integration

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration

Skipping previously passed test suites:
ci:test:relevant
ci:test:sf

@liferay-continuous-integration

All required test suite(s) passed.
Forwarding pull request to brianchandotcom.
Console

@liferay-continuous-integration

Pull request has been successfully forwarded to brianchandotcom#113135
Console

@cgoncas
Copy link
Collaborator Author

cgoncas commented Feb 7, 2022

ci:forward

@liferay-continuous-integration

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 79e937aa34c8b7857b016d621b04a655bf69db2b

Sender Branch:

Branch Name: LPS-138663
Branch GIT ID: 5f924f526acdc233b676775afa61c6f6f6196bcc

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration

@liferay-continuous-integration

✔️ ci:test:stable - 22 out of 25 jobs passed

✔️ ci:test:relevant - 25 out of 28 jobs passed in 1 hour 59 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 79e937aa34c8b7857b016d621b04a655bf69db2b

Upstream Comparison:

Branch GIT ID: 76e0dd421b1d463a7563b2fc53f2cae786d7701f
Jenkins Build URL: Acceptance Upstream DXP (master) #2897

ci:test:stable - 22 out of 25 jobs PASSED
22 Successful Jobs:
ci:test:relevant - 24 out of 28 jobs PASSED
24 Successful Jobs:
For more details click here.

This pull contains no unique failures.


Failures in common with acceptance upstream results at 76e0dd4:
  1. test-portal-acceptance-pullrequest-batch(master)/lpkg-base-jdk8/0
    Job Results:

    2 Tests Passed.
    3 Tests Failed.

    1. AXIS_VARIABLE=0 #350060
      1. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanOSGiLog
        junit.framework.AssertionFailedError: 
        Portal log assert failure, OSGi log found: /opt/dev/projects/github/liferay-portal/bundles/osgi/state/1644256959298.log:
        !SESSION 2022-02-07 18:02:57.347 -----------------------------------------------
        eclipse.buildId=unknown
        java.version=1.8.0_121
        java.vendor=Oracle Corporation
        BootLoader constants: OS=linux, ARCH=x86_64, WS=gtk, NL=en_US
        

        !ENTRY com.liferay.site.initializer.extender 4 0 2022-02-07 18:02:57.347
        !MESSAGE FrameworkEvent ERROR
        !STACK 0
        org.osgi.framework.BundleException: Could not resolve module: com.liferay.site.initializer.extender [189]
        Unresolved requirement: Import-Package: com.liferay.commerce.account.util; version="1.3.0"

        at org.eclipse.osgi.container.Module.start(Module.java:444)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1682)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1662)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1624)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1555)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1)
        at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
        at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:340)

        !ENTRY com.lif...

      2. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError:
        FrameworkEvent ERROR
        org.osgi.framework.BundleException: Could not resolve module: com.liferay.site.initializer.extender [189]
        Unresolved requirement: Import-Package: com.liferay.commerce.account.util; version="1.3.0"

        at org.eclipse.osgi.container.Module.start(Module.java:444)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1682)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.incStartLevel(ModuleContainer.java:1662)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.doContainerStartLevel(ModuleContainer.java:1624)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1555)
        at org.eclipse.osgi.container.ModuleContainer$ContainerStartLevel.dispatchEvent(ModuleContainer.java:1)
        at org.eclipse.osgi.framework.eventmgr.EventManager.dispatchEvent(EventManager.java:230)
        at org.eclipse.osgi.framework.eventmgr.EventManager$EventThread.run(EventManager.java:340)

        at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)
        at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)
        at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)
        at java.nio.file.Files.walkFileTree(Files.java:2670)
        at java.nio.file.Files.walkFileTree(Files.java:2742)
        at com.liferay.portal.log.asser...

  2. test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0
    Job Results:

    1125 Tests Passed.
    2 Tests Failed.

    1. AXIS_VARIABLE=2 #30665
      1. com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog
        junit.framework.AssertionFailedError:
        com.liferay.portal.kernel.exception.PortalException: Unable to search with filter ((customField/_112439_UA7P7UV9 eq 'hDoCkHiL')) and (classPK eq '20128')
        com.liferay.portal.kernel.exception.PortalException: Unable to search with filter ((customField/_112439_UA7P7UV9 eq 'hDoCkHiL')) and (classPK eq '20128')
        at com.liferay.segments.internal.odata.search.ODataSearchAdapterImpl.searchCount(ODataSearchAdapterImpl.java:110)
        at com.liferay.segments.internal.odata.retriever.UserODataRetriever.getResultsCount(UserODataRetriever.java:69)
        at com.liferay.segments.internal.provider.BaseSegmentsEntryProvider.isMember(BaseSegmentsEntryProvider.java:286)
        at com.liferay.segments.internal.provider.BaseSegmentsEntryProvider.lambda$getSegmentsEntryIds$1(BaseSegmentsEntryProvider.java:153)
        at java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:174)
        at java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1374)
        at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481)
        at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:471)
        at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:545)
        at java.util.stream.AbstractPipeline.evaluateToArrayNode(AbstractPipeline.java:260)
        at java.util.stream.LongPipeline.toArray(LongPipeline.java:484)
        at com.liferay.segments.internal.provider.BaseSegmentsEntryProvider.getSegmentsEntryIds(BaseSegmentsEntryProvider.java:157)
        at com.l...

@liferay-continuous-integration

All required test suite(s) passed.
Forwarding pull request to brianchandotcom.
Console

@liferay-continuous-integration

Pull request has been successfully forwarded to brianchandotcom#113147
Console

@liferay-continuous-integration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants