Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-168307 Accessibility issues in Segments Editor #3018

Closed
wants to merge 9 commits into from
Closed

LPS-168307 Accessibility issues in Segments Editor #3018

wants to merge 9 commits into from

Conversation

beltranrengifo
Copy link

Jira ticket

Motivation

We are performing a first accessibility review for the Segment Editor.
We are fixing markup issues in this ticket.

Step by Step

  • Navigate to Segments Editor
  • Open axeDevTools
  • Scan the page

Expected: No markup errors related to the Segments Editor

@beltranrengifo beltranrengifo self-assigned this Nov 11, 2022
@liferay-continuous-integration
Copy link

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@beltranrengifo beltranrengifo force-pushed the LPS-168307 branch 2 times, most recently from a557bb7 to 86e27de Compare November 14, 2022 10:44
@beltranrengifo
Copy link
Author

ci:test:sf

@liferay-continuous-integration
Copy link

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 4381b5feed7b396c5b8c3c12cceacbb13b2bda4d

Sender Branch:

Branch Name: LPS-168307
Branch GIT ID: 86e27de20ff7f9098241eec4858d51ee083796ac

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link

@beltranrengifo
Copy link
Author

ci:test:relevant

@liferay-continuous-integration
Copy link

❌ ci:test:stable - 27 out of 28 jobs passed

❌ ci:test:relevant - 104 out of 114 jobs passed in 1 hour 49 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 4381b5feed7b396c5b8c3c12cceacbb13b2bda4d

Upstream Comparison:

Branch GIT ID: 4381b5feed7b396c5b8c3c12cceacbb13b2bda4d
Jenkins Build URL: EE Development Acceptance (master) - 4020 - 2022-11-13[05:06:33]

ci:test:stable - 27 out of 28 jobs PASSED

1 Failed Jobs:

27 Successful Jobs:
    ci:test:relevant - 104 out of 114 jobs PASSED

    10 Failed Jobs:

    104 Successful Jobs:
      For more details click here.

      Failures unique to this pull:

      1. js-unit-jdk8/0/0
             [exec] * What went wrong:
     [exec] Execution failed for task ':apps:segments:segments-web:packageRunTest'.
     [exec] > Process 'command '/opt/dev/projects/github/liferay-portal/build/node/bin/node'' finished with non-zero exit value 1
     [exec] 
     [exec] * Try:
     [exec] Run with --info or --debug option to get more log output. Run with --scan to get full insights.
     [exec] 
     [exec] * Exception is:
     [exec] org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':apps:segments:segments-web:packageRunTest'.
     [exec]   at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.lambda$executeIfValid$3(ExecuteActionsTaskExecuter.java:186)
     [exec]   at org.gradle.internal.Try$Failure.ifSuccessfulOrElse(Try.java:268)
     [exec]   at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeIfValid(ExecuteActionsTaskExecuter.java:184)
     [exec]   at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:173)
     [exec]   at org.gradle.api.internal.tasks.execution.CleanupStaleOutputsExecuter.execute(CleanupStaleOutputsExecuter.java:109)
     [exec]   at org.gradle.api.internal.tasks.execution.FinalizePropertiesTaskExecuter.execute(FinalizePropertiesTaskExecuter.java:46)
     [exec]   at org.gradle.api.internal.tasks.execution.ResolveTaskExecutionModeExecuter.execute(ResolveTaskExecutionModeExecuter.java:62)
     [exec]   at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:57)
     [exec]   at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:56)
     [exec]   at org.gradle.api.internal.tasks.execution.CatchExceptionTaskExecuter.execute(CatchExceptionTaskExecuter.java:36)
     [exec]   at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.executeTask(EventFiringTaskExecuter.java:77)
     [exec]   at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:55)
     [exec]   at org.gradle.api.internal.tasks.execution.EventFiringTaskExecuter$1.call(EventFiringTaskExecuter.java:52)
     [exec]   at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:200)
     [exec]   at org.gradle.internal.operations.DefaultBuildOperationRunner$CallableBuildOperationWorker.execute(DefaultBuildOperationRunner.java:195)
      6. ...

      @liferay-continuous-integration
      Copy link

      @beltranrengifo
      Copy link
      Author

      ci:stop

      @beltranrengifo
      Copy link
      Author

      ci:test:relevant

      @beltranrengifo
      Copy link
      Author

      ci:stop

      @liferay-continuous-integration
      Copy link

      ❌ ci:test:relevant - 0 out of 1 jobs passed in 43 minutes

      Click here for more details.

      Base Branch:

      Branch Name: master
      Branch GIT ID: 64c44d3bc4029fe95db0b1075e02ff52211af987

      Upstream Comparison:

      Branch GIT ID: 64c44d3bc4029fe95db0b1075e02ff52211af987
      Jenkins Build URL: EE Development Acceptance (master) - 4024 - 2022-11-14[15:05:55]

      ci:test:relevant - 0 out of 1 jobs PASSED
      For more details click here.

      Failures unique to this pull:

      1. test-portal-acceptance-pullrequest(master)
        Job Results:

        0 Jobs Passed.
        1 Job Failed.

        Build was aborted

      For upstream results, click here.

      @liferay-continuous-integration
      Copy link

      ✔️ ci:test:bundle - 1 out of 1 jobs passed in 35 minutes

      Click here for more details.

      Base Branch:

      Branch Name: master
      Branch GIT ID: 7981e83f8002dec2719622319ec5efc72b279042

      Upstream Comparison:

      Branch GIT ID: 7981e83f8002dec2719622319ec5efc72b279042
      Jenkins Build URL: EE Development Acceptance (master) - 4029 - 2022-11-16[07:41:46]

      ci:test:bundle - 1 out of 1 jobs PASSED
      For more details click here.
      Test bundle downloads:

      @liferay-continuous-integration
      Copy link

      @claraizquierdo
      Copy link
      Collaborator

      ci:test:relevant

      @liferay-continuous-integration
      Copy link

      ✔️ ci:test:stable - 28 out of 28 jobs passed

      ✔️ ci:test:relevant - 101 out of 110 jobs passed in 2 hours 2 minutes

      Click here for more details.

      Base Branch:

      Branch Name: master
      Branch GIT ID: aa8528ba992dc6eb3f8a9e44ac1b772611a92bbf

      Upstream Comparison:

      Branch GIT ID: 50692acd3ead17d68f1c86e2a9b1981bc5b1b3c4
      Jenkins Build URL: EE Development Acceptance (master) - 4030 - 2022-11-17[05:07:40]

      ci:test:stable - 28 out of 28 jobs PASSED
      28 Successful Jobs:
        ci:test:relevant - 100 out of 110 jobs PASSED

        10 Failed Jobs:

        100 Successful Jobs:
          For more details click here.

          This pull contains no unique failures.

          Failures in common with acceptance upstream results at 50692ac:
          6. ...

          @liferay-continuous-integration
          Copy link

          @claraizquierdo
          Copy link
          Collaborator

          ci:forward

          @liferay-continuous-integration
          Copy link

          CI is automatically triggering the following test suites:

          •     ci:test:relevant
          •     ci:test:sf

          The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

          •     ci:test:relevant
          •     ci:test:sf
          •     ci:test:stable

          @liferay-continuous-integration
          Copy link

          Skipping previously passed test suites:
          ci:test:relevant

          @liferay-continuous-integration
          Copy link

          ✔️ ci:test:sf - 1 out of 1 jobs passed in 6 minutes

          Click here for more details.

          Base Branch:

          Branch Name: master
          Branch GIT ID: 736e30e347e623b20218a0e5ec2e422faa62efb7

          Sender Branch:

          Branch Name: LPS-168307
          Branch GIT ID: f18198492c64d04826254cb8e7f51689486bd35c

          1 out of 1jobs PASSED
          1 Successful Jobs:
          For more details click here.

          @liferay-continuous-integration
          Copy link

          All required test suite(s) passed.
          Forwarding pull request to brianchandotcom.
          Console

          Closed
          @liferay-continuous-integration
          Copy link

          Pull request has been successfully forwarded to brianchandotcom#126443
          Console

          @liferay-continuous-integration
          Copy link

          @claraizquierdo claraizquierdo mentioned this pull request Nov 17, 2022
          Closed
          Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
          Reviewers

          @claraizquierdo claraizquierdo claraizquierdo approved these changes

          Assignees

          @beltranrengifo beltranrengifo

          Labels
          ci:test:bundle - success ci:test:relevant - success ci:test:sf - success ci:test:stable - success forwarding ➡️ This pull request is ready to be forwarded
          Projects
          None yet
          Milestone
          No milestone
          4 participants
          @beltranrengifo @liferay-continuous-integration @claraizquierdo @CarlosBrichete