Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-122085 Remove charts animations to avoid performance warnings #426

Closed
wants to merge 1 commit into from
Closed

LPS-122085 Remove charts animations to avoid performance warnings #426

wants to merge 1 commit into from

Conversation

dgarciasarai
Copy link

@dgarciasarai dgarciasarai commented Oct 13, 2020 •
edited

Description

Using the Chrome Dev Tool Performance, I saw that animations from the Recharts library caused some warnings (cascading updates: Recharts library changes state inside componentDidMount) so with this commit, I removed the animations for PieChart and Line (LineChart).

This is part of this bug: Content Performance loading is too slow.

See: reduxjs/react-redux#834

Screenshot

AnalyticsReportsApp Performance Warning Animations

@liferay-continuous-integration
Copy link

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@dgarciasarai
Copy link
Author

ci:test:sf

@dgarciasarai
Copy link
Author

ci:test:relevant

@dgarciasarai dgarciasarai added the bug 🐛 Something isn't working label Oct 13, 2020
@liferay-continuous-integration
Copy link

✔️ ci:test:sf - 1 out of 1 jobs passed in 18 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: aad039667411d99fecabd6f8c6f43675a42316c3

Sender Branch:

Branch Name: LPS-122085
Branch GIT ID: 120ec86dfc62432e4cf7a521050a0028a39c818c

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link

Jenkins Build:test-portal-source-format#3349
Jenkins Report:jenkins-report.html
Jenkins Suite: sf
Pull Request:liferay-tango#426
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:sf
Spira Release Build:master - dgarciasarai > liferay-tango - PR#426 - 2020-10-13[01:55:37]
Spira Jenkins Build:publish-spira-report#7255

@liferay-continuous-integration
Copy link

✔️ ci:test:stable - 20 out of 20 jobs passed

✔️ ci:test:relevant - 43 out of 44 jobs passed in 1 hour 45 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: aad039667411d99fecabd6f8c6f43675a42316c3

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 18db04be4805a0b0d6c7f3d11f92bd581c634bff

ci:test:stable - 20 out of 20 jobs PASSED
20 Successful Jobs:
ci:test:relevant - 42 out of 44 jobs PASSED
42 Successful Jobs:
For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at aad0396:
  1. test-portal-acceptance-pullrequest-batch(master)/semantic-versioning-jdk8
    Job Results:

    0 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=0,label_exp=!master #314935

      Please fix semantic versioning on dgarciasarai/LPS-122085

           [exec]   PACKAGE_NAME                                       DELTA      CUR_VER    BASE_VER   REC_VER    WARNINGS  
     [exec] = ================================================== ========== ========== ========== ========== ==========
     [exec] * com.liferay.portal.kernel.util                     MINOR      10.11.0    10.11.0    10.12.0    VERSION INCREASE REQUIRED
     [exec] 	<   class      com.liferay.portal.kernel.util.ReleaseInfo
     [exec] 		+   field      RELEASE_7_4_0_BUILD_NUMBER
     [exec] 			+   access     final
     [exec] 			+   access     static
     [exec] 			+   constant   7400
     [exec] 			+   return     int
     [exec] 		+   field      RELEASE_7_4_10_BUILD_NUMBER
     [exec] 			+   access     final
     [exec] 			+   access     static
     [exec] 			+   constant   7410
     [exec] 			+   return     int
     [exec] [Baseline Report] Mode: diff (persisted)
     [exec] Semantic versioning is incorrect while checking /opt/dev/projects/github/liferay-portal/portal-kernel/portal-kernel.jar against /opt/dev/projects/github/liferay-portal/.gradle/caches/modules-2/files-2.1/com.liferay.portal/com.liferay.portal.kernel/9.9.0/9467772b1d889966e8e453c6fac622dfeb9b2994/com.liferay.portal.kernel-9.9.0.jar

@liferay-continuous-integration
Copy link

Jenkins Build:test-portal-acceptance-pullrequest(master)#6658
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:liferay-tango#426
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:relevant
Spira Release Build:master - dgarciasarai > liferay-tango - PR#426 - 2020-10-13[03:13:35]
Spira Jenkins Build:publish-spira-report#9459

@dgarciasarai
Copy link
Author

ci:forward

@liferay-continuous-integration
Copy link

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link

Skipping previously passed test suites:
ci:test:relevant
ci:test:sf

@liferay-continuous-integration
Copy link

All required test suite(s) passed.
Forwarding pullrequest to brianchandotcom.

Closed
@liferay-continuous-integration
Copy link

Pull request has been successfully forwarded to brianchandotcom#94941

@dgarciasarai dgarciasarai deleted the LPS-122085 branch November 12, 2020 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug 🐛 Something isn't working ci:test:relevant - success ci:test:sf - success ci:test:stable - success
Projects
None yet
Milestone
No milestone
2 participants
@dgarciasarai @liferay-continuous-integration