LPS-123084 Calculate the segments only when there are experiences associated with the layout. #686

cgoncas · 2020-12-16T08:28:40Z

Motivation

The main goal of this pull is to calculate SegmentsExperienceIds only when the layout has an associated experience.

This is the fourth pull to merge into master the Performance Issue fix with Segmentation (for the full solution take a look to #505)

Proposed solution

We will stop calculating segments if there is not experience is associated with the layout .

How to test it

All manual/funtional tests of Segments and Experiences should work as they did before.

/cc @liferay-echo

…setCategoryParameters

… it in the generated tests

…ng user permissions as stated by LPS-5695/LPE-1585

…can only be changed at instance settings so site/organization roles does not need to be considered

…L which doesn't run the JS

…alues

…ery render

…to retrieve the relevant MBDiscussion entry.

…heir parents

…rk well with fields within fieldset

…es just like we do for non-repeatable fields

Javascript doesnt have a proper integer type, it uses a floating point representation for all numbers. This may lead to weird rounding errors when storing longs/integers as raw numbers in a JSON object.

liferay-continuous-integration · 2020-12-16T08:51:35Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: a8e7fc4f7ea8a7c5c4caee7e31fa58de416a3526

Sender Branch:

Branch Name: LPS-123084.4
Branch GIT ID: ef7634a851127468eee2c7e87a58e3ab865ae6bb

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2020-12-16T08:53:55Z

Jenkins Build:test-portal-source-format#4877
Jenkins Report:jenkins-report.html
Jenkins Suite: sf
Pull Request:liferay-tango#686
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:sf
Spira Release Build:master - cgoncas > liferay-tango - PR#686 - 2020-12-16[00:48:44]
Spira Jenkins Build:publish-spira-report#8770

liferay-continuous-integration · 2020-12-16T10:24:47Z

✔️ ci:test:stable - 9 out of 9 jobs passed

❌ ci:test:relevant - 21 out of 23 jobs passed in 1 hour 34 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 012adf4b2836179a5478bf04b5337955917fccb8

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 0ff04d9f73a4643abdd2b335581feef26b985b8a

ci:test:stable - 9 out of 9 jobs PASSED

9 Successful Jobs:

ci:test:relevant - 21 out of 23 jobs PASSED

2 Failed Jobs:

21 Successful Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0
Job Results:
5 Tests Passed.
1 Test Failed.
1. AXIS_VARIABLE=0,label_exp=!master #420120
  1. LocalFile.SegmentationCreateSegment#AssignSiteRolesOptionEnabled - Poshi Report - Poshi Summary - Console Output

For upstream results, click here.

liferay-continuous-integration · 2020-12-16T10:28:58Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#7471
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:liferay-tango#686
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:relevant
Spira Release Build:master - cgoncas > liferay-tango - PR#686 - 2020-12-16[00:48:44]
Spira Jenkins Build:publish-spira-report#9584

cgoncas · 2020-12-16T11:03:09Z

ci:forward

liferay-continuous-integration · 2020-12-16T11:03:13Z

CI is automatically triggering the following test suites:

ci:test:relevant
ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

ci:test:relevant
ci:test:sf
ci:test:stable

liferay-continuous-integration · 2020-12-16T11:03:17Z

Skipping previously passed test suites:
ci:test:sf

liferay-continuous-integration · 2020-12-16T12:35:44Z

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 22 out of 23 jobs passed in 1 hour 31 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 012adf4b2836179a5478bf04b5337955917fccb8

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 0ff04d9f73a4643abdd2b335581feef26b985b8a

ci:test:stable - 9 out of 9 jobs PASSED

9 Successful Jobs:

ci:test:relevant - 21 out of 23 jobs PASSED

2 Failed Jobs:

21 Successful Jobs:

For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at 012adf4:

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0

Job Results:

932 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=1,label_exp=!master #429574

PortalLogAssertorTest.testScanXMLLog

junit.framework.AssertionFailedError: 
HikariPool-1 - Connection is not available, request timed out after 600001ms.
	at com.liferay.portal.log.assertor.PortalLogAssertorTest.scanXMLLogFile(PortalLogAssertorTest.java:171)
	at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:98)
	at com.liferay.portal.log.assertor.PortalLogAssertorTest$1.visitFile(PortalLogAssertorTest.java:88)
	at java.nio.file.Files.walkFileTree(Files.java:2670)
	at java.nio.file.Files.walkFileTree(Files.java:2742)
	at com.liferay.portal.log.assertor.PortalLogAssertorTest.testScanXMLLog(PortalLogAssertorTest.java:86)

liferay-continuous-integration · 2020-12-16T12:36:16Z

All required test suite(s) passed.
Forwarding pullrequest to brianchandotcom.

liferay-continuous-integration · 2020-12-16T12:36:34Z

Pull request has been successfully forwarded to brianchandotcom#96987

liferay-continuous-integration · 2020-12-16T12:40:52Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#7123
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:liferay-tango#686
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:relevant
Spira Release Build:master - cgoncas > liferay-tango - PR#686 - 2020-12-16[03:03:21]
Spira Jenkins Build:publish-spira-report#11391

naraandrade and others added 30 commits December 15, 2020 20:08

LPS-124516 Fix alignment of info icon

4caed1d

LPS-124789 Consistency. Rename _removeCategoryParameters to _removeAs…

ae01cc4

…setCategoryParameters

LPS-124476 Check if post method for relatedSchema exists before using…

8001172

… it in the generated tests

LPS-124476 prep next

53135e3

LPS-115709 prep next

f6d1255

LPS-124476 LPS-115709 prep next

ce2fabd

LPS-58936 Take site/organization roles into consideration when checki…

a8b4951

…ng user permissions as stated by LPS-5695/LPE-1585

LPS-58936 Build service

f076c33

LPS-58936 Add corresponding method to PlugsUtil

3019407

LPS-58936 Apply usage. Only apply to page theme; control panel theme …

ec12431

…can only be changed at instance settings so site/organization roles does not need to be considered

LPS-58936 packageinfo

6bc2c8b

LPS-58936 SF

55b83f4

LPS-124828 If should take the default languageId value if exist

9caddff

LPS-124828 Change content through the store instead of using innerHTM…

d7074ad

…L which doesn't run the JS

LPS-124828 Take into account language id when updading the editable v…

ba54df1

…alues

LPS-124828 Embed calculation inside useEffect to avoid doing it in ev…

d337366

…ery render

LPS-124715 Use the correct classPK depending on the version in order …

6513822

…to retrieve the relevant MBDiscussion entry.

LPS-124596 use recursion to add nested fields values reference into t…

5c24c3c

…heir parents

LPS-124596 make sure edited will be a boolean

45d2f2b

LPS-124596 keep repeatable field index since visitor index doesn't wo…

c352d8d

…rk well with fields within fieldset

LPS-124596 store other available languages values into dataRecordValu…

068bc63

…es just like we do for non-repeatable fields

LPS-124596 sort var

3a8d182

LPS-124596 make it private

9654dfe

LPS-124596 fix compile, and auto SF

0900958

LPS-124596 make this private too

c0ff643

LPS-124596 auto SF

a904851

LPS-124388 Return longs as string to avoid Js rounding problems

10d50fc

Javascript doesnt have a proper integer type, it uses a floating point representation for all numbers. This may lead to weird rounding errors when storing longs/integers as raw numbers in a JSON object.

LPS-124710 Align button in Element Sets

d0e11f4

LPS-124514 Each form entry has its respective version of form instance

0527c6f

LPS-124514 Using inner join instead of just join as requested

0fdc059

liferay-continuous-integration added ci:test:stable - pending ci:test:sf - success and removed ci:test:sf - pending labels Dec 16, 2020

cgoncas mentioned this pull request Dec 16, 2020

LPS-123084 POC obtain user segments only when it is needed #505

Closed

liferay-continuous-integration added ci:test:relevant - failure ci:test:stable - success and removed ci:test:relevant - pending ci:test:stable - pending labels Dec 16, 2020

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending ci:test:relevant - success ci:test:stable - success and removed ci:test:relevant - failure ci:test:stable - success ci:test:relevant - pending ci:test:stable - pending labels Dec 16, 2020

liferay-continuous-integration mentioned this pull request Dec 16, 2020

LPS-123084 Calculate the segments only when there are experiences associated with the layout. brianchandotcom/liferay-portal#96987

Closed

liferay-continuous-integration closed this Dec 16, 2020

cgoncas deleted the LPS-123084.4 branch December 28, 2020 15:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LPS-123084 Calculate the segments only when there are experiences associated with the layout. #686

LPS-123084 Calculate the segments only when there are experiences associated with the layout. #686

cgoncas commented Dec 16, 2020 •

edited

liferay-continuous-integration commented Dec 16, 2020

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Dec 16, 2020

liferay-continuous-integration commented Dec 16, 2020

Base Branch:

Copied in Private Modules Branch:

2 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0

Job Results:

For upstream results, click here.

liferay-continuous-integration commented Dec 16, 2020

cgoncas commented Dec 16, 2020

liferay-continuous-integration commented Dec 16, 2020

liferay-continuous-integration commented Dec 16, 2020

liferay-continuous-integration commented Dec 16, 2020

Base Branch:

Copied in Private Modules Branch:

2 Failed Jobs:

For more details click here.

This pull contains no unique failures.

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0

Job Results:

liferay-continuous-integration commented Dec 16, 2020

liferay-continuous-integration commented Dec 16, 2020

liferay-continuous-integration commented Dec 16, 2020

LPS-123084 Calculate the segments only when there are experiences associated with the layout. #686

LPS-123084 Calculate the segments only when there are experiences associated with the layout. #686

Conversation

cgoncas commented Dec 16, 2020 • edited

liferay-continuous-integration commented Dec 16, 2020

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Dec 16, 2020

liferay-continuous-integration commented Dec 16, 2020

✔️ ci:test:stable - 9 out of 9 jobs passed

❌ ci:test:relevant - 21 out of 23 jobs passed in 1 hour 34 minutes

Base Branch:

Copied in Private Modules Branch:

2 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/0

Job Results:

For upstream results, click here.

liferay-continuous-integration commented Dec 16, 2020

cgoncas commented Dec 16, 2020

liferay-continuous-integration commented Dec 16, 2020

liferay-continuous-integration commented Dec 16, 2020

liferay-continuous-integration commented Dec 16, 2020

✔️ ci:test:stable - 9 out of 9 jobs passed

✔️ ci:test:relevant - 22 out of 23 jobs passed in 1 hour 31 minutes

Base Branch:

Copied in Private Modules Branch:

2 Failed Jobs:

For more details click here.

This pull contains no unique failures.

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0

Job Results:

liferay-continuous-integration commented Dec 16, 2020

liferay-continuous-integration commented Dec 16, 2020

liferay-continuous-integration commented Dec 16, 2020

cgoncas commented Dec 16, 2020 •

edited