Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make debounce tests use fake timers #1052

Closed
wincent opened this issue Jan 31, 2019 · 0 comments
Closed

Make debounce tests use fake timers #1052

wincent opened this issue Jan 31, 2019 · 0 comments
Labels
technical debt

Comments

@wincent
Copy link
Contributor

wincent commented Jan 31, 2019

These tests are a bit flakey and they end up failing spuriously from time to time:

IE 11.0.0 (Windows 10.0.0) Debounce should debounce function execution for the specified delay FAILED
    AssertionError: expected false to be truthy (node_modules/chai/chai.js:206)

We should rewrite them to not use real setTimeout calls but instead use fake timers that we can control precisely.
@wincent wincent mentioned this issue Feb 6, 2019
Merged
jbalsas added a commit that referenced this issue Feb 7, 2019
@jbalsas
Merge pull request #1075 from wincent/issue-1052
26e07e3 
Fixes #1052 - Use fake timers and clean up debounce tests
@jbalsas jbalsas closed this as completed Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
technical debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wincent @jbalsas