Advanced Editing Demo fails with console errors in IE11 #1228
Comments
|
|
|
The syntax error is from an arrow function that isn't transpiled to ES5: module.exports = () => {
return {
code: `module.exports = ${JSON.stringify(version)};`,
};
}; |
|
/cc @gregory-bretall |
|
Thanks for reporting this @blzaugg!
I'm not sure if that's the function though; that file should only be evaluated as part of the build process, and should never wind up in the browser. We'll dig into it further though. |
|
I'm afraid I can't repro this on IE 11 @blzaugg. Any ideas what might be needed to trigger? (I'm using IE 11 in a VirtualBox VM, hitting the webpack dev server that you get with
|
|
@wincent I was able to reproduce this on the most up to date master branch from today of alloy-editor, just by using yarn start. Not quite sure what the difference here is unless it's testing IE11 on Windows 10 potentially? |
|
Ok, thanks for that @gregory-bretall. I tested on a Windows machine here and I see the fix that is required. It's a build-time fix and not a run-time fix — on Windows the build produces a bad result. The reason I couldn't repro in the VM is that I wasn't running the build in Windows; I was running the build on Mac and hitting that from Windows. |
|
That makes sense then, thanks for looking into it @wincent! |
It turns out that the "test" property in the Webpack build needs to be
in a different format on Windows, otherwise it never matches, which
means that our file at "scripts/build/version.js" doesn't pass through
the val-loader, and in turn means that we produce untransformed output
that IE 11 will choke on (an arrow function, and even if we fixed it, it
would probably choke on the backticks).
You can make the build work on Windows by passing
`path.resolve('scripts/build/version.js')` instead; this produces an
absolute path with the appropriate Windows-style backslashes. But then
the build doesn't work on macOS. If you try to make it a relative path
(`path.relative('', path.resolve(...))`) then Webpack rejects it.
So, the solution is to make a RegExp with the backslashes (if present)
escaped.
Test plan: build on macOS and Windows (with `yarn build`, `yarn start`)
and confirm console errors are gone and version is correctly transpiled.
Note that the demo misbehaves still on IE 11 (not console errors, but
some misbehavior of the editor itself, but I think that's expected).
Closes: #1228
|
Thanks @gregory-bretall |
fix: console errors in Windows-based build (#1228)
Do you want to request a feature or report a bug?
Bug
What is the current behavior?
Demo doesn't work and console errors in browser
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem.
What is the expected behavior?
Demo works with no console errors.
Which versions of alloy-editor, and which browser / OS are affected by this issue? Did this work in previous versions?
Windows 7 Internet Explorer 11
The text was updated successfully, but these errors were encountered: