Bug: calling editor.destroy() throws javascript error #375

Closed
brunobasto opened this Issue Nov 13, 2015 · 4 comments

Comments

Projects
None yet
2 participants
@brunobasto
Member

brunobasto commented Nov 13, 2015

Hey guys,

Found a small issue. To reproduce, try this: brunobasto@9b71aff

Thanks,

@brunobasto brunobasto added the bug label Nov 13, 2015

@brunobasto brunobasto changed the title from Calling editor.destroy throws javascript error to Bug: calling editor.destroy throws javascript error Nov 13, 2015

@brunobasto brunobasto changed the title from Bug: calling editor.destroy throws javascript error to Bug: calling editor.destroy() throws javascript error Nov 13, 2015

@ipeychev

This comment has been minimized.

Show comment
Hide comment
@ipeychev

ipeychev Nov 14, 2015

Contributor

Hey @brunobasto,

Thanks for the report! The exception is not in our code, but in CKEditor's engine itself. It seems they don't like when you create an instance of the editor and then immediately destroy it.
This is not a critical bug, since normally the editor won't be destroyed immediately after its creation.
Keeping that in mind, we will have to upgrade to newer version of CKEditor (if any), or to report it and wait for a a fix.

Thanks,

Contributor

ipeychev commented Nov 14, 2015

Hey @brunobasto,

Thanks for the report! The exception is not in our code, but in CKEditor's engine itself. It seems they don't like when you create an instance of the editor and then immediately destroy it.
This is not a critical bug, since normally the editor won't be destroyed immediately after its creation.
Keeping that in mind, we will have to upgrade to newer version of CKEditor (if any), or to report it and wait for a a fix.

Thanks,

@brunobasto

This comment has been minimized.

Show comment
Hide comment
@brunobasto

brunobasto Nov 15, 2015

Member

Got it! Thanks, @ipeychev

Member

brunobasto commented Nov 15, 2015

Got it! Thanks, @ipeychev

@ipeychev

This comment has been minimized.

Show comment
Hide comment
@ipeychev

ipeychev Nov 21, 2015

Contributor

Hey @brunobasto,

It seems in CKEditor v4.4.5 this is fixed, they now throw a warning (http://docs.ckeditor.com/#!/guide/dev_errors-section-editor-incorrect-destroy). @jbalsas could upgrade to this version and this upgrade will fix #381 too.

Thanks,

Contributor

ipeychev commented Nov 21, 2015

Hey @brunobasto,

It seems in CKEditor v4.4.5 this is fixed, they now throw a warning (http://docs.ckeditor.com/#!/guide/dev_errors-section-editor-incorrect-destroy). @jbalsas could upgrade to this version and this upgrade will fix #381 too.

Thanks,

@ipeychev ipeychev closed this in #382 Nov 24, 2015

ipeychev added a commit that referenced this issue Nov 24, 2015

@brunobasto

This comment has been minimized.

Show comment
Hide comment
@brunobasto

brunobasto Nov 24, 2015

Member

Thanks, guys!

Member

brunobasto commented Nov 24, 2015

Thanks, guys!

@ipeychev ipeychev added this to the 0.7.1 milestone Nov 24, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment