Fix 3 lints by removing UNSUPPORTED_*_API variables #1016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I last touched these files I kept these variables in there as a kind of documentation, but I don't think they provide much value to be honest. Removing them to pacify these lints: ``` src/components/uibridge/button.jsx 14:6 error 'UNSUPPORTED_BUTTON_API' is assigned a value but never used no-unused-vars src/components/uibridge/menu-button.jsx 15:6 error 'UNSUPPORTED_MENUBUTTON_API' is assigned a value but never used no-unused-vars src/components/uibridge/richcombo.jsx 15:6 error 'UNSUPPORTED_RICHCOMBO_API' is assigned a value but never used no-unused-vars ``` With this change, those three files are lint-clean. Related: liferay#990
|
Just started reviewing :) |
Sent from 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I last touched these files I kept these variables in there as a kind of documentation, but I don't think they provide much value to be honest. Removing them to pacify these lints:
With this change, those three files are lint-clean.
Related: #990