fix(ie): make IE preserve other browsers' image width styling (#1275) #1276
Conversation
wincent
changed the title
src/plugins/dragresize_ie11.js
Outdated
| image.removeAttribute('style'); | ||
| let imageStyles = image.getAttribute('style'); | ||
| let widthStyles = /(width:.*?;)/g.exec(imageStyles); | ||
| let widthStyle = widthStyles[0]; |
There was a problem hiding this comment.
Seems all of these let should be const, right?
Also, about that regex: .*? is a non-greedy match (good), but * implies that zero-width is acceptable and it isn't, is it? ie. .+? would be a more accurate specification of what we're looking for. Not that I think we'll get a zero-width value there in practice, just that I think in general it's best to keep regexes as "tight" as possible.
There was a problem hiding this comment.
Yeah, they can all be const. Wasn't aware that's the convention but that makes sense.
Also good on .+? -- that's definitely better here
|
Didn't know if we were waiting for me to make those changes but I've updated my commit to reflect the feedback Let me know if there's anything else or when this can be merged so we can handle the LPS. thanks |
|
@wincent Any update on reviewing this one? thanks |
|
@SpencerWoo: We were looking this over but we had two days out due to office activities here in Madrid. @julien was testing it out and is going to merge it and cut a release today. |
|
awesome thanks guys |
…e styling
#1275
Instead of removing all the styles, keep the width (controls sizing) style