New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ie): add a check for 'imageStyles' before accessing (#1289) #1290

Merged

wincent merged 1 commit into liferay:master from fortunatomaldonado:Fix1289

Jul 19, 2019

Member

fortunatomaldonado commented Jul 15, 2019

Fixes #1289
https://issues.liferay.com/browse/LPS-98250

imageStyles needs to be checked before getting any information from it.

Let me know if there are any questions or comments about this.
Thank you.


          Fixes liferay#1289 Add a check for 'imageStyles'

e9ca50f

Contributor

wincent commented Jul 19, 2019

Thanks @fortunatomaldonado. Looks good.

wincent changed the title ~~Fixes #1289 Add a check for 'imageStyles'~~ fix(ie): add a check for 'imageStyles' before accessing (#1289)

wincent merged commit 5a2fd08 into liferay:master

wincent mentioned this pull request

fix: make IE also preserve other browers' image height styling #1298

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment