fix: make REGEX_URL validate links and stop validating non links #1383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wincent
reviewed
Feb 25, 2020
There was a problem hiding this comment.
So this fixes the reported issue ("eeeewwwww" getting linked) but it introduces other potentially unintended behavior (as noted, the tests don't do what they say they do any more).
At the very least, we should be adding a regression test that shows that "eeeewwww" no longer gets linked, and we need to have a rationale for why we think the other changes are acceptable.
wincent
reviewed
Feb 25, 2020
wincent
reviewed
Feb 25, 2020
wincent
reviewed
Feb 25, 2020
wincent
reviewed
Feb 25, 2020
wincent
reviewed
Feb 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://issues.liferay.com/browse/LPS-99704