Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Management Toolbar Clear Button must clean selection #868

Closed
victorvalle opened this issue May 4, 2018 · 5 comments
Closed

Management Toolbar Clear Button must clean selection #868

victorvalle opened this issue May 4, 2018 · 5 comments
Labels
2.x comp: clay-components Issues related to Clay components. (e.g ClayCard, ClayLabel...) type: feature request Issues that are open to adding new features

Comments

@victorvalle
Copy link

Testing the clear action we have realized that clear action in the results bar must clean the selection too. In this way, it avoids unexpected situations as consecutive searches and selection that could end up in "4 of 2 items selected"

Please see Page 15
@victorvalle
Copy link
Author

clear-with-selected-items

@carloslancha carloslancha added the type: feature request Issues that are open to adding new features label May 4, 2018
@carloslancha carloslancha changed the title clear in management bar must clean selection too Management Toolbar Clear Button must clean selection May 4, 2018
@matuzalemsteles
Copy link
Member

hey @carloslancha, In this case of blogs, does he use ClayDatasetDisplay? the developer can listen for the clearButtonClicked event of ManagementToolbar and can perform this behavior.

But in ClayDatasetDisplay, we have not implemented button clear actions and values to be passed to ManagementToolbar. I'll work on it.

@carloslancha
Copy link
Contributor

@matuzalemsteles nobody in portal is using ClayDatasetDisplay yet. It's something that will be added in the Management Toolbar probably, but will be for future versions, not prioritary now.

@matuzalemsteles
Copy link
Member

Oh okay, thanks!

@matuzalemsteles matuzalemsteles added the comp: clay-components Issues related to Clay components. (e.g ClayCard, ClayLabel...) label Nov 23, 2018
diegonvs added a commit to diegonvs/clay that referenced this issue Feb 27, 2019
@diegonvs
Fixes liferay#868 | Adds a better treatment to Intl when one item is …
e37b27c 
…selected inside ManagementToolbar
diegonvs added a commit to diegonvs/clay that referenced this issue Feb 27, 2019
@diegonvs
Fixes liferay#868 | Adds tests for all possible selection items cases
79bb8d7
diegonvs added a commit to diegonvs/clay that referenced this issue Feb 27, 2019
@diegonvs
Fixes liferay#868 | Update snapshots
f5d125a
diegonvs added a commit to diegonvs/clay that referenced this issue Feb 27, 2019
@diegonvs
Fixes liferay#868 | Adds examples to ManagementToolbar
7038235
diegonvs added a commit to diegonvs/clay that referenced this issue Feb 27, 2019
@diegonvs
Fixes liferay#868 | Removes unecessary step when testing
ea3ae69
@jbalsas
Copy link
Contributor

jbalsas commented Jan 20, 2020

Doing some spring-cleaning... closing all issues labeled as 2.x that are not type:bug since 2.x is in maintenance and we won't be proactively be taking these ones.

Thanks!

@jbalsas jbalsas closed this as completed Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.x comp: clay-components Issues related to Clay components. (e.g ClayCard, ClayLabel...) type: feature request Issues that are open to adding new features
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jbalsas @carloslancha @matuzalemsteles @victorvalle