Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clay-css): add new change-list-disabled SVG icon #2321

Merged
merged 2 commits into from
Aug 22, 2019

Conversation

pat270
Copy link
Member

@pat270 pat270 commented Aug 22, 2019

Fixes #2282

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3220

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 78.852%

Totals Coverage Status
Change from base Build 3218: 0.0%
Covered Lines: 1953
Relevant Lines: 2308

💛 - Coveralls

@matuzalemsteles
Copy link
Member

Thanks a lot @pat270.Can you see why Semantic Bot is rejecting this PR 🤷‍♂️? As soon as it's ok, we can move on.

@matuzalemsteles
Copy link
Member

I'm going ahead with this PR, I think it might be a bug of the Semantic Bot because it passed the other PR for 2.x and this title has also been used and had passed another PR.

@matuzalemsteles matuzalemsteles merged commit b309eb0 into liferay:master Aug 22, 2019
@wincent
Copy link
Contributor

wincent commented Aug 23, 2019

@matuzalemsteles: The thing about the Semantic Pull Requests bot on 2.x PR is that the config on the "master" branch doesn't apply there (each branch that you want to configure needs its own .github/semantic.yml — for example, see the one we have on the AlloyEditor 1.x branch).

So, I think the reason it didn't complain on 2.x is (probably) that that branch it doesn't have the "titleAndCommits" setting.

By default, only the PR title OR at least one commit messsage needs to have semantic prefix.

I guess that means that it doesn't like the backticks in the commit message, and on 2.x that was ok because it ignored the commit message and was satisfied by the PR title alone. We should probably:

  1. File an issue upstream.
  2. Configure the bot on the 2.x branch as well (just needs a copy of the .github/semantic.yml file).

@wincent
Copy link
Contributor

wincent commented Aug 23, 2019

Filed upstream report here.

@matuzalemsteles
Copy link
Member

Thanks a lot @wincent for investigating! I'll take care later to send the copy of .github/semantic.yml to branch 2.x, I had forgotten about that.

@pat270 pat270 deleted the clay-2282 branch December 23, 2019 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x comp: clay-css Issues related to Clay CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please include new icon: change-list-disabled
4 participants