feat: Icon for Collections in DXP #3549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carloslancha
changed the title
|
@drakonux yeah I agree |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to LEXI-962 we've decided to add a new icon to represent a Collection in DXP.
This is a complex concept because 1 or more collections can be part of an asset library. Thus we have decided to design the icon thinking the relationship with the asset library icon (books). In addition, we also added a little bookmark in anticipation of the icon for adding/saving elements to a Collection.
@pat270 I named it closed-book what do you think? I would have liked to name it book-closed but checking the other book icon (info-book) it's wiser to follow that naming order, isn't?