feat(@clayui/card): LPD-1261 Add name to group all radio type inputs #5828
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys!,
I am sending this pull because while fixing this bug https://liferay.atlassian.net/browse/LPD-1261, I realized the following:
bugRadioButton.mov
As you see in the video, when you navigate by keyboard, the navigation does not recognize which radio button is selected, and when you return to the cards, the radio input that is not selected is focused.
This happens because to group the radio buttons in a group it is necessary to add the same
name
to all the inputs https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/radiogroup_role.For that reason, for the radio buttons to work correctly I have added the
name
as required inradioProps
(apart fromvalue
), this being the correct behavior:fixRadioButton.mov
Let me know what you think, thanks in advance! 😃