Skip to content
This repository has been archived by the owner on Apr 21, 2021. It is now read-only.

Firefox on Windows triggers the click event for the right mouse button #58

Merged
merged 1 commit into from Sep 12, 2014

Conversation

FagnerMartinsBrack
Copy link
Contributor

Unfortunately I am having trouble to execute gulp test in windows. Several tests fail. I suppose this is going to be properly addressed once #52 is landed.

For that reason I wasn't able to create a proper test case for this pull, but the test should be pretty straightforward:

var element = document.querySelector('a[href="/base/page#hash"]');
// https://developer.mozilla.org/en-US/docs/Web/API/event.button
element.dispatchEvent(new MouseEvent('click', {button: 2}));
assert.strictEqual(app.pendingNavigate, null);
done();

@eduardolundgren
Copy link
Contributor

Just started reviewing :)

:octocat: Sent from GH.

@eduardolundgren
Copy link
Contributor

Thank you for the contribution, pull request merged.

:octocat: Sent from GH.

@FagnerMartinsBrack
Copy link
Contributor Author

The test case is important though, to avoid regression. I have created a new issue for this: #61

@eduardolundgren
Copy link
Contributor

I have added the test case already.

@FagnerMartinsBrack
Copy link
Contributor Author

Oh ok, didn't see that.

@FagnerMartinsBrack FagnerMartinsBrack deleted the FF_right_mouse_button branch September 12, 2014 18:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants