Fixed the close_connection issue #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I ran the demo, I noticed that the connections to the Redis server still persisted even after the websocket closed. I updated the Gemfile to pull the "em-hiredis" directly from mloughran's Github instead of RubyGems (the RubyGems's version didn't have a Client#close_connection method). Additionally, I updated your method call from "close_connection_after_writing" to "close_connection" which previously wouldn't close the connection.
Just wanted to say it was a great demo, and I hope these fixes will help the next developer who stumbles upon it :).