Skip to content

Fixed the close_connection issue #1

Merged
merged 2 commits into from Sep 10, 2011

2 participants

@johnkchow

When I ran the demo, I noticed that the connections to the Redis server still persisted even after the websocket closed. I updated the Gemfile to pull the "em-hiredis" directly from mloughran's Github instead of RubyGems (the RubyGems's version didn't have a Client#close_connection method). Additionally, I updated your method call from "close_connection_after_writing" to "close_connection" which previously wouldn't close the connection.

Just wanted to say it was a great demo, and I hope these fixes will help the next developer who stumbles upon it :).

@lifo lifo merged commit 05a90ee into lifo:master Sep 10, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.