Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up JqJsCmds to use fixHtmlCmdFunc to correctly install eventhandles after DOM is updated #1801

Open
andreak opened this issue Jun 17, 2016 · 2 comments
Open

Clean up JqJsCmds to use fixHtmlCmdFunc to correctly install eventhandles after DOM is updated #1801

andreak opened this issue Jun 17, 2016 · 2 comments
Assignees
@andreak
Labels
WebKit
Milestone
3.4.0-M1

Comments

@andreak
Copy link
Member

andreak commented Jun 17, 2016

As it is, usage of fixHtmlFunc often results in lift.onEvent() installing eventhandlers on elements which has not yet been inserted into the DOM, resulting in on*-events in AJAX-response not working when using AppendHtml and similar.
@andreak andreak self-assigned this Jun 17, 2016
@andreak andreak added this to the 3.0-RC4 milestone Jun 17, 2016
@andreak andreak mentioned this issue Jun 17, 2016
Closed
@Shadowfiend Shadowfiend modified the milestones: 3.1, 3.0-RC4 Nov 16, 2016
@Shadowfiend
Copy link
Member

As a first step, we're going to try to disable event extraction in fixHtmlFunc for now, targeted for 3.1.

Then we can look at a better solution.

@Shadowfiend Shadowfiend mentioned this issue Apr 24, 2017
Merged
Shadowfiend added a commit that referenced this issue Apr 26, 2017
@Shadowfiend
Merge pull request #1842 from lift/revolting-expressions
5d1299e 
Revolting Expressions: Disable event extraction for `fixHtmlFunc` (and `JsExp` by association)

This allows enabling extractInlineJavaScript without being worried about
JsExp not behaving correctly.

It is a first pass semi-fix for #1801, but a better, more complete fix should
be done that allows inline JS extraction to operate even in these cases. That's
for later, though.
@Shadowfiend Shadowfiend modified the milestones: 3.2.0-M2, 3.1.0-RC1 May 2, 2017
@Shadowfiend
Copy link
Member

Kicked the bigger implementation to 3.2.

@farmdawgnation farmdawgnation modified the milestones: 3.2.0-M2, 3.2.0-M3 Sep 15, 2017
@farmdawgnation farmdawgnation modified the milestones: 3.2.0-M3, 3.2.0-RC1 Nov 17, 2017
@farmdawgnation farmdawgnation modified the milestones: 3.2.0-RC1, 3.3.0-M1 Dec 14, 2017
@farmdawgnation farmdawgnation modified the milestones: 3.3.0-M1, 3.3.0-M2 Feb 8, 2018
@farmdawgnation farmdawgnation modified the milestones: 3.3.0-M2, 3.3.0-M3 Apr 14, 2018
@farmdawgnation farmdawgnation modified the milestones: 3.3.0-M3, 3.3.0-RC1 Jun 2, 2018
@farmdawgnation farmdawgnation modified the milestones: 3.3.0-RC1, 3.4.0-M1 Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreak andreak

Labels
WebKit
Projects
Lift 3.4.0
Status: To do
Milestone
3.4.0-M1
Development

No branches or pull requests
3 participants
@Shadowfiend @andreak @farmdawgnation