lift_uriSuffix can get lost during long-running AJAX requests #1327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By having it in doAjaxCycle, there were situations where the uri suffix could get lost. The most obvious one was when a long-running ajax request was occurring, and two AJAX requests were queued during that time frame. This would result in the first request getting the second request's uriSuffix, and the second request getting no suffix at all. We now immediately put the uriSuffix into the sending data when lift_ajaxHandler is called.
ghost
assigned
dpp
pushed a commit
that referenced
this pull request
Oct 11, 2012
lift_uriSuffix can get lost during long-running AJAX requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because lift_uriSuffix is read during doAjaxCycle, a long-running AJAX request that blocks processing of two sequentially queued AJAX calls can result in mangled uriSuffix reads.
The situation is as such:
The solution to this is to read the suffix during lift_ajaxHandler where we queue the request up, rather than waiting for other requests to complete.