Tweak some TimeHelpers specs for reliability. #1557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of the way specs2 matchers work, calculating the expected time in the call-by-name matcher could result in some weirdness. We now precompute the expected time.
| 3.seconds.later.getTime must beCloseTo(new Date().getTime + 3.seconds.millis, 500L) | ||
| val expectedTime = new Date().getTime + 3.seconds.millis | ||
|
|
||
| 3.seconds.later.getTime must beCloseTo(expectedTime, 500L) |
There was a problem hiding this comment.
could you still increase it to 700 or so? the test pass most of the time, so I think the "old" way was doing the right thing (I think).
|
Yeah, fair point. Bumped the time. |
|
Thanks 👍 |
fmpwizard
added a commit
that referenced
this pull request
May 6, 2014
Tweak some TimeHelpers specs for reliability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the way specs2 matchers work, calculating the expected time
in the call-by-name matcher could result in some weirdness. We now
precompute the expected time.
Can't guarantee this'll fix the issues, but I think it could help.