Fixed the new bind-less password change in ProtoUser #1703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just to check here, the issue at hand was that the CSS bind will bind two separate password inputs that will each receive one value, instead of creating one password input bound in two places, right? |
|
Yep... 2 different functions, 2 different values... neither sets the right thing in the duplicate password in the User |
|
Yep, I've been bitten by the laziness of CSS selector binds like this before… Obviously I haven't learned my lesson yet 😞 👍 on the change, let's get it in. |
Shadowfiend
added a commit
that referenced
this pull request
Apr 28, 2015
Fixed the new bind-less password change in ProtoUser The right side of CSS selector transforms is call-by-name, so we were computing two separate password fields for the password and confirmation input. As a result, we were failing to set the password because the confirmation input and password input both registered as not having a confirmation submitted for them. We now generate the password input ahead of time and reuse it to get the right behavior.
|
Ah, got it! Thanks! And sorry for taking your time, I just hate to drop it when I don't understand something… |
|
As well it should be :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an issue with the way CSS Selectors work so that password change in ProtoUser works again.