Add read-only status and event timestamps to metadata

[Jmgr]

This PR adds the read-only status to the metadata, as well as the first and latest timestamps of received messages, paused and read-only status changes.

I wasn't able to test this for now because FetchPartitionMetadata has not been pushed to go-liftbridge yet, so creating this PR as a draft.

[LaPetiteSouris]

This PR adds the read-only status to the metadata, as well as the first and latest timestamps of received messages, paused and read-only status changes.

I wasn't able to test this for now because FetchPartitionMetadata has not been pushed to go-liftbridge yet, so creating this PR as a draft.

My bad. FetchPartitionMetadata is implemented and I plan to open a PR to go-liftbridge today or tomorrow. I actually felt on some issues with testing on go-liftbridge so I spent time working on that first.

I think by tomorrow I will open a PR on go-liftbridge for FetchPartitionMetadata

[LaPetiteSouris]

FYI, you may need this to test the feature

[tylertreat]

Changes lgtm. Would be good to get some tests around the changes to FetchPartitionMetadata.

[Jmgr]

Changes lgtm. Would be good to get some tests around the changes to FetchPartitionMetadata.

Yes. I am waiting for liftbridge-io/go-liftbridge#90 to be merged, so I can create a PR for go-liftbridge adding the timestamps. I would then use it to add some API tests (in api_test.go) using FetchPartitionMetadata. I though about adding metadata tests (in metadata_test.go), but didn't find a way to simulate message publication using the metadataAPI to trigger a timestamps update, but I may have missed something?

[LaPetiteSouris]

Changes lgtm. Would be good to get some tests around the changes to FetchPartitionMetadata.

Yes. I am waiting for liftbridge-io/go-liftbridge#90 to be merged, so I can create a PR for go-liftbridge adding the timestamps. I would then use it to add some API tests (in api_test.go) using FetchPartitionMetadata. I though about adding metadata tests (in metadata_test.go), but didn't find a way to simulate message publication using the metadataAPI to trigger a timestamps update, but I may have missed something?

I guess a small unit test around getPartitionMetadata may work. ( I may make a small suggestion above )

IMO, the new feature you will add in the client may be tested separately using api mock (already in the client).

[tylertreat]

@Jmgr Right, I forgot the go-liftbridge PR hasn't been merged yet.

[Jmgr]

IMO, the new feature you will add in the client may be tested separately using api mock (already in the client).

I don't think so, unfortunately, because to test the received message timestamps you need to be able to publish a message. The changes in liftbridge-io/go-liftbridge#93 should allow testing this.

[Jmgr]

Changes lgtm. Would be good to get some tests around the changes to FetchPartitionMetadata.

Done.

[tylertreat]

lgtm, I think it just needs dependencies to be updated?

[Jmgr]

lgtm, I think it just needs dependencies to be updated?

Yes, I'm waiting for liftbridge-io/go-liftbridge#93 to be merged. I will remove the replace instruction then.

[tylertreat]

I've merged liftbridge-io/go-liftbridge#93

[Jmgr]

I've merged liftbridge-io/go-liftbridge#93

I have updated the dependency.